Carry every node's name on a check ask to the names check, so no repository lists them (ADR 0567 §12, issue 1126)

go/delivery/stepasks.go

@@ -340,8 +340,20 @@ type CheckJob struct {
 	// Packages, when set, are the only packages each level tests (issue 890, ADR 0552 §4): a placed ask names the
 	// packages the first ask left unmet, and the others are neither tested nor taken kept, so nothing is judged twice.
 	Packages []string `json:"packages,omitempty"`
+	// NodeNames are the names of every node with a record (novox/hq ADR 0567 §12), read by the checker from each
+	// `<node>.node` of node-engine's have: the names check of ADR 0507 §9 looks for them in the tree, so no repository
+	// has to list them. The build step hands them to its test tool as the argument NodeNamesArg, and the build module
+	// gives them to the tests in NodeNamesEnv.
+	NodeNames []string `json:"node-names,omitempty"`
 }
 
+// NodeNamesArg is the test tool's argument that carries a check's node names, and NodeNamesEnv the environment
+// variable a build module sets for the tests it runs from it, the names separated by commas.
+const (
+	NodeNamesArg = "node-names"
+	NodeNamesEnv = "MESH_NODE_NAMES"
+)
+
 func (a StepAsk) check() error {
 	if err := checkAskID(a.ID); err != nil {
 		return err
@@ -447,6 +459,13 @@ func (c CheckJob) check(id string) error {
 			return fmt.Errorf("delivery: the check ask %s names a package %q that is no import path", id, p)
 		}
 	}
+	seen := map[string]bool{}
+	for _, n := range c.NodeNames {
+		if err := checkName("node", n); err != nil || strings.Contains(n, ",") || seen[n] {
+			return fmt.Errorf("delivery: the check ask %s names the node %q, which is no node name or named twice", id, n)
+		}
+		seen[n] = true
+	}
 	return checkFetchArgs(id, c.Fetch)
 }