From 237e5fcc917c444acf92f7e0b753207c88698866 Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 20 Nov 2026 04:55:49 +0100 Subject: [PATCH] catalogue: no mention of the seat mesh-delivery-checker is left (CheckerSeat, its baseline word and the exclusion) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds: design 47 H §764 (The checker), H-A-57 --- go/catalogue/checker_seat.go | 6 ------ go/catalogue/manifest_reads_baseline.txt | 1 - go/catalogue/own_manifest_test.go | 5 ++--- go/catalogue/test_seats_test.go | 1 - go/testdata/beside/CAPTURED | 2 +- 5 files changed, 3 insertions(+), 12 deletions(-) delete mode 100644 go/catalogue/checker_seat.go diff --git a/go/catalogue/checker_seat.go b/go/catalogue/checker_seat.go deleted file mode 100644 index d13d3b81..00000000 --- a/go/catalogue/checker_seat.go +++ /dev/null @@ -1,6 +0,0 @@ -package catalogue - -// CheckerSeat is the seat mesh-delivery-checker holds. -// -// Deprecated: a whole seat's name is mesh-contracts' (seats.MeshDeliveryChecker); kept for its importers until their -// next change takes it from there (testdata/seat-names.txt). diff --git a/go/catalogue/manifest_reads_baseline.txt b/go/catalogue/manifest_reads_baseline.txt index 15f8e45f..e1f0f367 100644 --- a/go/catalogue/manifest_reads_baseline.txt +++ b/go/catalogue/manifest_reads_baseline.txt @@ -20,7 +20,6 @@ seat:mesh-catalog seat:mesh-conditions seat:mesh-config seat:mesh-delivery -seat:mesh-delivery-checker seat:mesh-dns-resolver seat:mesh-enrolment seat:mesh-hand-acts diff --git a/go/catalogue/own_manifest_test.go b/go/catalogue/own_manifest_test.go index 449fa07c..5c86bd0b 100644 --- a/go/catalogue/own_manifest_test.go +++ b/go/catalogue/own_manifest_test.go @@ -58,9 +58,8 @@ func TestOwnManifestUsesNoWordTheRunningControllerRefuses(t *testing.T) { } // The two seats the milestone renamed (ADR 0634 §9) are read by their new names; a node-engine built with the baseline // reads the old ones, and a manifest of the new names is the milestone's to deliver after the engines. The word - // `waits` is no longer read: novox/hq ADR 0670 §2 retired it. The seat mesh-delivery-checker is gone with the checker - // (design 47 H §764, H-A-42). - renamed := []string{"seat:mesh-enrolment", "seat:mesh-placement", "word:waits", "seat:mesh-delivery-checker"} + // `waits` is no longer read: novox/hq ADR 0670 §2 retired it. + renamed := []string{"seat:mesh-enrolment", "seat:mesh-placement", "word:waits"} for _, b := range baseline { if !slices.Contains(reads, b) && !slices.Contains(renamed, b) { t.Errorf("the baseline's %s is no reader capability of this contract", b) diff --git a/go/catalogue/test_seats_test.go b/go/catalogue/test_seats_test.go index 06ca6ad8..975def74 100644 --- a/go/catalogue/test_seats_test.go +++ b/go/catalogue/test_seats_test.go @@ -17,7 +17,6 @@ func DefaultSeats() []Seat { return append([]Seat(nil), defaultSeats...) } // non-test code). const ( CatalogSeat = "mesh-catalog" - CheckerSeat = "mesh-delivery-checker" EnrolmentSeat = "mesh-node-enroller" PlacementSeat = "mesh-module-assigner" DeliverySeat = "mesh-delivery" diff --git a/go/testdata/beside/CAPTURED b/go/testdata/beside/CAPTURED index 07ea05df..fcac974b 100644 --- a/go/testdata/beside/CAPTURED +++ b/go/testdata/beside/CAPTURED @@ -14,7 +14,7 @@ mesh-catalog b5dbfbb784507e211372a7c9640d91f7d6dadd84 modules/*/module.json, m mesh-contracts cf5590c7599d3ee3b61c3aa66c88a939ecb41130 the seat files of the eight bootstrapped seats held there (seats/, health-and-repair/seats/, operator-and-conversation/seats/), as seat.json.captured (milestone 47/G) mesh-contracts bfc5073b824ef355270da4c44ccf8fa709f6a253 seats/mesh-broker/seat.json, taken again (milestone 47/G lead answer A-388) mesh-contracts dca9ce0245595cce2ff75ff155833ecc50a99bc0 seats/node-engine/seat.json and operator-and-conversation/seats/operator-channel/seat.json, taken again as seat.json.captured (milestone 47/H1, branch feat/47-H1-seats) -mesh-delivery 5bf848144283055a1ef37441eeda0e439fb6ad7e contracts/seats/mesh-catalog and mesh-delivery-checker, as seat.json.captured (go/seatlist's bootstrap test; milestone 47/G) +mesh-delivery 5bf848144283055a1ef37441eeda0e439fb6ad7e contracts/seats/mesh-catalog, as seat.json.captured (go/seatlist's bootstrap test; milestone 47/G) mesh-delivery 0259d77d115c95dde492ac2360e9a518d992adb0 modules/mesh-delivery-contracts/seats/mesh-catalog and git, taken again and added (milestone 47/G lead answer A-387) mesh-delivery f006ab50bcc2e5759627f20fa7e5a9c62501032d modules/mesh-delivery-contracts/seats/git, mesh-delivery and mesh-catalog, taken again as seat.json.captured (milestone 47/H1, branch feat/47-H1-contracts-indexer-bridge; the checker seat is dropped) mesh-delivery f8bbde9627255fe37bd6603a40fcce14fb61d97b modules/mesh-delivery-contracts/seats/git/seat.json, taken again as seat.json.captured (milestone 47/H1, C2)