From 4784762a70ceb47be1f60623720bff0766fe9b63 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 03:51:35 +0200 Subject: [PATCH] Name every repository's siblings in beside's comment, mesh-controller beside mesh-host's tests, as the checker places them (issue 1295) --- go/internal/beside/beside.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/go/internal/beside/beside.go b/go/internal/beside/beside.go index 93a0d40..d31ec1d 100644 --- a/go/internal/beside/beside.go +++ b/go/internal/beside/beside.go @@ -15,7 +15,12 @@ // `mesh/repo-check` runs; a repository missing there fails the test, never skips it. Which clones a // check gets is chosen from the inventory: mesh-catalog by the source of the `nats` module, mesh-host // by the source of `mesh-host`, and mesh-sdk as the controller's sibling at the commit the controller's -// go.mod pins. In a mesh where either module has no source repository nothing is +// go.mod pins. Each repository's tests read these siblings, and the checker places exactly these +// (mesh-delivery's checker, besideRules, follows this list): mesh-controller's read mesh-catalog, +// mesh-host and mesh-sdk; mesh-host's read mesh-catalog, mesh-sdk and mesh-controller (its step-nine +// test reads the controller's own manifest, novox/hq issue 1295); mesh-sdk's read mesh-catalog and +// mesh-host; mesh-catalog's read mesh-sdk and mesh-controller; mesh-delivery's read mesh-sdk and +// mesh-catalog. In a mesh where either module has no source repository nothing is // cloned, and these tests fail loudly with "not beside this check": a cause in the setup, not in the // change. And in a delivery group that holds a mesh-catalog pull request, these tests read the // catalogue's main, not the group's head.