From a2c813a6b468899bb5a95666b8f6f305be52f200 Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 23 Oct 2026 17:03:21 +0200 Subject: [PATCH] Stand in node-tools beside the toolchain modules in the composition test, as the catalogue's build modules require it since issue 1911, so the test judges the toolchain alone (issue 1887, group check of #73) --- go/catalogue/toolchain_manifests_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/go/catalogue/toolchain_manifests_test.go b/go/catalogue/toolchain_manifests_test.go index c5c58bd..dc5d09a 100644 --- a/go/catalogue/toolchain_manifests_test.go +++ b/go/catalogue/toolchain_manifests_test.go @@ -11,7 +11,8 @@ import ( // builderNode is a machine that can run a build module: the package manager and user namespaces it asks of // the machine, and the forge account (mesh-scope, provided by the forge) and the artifact store the build -// modules publish to (ADR 0513, provided by distribution) stood in for. +// modules publish to (ADR 0513, provided by distribution) stood in for, and node-tools, the tool runner they pull their +// asks through (mesh-catalog issue 1911; mesh-tools' module, not in the catalogue). func builderNode() Node { return Node{Name: "builder", Site: "house", Capabilities: map[string]bool{"package-manager": true, "user-namespaces": true}} @@ -20,7 +21,7 @@ func builderNode() Node { func toolchainShelf(t *testing.T) map[string]Manifest { t.Helper() m := map[string]Manifest{ - "forge": {Module: "forge", Version: "1", Provides: []Offer{{Name: "forge-account"}, {Name: "npm-package-registry"}, {Name: "artifact-store"}}}, + "forge": {Module: "forge", Version: "1", Provides: []Offer{{Name: "forge-account"}, {Name: "npm-package-registry"}, {Name: "artifact-store"}, {Name: "node-tools"}}}, } for _, name := range []string{"go", "nodejs", "mesh-build-go", "mesh-build-node", "dev-tools"} { m[name] = catalogueManifest(t, name)