Run an ask no more once its stream delivered it past AskRuns, failing its step with why, so a run that kills its node is not offered to each build node in turn (issue 1907)

2026-10-23 16:41:12 +02:00
parent fc4f57c4b3
commit bec9585d50
4 changed files with 52 additions and 1 deletions
@@ -281,6 +281,15 @@ func (p *Puller) take(ctx context.Context, msg *Pulled) {
 		_ = msg.Nak()
 		return
 	}
+	if msg.Delivered > delivery.AskRuns {
+		// Run AskRuns times and never ended: each run took its node down or died with it. It is run no more, and said
+		// (issue 1907): the asker's key fails with why.
+		why := fmt.Errorf("the ask was taken %d times and no run of it ended: each took its build node down or died with it, so it is run no more (poison)", msg.Delivered-1)
+		p.logf("the ask %s is ended on %s: %v", ask.ID, p.Node, why)
+		finish(p.Put, key, step, nil, why)
+		_ = msg.Term()
+		return
+	}
 	module := ""
 	if ask.Build != nil {
 		module = ask.Build.Module