From e45bdc0891bb7c90be639c4903d51bb5dc61a2ac Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 20:20:48 +0200 Subject: [PATCH] Drop plan-moved and sent from the controller seat's events (issue 1943; the review's notes on 1945) No plan is kept or sent in release 6 (ADR 0539), and the messenger now hears the delivery view's events instead. --- go/catalogue/seats.go | 5 +---- go/catalogue/verbs_r6_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/go/catalogue/seats.go b/go/catalogue/seats.go index a0f73eb..b0327ce 100644 --- a/go/catalogue/seats.go +++ b/go/catalogue/seats.go @@ -110,10 +110,7 @@ var defaultSeats = append([]Seat{ "rolled-back", // A pull request's merge check, judged (novox/hq to-be 45 §9). "checked", - // A walk kept in a new state, for the delivery it walks (novox/hq ADR 0239). - "plan-moved", - // A tier sent to a machine, once the send is kept (novox/hq ADR 0406 §5, issue 974). - "sent", + // (A walk kept in a new state and a tier sent to a machine are gone with the plans, novox/hq ADR 0539.) // A key of a record mirror written or removed (novox/hq ADR 0289, design 54 §3; design 57 F3). "assignment-changed", "declared-config-changed", "predefined-changed", // A builder's key not taken in because the artifact store does not hold an artifact it names (novox/hq diff --git a/go/catalogue/verbs_r6_test.go b/go/catalogue/verbs_r6_test.go index ddad237..f38d7d4 100644 --- a/go/catalogue/verbs_r6_test.go +++ b/go/catalogue/verbs_r6_test.go @@ -113,3 +113,17 @@ func TestTheControllerSaysABucketItDeleted(t *testing.T) { t.Errorf("the controller's seat does not emit bucket-deleted: %v", seat.Emits) } } + +// 1943 (the review's notes on 1945): the controller's seat no longer says a walk moved or a tier was sent: there is no +// plan (ADR 0539). +func TestTheControllerSaysNoPlanEvents(t *testing.T) { + seat, ok := SeatNamed(ControllerSeatName) + if !ok { + t.Fatal("no controller seat") + } + for _, gone := range []string{"plan-moved", "sent"} { + if SeatSays(seat.Emits, gone) { + t.Errorf("the controller's seat still emits %s", gone) + } + } +}