views: count the events no handler takes as the module's finding
An event a module consumes that no handler takes was said in the journal alone, so a part that never acted on it (the runner's placing at 17:34) was seen only by reading the log. The event hub now tells a hook of each such subject; the process reader, where it holds a findings writer, counts them in one finding event-unhandled per module (the count since the start and the last subject) and clears it at its start, since a new build may handle the event. Without a findings writer the journal line stands alone. Builds: design 47 H H-A-166, H-A-169
This commit is contained in:
@@ -73,6 +73,10 @@ type ProcessReader struct {
|
||||
asked bool
|
||||
begun map[string]context.CancelFunc
|
||||
status *process.AwaitedBucket
|
||||
// unheard counts the events no handler of the module took since Start, the last of them on lastUnheard (H-A-169).
|
||||
unheard int
|
||||
lastUnheard string
|
||||
startedAt time.Time
|
||||
}
|
||||
|
||||
// adoptedHear is one adopted follower's handler of its seat event, by its picture's bucket.
|
||||
@@ -395,6 +399,50 @@ func (r *ProcessReader) Hear(ctx context.Context) func(jetstream.Msg) {
|
||||
}
|
||||
r.logf("views: %s is no views event of an owner followed, acknowledged", m.Subject())
|
||||
_ = m.Ack()
|
||||
r.unhandled(m.Subject())
|
||||
}
|
||||
}
|
||||
|
||||
// now is the reader's clock.
|
||||
func (r *ProcessReader) now() time.Time {
|
||||
if r.Now != nil {
|
||||
return r.Now()
|
||||
}
|
||||
return time.Now()
|
||||
}
|
||||
|
||||
// unhandled counts an event no handler of the module took, said in the log already, in the module's finding
|
||||
// `event-unhandled` (design 47 H, H-A-166, H-A-169); with no findings writer the log line stands alone.
|
||||
func (r *ProcessReader) unhandled(subject string) {
|
||||
if r.Findings == nil {
|
||||
return
|
||||
}
|
||||
r.mu.Lock()
|
||||
r.unheard++
|
||||
r.lastUnheard = subject
|
||||
count, since := r.unheard, r.startedAt
|
||||
r.mu.Unlock()
|
||||
w := r.Findings()
|
||||
if w == nil {
|
||||
return
|
||||
}
|
||||
if err := unhandledFinding(r.Module, count, subject, since, r.now()).put(w); err != nil {
|
||||
r.logf("views: the finding %s of %s is not written: %v", EventUnhandledKind, r.Module, err)
|
||||
}
|
||||
}
|
||||
|
||||
// clearUnhandled clears the module's finding `event-unhandled` at the process's start: a new build may handle the event
|
||||
// (H-A-169).
|
||||
func (r *ProcessReader) clearUnhandled() {
|
||||
if r.Findings == nil {
|
||||
return
|
||||
}
|
||||
w := r.Findings()
|
||||
if w == nil {
|
||||
return
|
||||
}
|
||||
if err := (viewFinding{kind: EventUnhandledKind, id: r.Module}).drop(w); err != nil {
|
||||
r.logf("views: the finding %s of %s is not cleared at its start: %v", EventUnhandledKind, r.Module, err)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -847,7 +895,13 @@ func (r *ProcessReader) Start(ctx context.Context, js jetstream.JetStream, cred
|
||||
})
|
||||
hear := r.Hear(ctx)
|
||||
err := hub.Handle(pattern, hear)
|
||||
if r.Findings != nil {
|
||||
// H-A-169: the events no handler of the module takes are its finding, cleared at each start
|
||||
r.clearUnhandled()
|
||||
hub.OnUnhandled(r.unhandled)
|
||||
}
|
||||
r.mu.Lock()
|
||||
r.startedAt = r.now()
|
||||
r.status = status
|
||||
if !own {
|
||||
// an event adopted after the start is handled on the module's hub (Adopt); the reader's own hub takes every one
|
||||
|
||||
Reference in New Issue
Block a user