From effd0c00a6227590a05f9cb70d0b96a9e24ef3a0 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 4 Nov 2026 12:31:17 +0100 Subject: [PATCH] The seat set's test takes node-engine as a seat defined whole, with ADR 0618's manifest-reads among its added verbs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mesh-contracts now defines the node-engine seat whole (ADR 0613 §3): its verbs carry answers and it says manifest-reads-changed, so the set compares it as it compares every whole seat. Nothing else here is redundant: the seat's hand-written list went in SDK-8, and the compose-candidate layouts keep their checks, which a generated package does not carry, until the seat's client package exists (ADR 0625 §2, proposed). Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn --- go/catalogue/seats_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/go/catalogue/seats_test.go b/go/catalogue/seats_test.go index 8afda6e..dd13a59 100644 --- a/go/catalogue/seats_test.go +++ b/go/catalogue/seats_test.go @@ -54,10 +54,11 @@ func TestUseSeatsReplacesTheSetButNeverEmptiesIt(t *testing.T) { if err := json.Unmarshal(raw, &compiled); err != nil { t.Fatal(err) } - whole := []string{"npm-package-registry", "mesh-broker", "mesh-config", "mesh-vault", "mesh-delivery-checker"} + whole := []string{"npm-package-registry", "mesh-broker", "mesh-config", "mesh-vault", "mesh-delivery-checker", "node-engine"} dropped := map[string]bool{"mesh-vault.accept": true, "mesh-vault.move-asks": true} - // Verbs a seat at the seat list's grain gained in the milestone, each optional until its holders serve it. - addedVerbs := map[string]bool{"node-engine.pull-waits": true} + // Verbs a seat gained in the milestone, each optional until its holders serve it: node-engine's manifest-reads (ADR + // 0618 §3) came with its move whole. + addedVerbs := map[string]bool{"node-engine.pull-waits": true, "node-engine.manifest-reads": true} norm := func(v any) any { b, _ := json.Marshal(v) var out any