The provider loop's tests wait on what they mean, not on the clock (issue 1901 note 27) #101

2026-10-26T20:57:55Z

mesh-tools commented

2026-10-26 20:57:55 +00:00

Two checks failed tonight on timing races in mesh-sdk's TypeScript tests under load (the checker's machines): L2's at 20:29 (test/standing.test.ts: a recovery said before the retirement) and the capacity group's at ~21:30 (test/retire.test.ts:302 'an addition acts on the first pass'). Both were hidden as a passing line by the old verdict (issue 1901).

The kind fixed in both files: a test asserted that the loop had or had not acted by a wall-clock moment, or cleared state the running loop reads. Each test now waits on the attempt count or measures the gap it claims; L2's holdsErrFor fix is included (3a095a6), so the two branches agree. Test-only: no SDK source changed, no new test function.

Proved: the reviewer's mutant (a success not resetting an unannounced run) now fails 3/3 (it passed at the first head); a second mutant announcing on the first failure fails too. Unloaded: 55/55 pass.

Quick fix: retry flaky tests. Thorough fix (chosen): remove the clock assumptions in the whole file pair.

No try: this pull request's check is its only run.

Reviewed-by: review-standing@shanks at 18e541c1ba

Two checks failed tonight on timing races in mesh-sdk's TypeScript tests under load (the checker's machines): L2's at 20:29 (test/standing.test.ts: a recovery said before the retirement) and the capacity group's at ~21:30 (test/retire.test.ts:302 'an addition acts on the first pass'). Both were hidden as a passing line by the old verdict (issue 1901). The kind fixed in both files: a test asserted that the loop had or had not acted by a wall-clock moment, or cleared state the running loop reads. Each test now waits on the attempt count or measures the gap it claims; L2's holdsErrFor fix is included (3a095a6), so the two branches agree. Test-only: no SDK source changed, no new test function. Proved: the reviewer's mutant (a success not resetting an unannounced run) now fails 3/3 (it passed at the first head); a second mutant announcing on the first failure fails too. Unloaded: 55/55 pass. Quick fix: retry flaky tests. Thorough fix (chosen): remove the clock assumptions in the whole file pair. No try: this pull request's check is its only run. Reviewed-by: review-standing@shanks at 18e541c1badca3108249c1c320d2d35bac4c5d82

mesh-tools added 4 commits 2026-10-26 20:57:56 +00:00

The standing test keeps c failing alone after its ask is dropped, so its only recovery is its retirement: clearing every failure at once raced the loop's read of the new list under load (issue 1126; the hidden failure of try-1793042418286545971, issue 1901) 3a095a66be

The standing and retirement tests wait on what they mean, not on a slept fraction of a bound: announcements are timed from the clock at the moment they are said, short runs are counted in attempts, an addition is proved by a hold it must not wait for (the second timing race of one kind in a day; issue 1126) 36ae0c691b

The standing test's runs last 0.6 of failingAfterMs of clock as well as two attempts, so a success that does not reset a run is caught; the addition test holds a thousand stable passes, so 'first pass' is proved (review of the standing test races) cf930388f9

The standing test allows 10 ms between the loop's clock and the test's stamp of an announcement

mesh/delivery merged: source.main moved to novox/mesh-sdk@7187beaf042b

Details

mesh/check pass 18e541c1badc on 7187beaf042b | carried from 2cbe21937153 | a compiled program is not refused: mesh-build-node reported no programs | u…

18e541c1ba

mesh-tools commented

2026-10-26 20:58:02 +00:00

Delivery novox/mesh-sdk@18e541c1badc — merged since 2026-10-26T20:58:47Z

Source — source.main moved to novox/mesh-sdk@7187beaf04. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-26 20:57 (new) → proposed (announced): novox/mesh-sdk#101's head announced
2026-10-26 20:58 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 20:58 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-sdk@18e541c1badc` — **merged** since 2026-10-26T20:58:47Z **Source** — source.main moved to novox/mesh-sdk@7187beaf042b. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 20:57 (new) → proposed (announced): novox/mesh-sdk#101's head announced - 2026-10-26 20:58 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 20:58 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 7187beaf04 into main

2026-10-26 20:58:45 +00:00

mesh-tools deleted branch fix/standing-test-races

2026-10-26 20:58:45 +00:00

mesh-tools referenced this pull request

2026-10-26 21:09:16 +00:00

Nodes compose: placement, node records and one composer input for three callers (issue 1126) #98

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#101