process: a module's own bus connection, subjects and durable consumer in one helper (issue 1242) #108

Merged

mesh-tools merged 2 commits from fix/1242-bus-helper into main 2026-10-27 19:49:19 +00:00

Conversation 2 Commits 2 Files Changed 2

+132

mesh-tools commented 2026-10-27 19:46:31 +00:00

Member

Copy Link

Copy Source

Issue 1242: each delivery part hand-wrote its credential, pinned dial, own-stream subjects and durable consumer. This adds them to go/process (module.go): ReadBrokerAccount, Account.Dial/DialOptions, EventSubject, StreamSubject, ModuleStreamSubject, EventConsumerName, EventConsumer, HearEvents. Delivery group fix/1242-bus-helper with novox/mesh-delivery.

Quick or thorough: quick = copy the watchman's block into the parts lacking it (7 copies stay); thorough (chosen) = one sdk helper, every part on it, and a guard test refusing a hand-written connection, since the kind recurs in every part.

Tests: TestModuleAccountNamesAndDialOptions (table). Rule bent: the developer ran the integration tests of teller, forge-bridge, watchman and view locally against an embedded bus (how-we-build keeps integration tests in the forge's check); they passed, and the check runs them again.

Reviewed-by: review-1242@shanks at 8ad9372b19

Issue 1242: each delivery part hand-wrote its credential, pinned dial, own-stream subjects and durable consumer. This adds them to go/process (module.go): ReadBrokerAccount, Account.Dial/DialOptions, EventSubject, StreamSubject, ModuleStreamSubject, EventConsumerName, EventConsumer, HearEvents. Delivery group fix/1242-bus-helper with novox/mesh-delivery. Quick or thorough: quick = copy the watchman's block into the parts lacking it (7 copies stay); thorough (chosen) = one sdk helper, every part on it, and a guard test refusing a hand-written connection, since the kind recurs in every part. Tests: TestModuleAccountNamesAndDialOptions (table). Rule bent: the developer ran the integration tests of teller, forge-bridge, watchman and view locally against an embedded bus (how-we-build keeps integration tests in the forge's check); they passed, and the check runs them again. Reviewed-by: review-1242@shanks at 8ad9372b19520f292d7a675d0457fa5832104a4c

mesh-tools added 2 commits 2026-10-27 19:46:31 +00:00

Give a module's own credential its dial, subjects and durable consumer in mesh-sdk, so a part no longer hand-writes them (issue 1242) 3236cbad43

Name another module's own-stream subject in the SDK too (issue 1242) 8ad9372b19

mesh-tools commented 2026-10-27 19:46:34 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-sdk@8ad9372b1952 — merged since 2026-10-27T19:49:22Z

Source — source.main moved to novox/mesh-sdk@9f92233a28. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1242-bus-helper: novox/mesh-delivery@96be0c3377, novox/mesh-sdk@8ad9372b19

Transitions

• 2026-10-27 19:46 (new) → proposed (announced): novox/mesh-sdk#108's head announced
• 2026-10-27 19:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-10-27 19:49 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@8ad9372b1952` — **merged** since 2026-10-27T19:49:22Z **Source** — source.main moved to novox/mesh-sdk@9f92233a2890. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1242-bus-helper`: novox/mesh-delivery@96be0c3377c4, novox/mesh-sdk@8ad9372b1952 **Transitions** - 2026-10-27 19:46 (new) → proposed (announced): novox/mesh-sdk#108's head announced - 2026-10-27 19:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 19:49 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-27 19:46:40 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit 9f92233a28 into main 2026-10-27 19:49:19 +00:00

mesh-tools deleted branch fix/1242-bus-helper 2026-10-27 19:49:19 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#108