One predicate for a module the mesh provides itself (mesh-wireguard), used by the placement check (issue 1126) #120

Merged
mesh-tools merged 1 commits from fix/1126-provided into main 2026-10-28 20:39:21 +00:00
Member

The cause: the seed was refused, "the indexer holds no module mesh-wireguard" on every node, because the seed's check (CheckPlacements) lacked the exception mesh-grants and the controller already make: the private network is the mesh's own module, built in code (overlay.Manifest), and no repository the indexer reads holds it.

The fix: delivery.ProvidedModules, ProvidedByMesh and ProvidedManifest, built from overlay, in one place. CheckPlacements takes a provided module whatever the indexer holds, and frombus provides it by the same list. A row in TestPlacement: mesh-wireguard placed with nothing held passes.

Issue 1126, ADR 0567

Reviewed-by: rev-l2@shanks at 5228a5782d

The cause: the seed was refused, "the indexer holds no module mesh-wireguard" on every node, because the seed's check (CheckPlacements) lacked the exception mesh-grants and the controller already make: the private network is the mesh's own module, built in code (overlay.Manifest), and no repository the indexer reads holds it. The fix: delivery.ProvidedModules, ProvidedByMesh and ProvidedManifest, built from overlay, in one place. CheckPlacements takes a provided module whatever the indexer holds, and frombus provides it by the same list. A row in TestPlacement: mesh-wireguard placed with nothing held passes. Issue 1126, ADR 0567 Reviewed-by: rev-l2@shanks at 5228a5782d5c6e612a31239ec1df059f973e3981
mesh-tools added 1 commit 2026-10-28 19:15:13 +00:00
Name the modules the mesh provides itself in one predicate, so the seed's check takes the private network as the composer and the grants part do (issue 1126)
mesh/delivery merged: source.main moved to novox/mesh-sdk@6b43afa2ab38
mesh/delivery-group group fix/1126-provided merged: every member is merged
mesh/check checking 5228a5782d5c on d7c790d2422c | novox/mesh-sdk#120 in group fix/1126-provided
5228a5782d
Author
Member

Delivery novox/mesh-sdk@5228a5782d5c — merged since 2026-10-28T20:39:23Z

Source — source.main moved to novox/mesh-sdk@6b43afa2ab. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1126-provided: novox/mesh-delivery@d8286d1790, novox/mesh-sdk@5228a5782d

Transitions

  • 2026-10-28 19:15 (new) → proposed (announced): novox/mesh-sdk#120's head announced
  • 2026-10-28 19:15 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-28 20:39 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@5228a5782d5c` — **merged** since 2026-10-28T20:39:23Z **Source** — source.main moved to novox/mesh-sdk@6b43afa2ab38. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1126-provided`: novox/mesh-delivery@d8286d1790fb, novox/mesh-sdk@5228a5782d5c **Transitions** - 2026-10-28 19:15 (new) → proposed (announced): novox/mesh-sdk#120's head announced - 2026-10-28 19:15 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 20:39 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 6b43afa2ab into main 2026-10-28 20:39:21 +00:00
mesh-tools deleted branch fix/1126-provided 2026-10-28 20:39:21 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#120