A node's answer holds as today what it holds today, so a seed that reproduces today is the same (issue 1126) #124

Closed
mesh-tools wants to merge 0 commits from fix/1126-seed-held into main
Member

A module a node holds today, that the seed holds too, counts as the same. L2's seed was refused on novox for de-spiegel, mailu, nftables, postgres, route-proxy and node, all held there today under the controller too.

The fix: CandidateAnswer.Held, filled by frombus.Answer from Scope.HeldToday, carries each such module with why; VerdictOf ignores it, and a refused module not held today stays a refusal. The proposal's brief (judge.Brief) says "stays held as today" by node, so the operator sees what stays held.

And the seed carries its nodes' differences, named in its Approve (the operator, 2026-10-28 22:34 CET): PlacementVerdict.Carried, by node, each the first differing field with its value as it runs and as composed ("node-tools: MESH_OWNED_PATHS[/etc/resolv.conf] networkmanager (node-uplink) → systemd-resolved (node-resolver)"), cut to 60 characters, "(value cut)" where a body is cut. A refusal or a silent node still fails.

Rows: every refused module held today answers no refusal; only one held leaves the rest refused; the brief shows a held module; the seed carries a difference, named with both values.

Issue 1126, ADR 0567 §3-4

Reviewed-by: rev-l2@shanks at 77b48a4f1a

A module a node holds today, that the seed holds too, counts as the same. L2's seed was refused on novox for de-spiegel, mailu, nftables, postgres, route-proxy and node, all held there today under the controller too. The fix: `CandidateAnswer.Held`, filled by `frombus.Answer` from `Scope.HeldToday`, carries each such module with why; `VerdictOf` ignores it, and a refused module not held today stays a refusal. The proposal's brief (`judge.Brief`) says "stays held as today" by node, so the operator sees what stays held. And the seed carries its nodes' differences, named in its Approve (the operator, 2026-10-28 22:34 CET): `PlacementVerdict.Carried`, by node, each the first differing field with its value as it runs and as composed ("node-tools: MESH_OWNED_PATHS[/etc/resolv.conf] networkmanager (node-uplink) → systemd-resolved (node-resolver)"), cut to 60 characters, "(value cut)" where a body is cut. A refusal or a silent node still fails. Rows: every refused module held today answers no refusal; only one held leaves the rest refused; the brief shows a held module; the seed carries a difference, named with both values. Issue 1126, ADR 0567 §3-4 Reviewed-by: rev-l2@shanks at 77b48a4f1affb6315cdfc801d8cb6dc75686253e
mesh-tools added 3 commits 2026-10-28 21:19:40 +00:00
Show in a proposal's brief what stays held as each node holds it today (issue 1126)
mesh/delivery-group group fix/1126-seed-held rejected: composed together: the checker's verdict at the members' heads (2b8e3078c117): the composition
mesh/delivery closed: a newer head of the same pull request
mesh/check failed: the composition: the manifest of mesh-delivery-assigner uses what mesh-controller at ba4d15657343d3116bd6657f85e53630a7dbabf2 (mesh…
06b13ec1cc
Author
Member

Delivery novox/mesh-sdk@77b48a4f1aff — ready since 2026-10-28T21:40:49Z

Group fix/1126-seed-held: novox/mesh-delivery@fc3883b0b6, novox/mesh-host@a143678fd8, novox/mesh-sdk@77b48a4f1a

Transitions

  • 2026-10-28 21:40 (new) → proposed (announced): novox/mesh-sdk#124's head announced
  • 2026-10-28 21:40 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@77b48a4f1aff` — **ready** since 2026-10-28T21:40:49Z **Group** `fix/1126-seed-held`: novox/mesh-delivery@fc3883b0b650, novox/mesh-host@a143678fd898, novox/mesh-sdk@77b48a4f1aff **Transitions** - 2026-10-28 21:40 (new) → proposed (announced): novox/mesh-sdk#124's head announced - 2026-10-28 21:40 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben added 2 commits 2026-10-28 21:40:45 +00:00
Name in the seed's brief the first differing field's value as it runs and as composed, so the operator sees what changes (issue 1126)
mesh/delivery-group group fix/1126-seed-held rejected: composed together: the checker's verdict at the members' heads (63905bd4b284): the composition
mesh/delivery merged: source.main moved to novox/mesh-sdk@f9afe328881f
mesh/check being carried to 77b48a4f1aff on f9afe328881f | from 53f26493697e
77b48a4f1a
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
Author
Member

Replaced by #125 (the same head, 77b48a4, on branch fix/1126-seed-sdk): with a mesh-sdk member, group fix/1126-seed-held's composition misfires on a stand-by controller build (ba4d156, pinning mesh-sdk 748c564), so mesh-sdk goes alone first and mesh-host #169 and mesh-delivery #107 follow. Issue 1126.

Replaced by #125 (the same head, 77b48a4, on branch fix/1126-seed-sdk): with a mesh-sdk member, group fix/1126-seed-held's composition misfires on a stand-by controller build (ba4d156, pinning mesh-sdk 748c564), so mesh-sdk goes alone first and mesh-host #169 and mesh-delivery #107 follow. Issue 1126.
mesh-tools closed this pull request 2026-10-28 21:55:04 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#124