A manifest the mesh refuses holds only its own module, never every node's composition (issue 774) #139

Merged
jschoubben merged 1 commits from fix/one-bad-item-holds-one-module into main 2026-10-30 18:30:53 +00:00
Member

At 19:13 on 2026-10-30 one refused bar item (power, mesh-catalog ca8d6f33) made every node-engine fail every module: frombus input returned the first parse refusal for the whole read. Now such a manifest is held on the node it is placed on (refuse, with why) and stands in elsewhere as its unjudged stub without items; Compose, Answer and PlansHeld follow the one rule. A bus that does not answer still refuses whole. Quick fix: skip the manifest; thorough (chosen): the rule input already applied to an unreadable build. Third of the kind today (user list, provisioner plans, node composition).

Wait for this pull request's mesh/check to pass before merging: today's #565 merged with its check pending and the composition never run, which let the bar item fault reach every machine.
Merge order: mesh-sdk first, then mesh-host and mesh-catalog (they pin mesh-sdk 754edfa).

Reviewed-by: rev-sweep@shanks at 754edfae69

At 19:13 on 2026-10-30 one refused bar item (power, mesh-catalog ca8d6f33) made every node-engine fail every module: frombus input returned the first parse refusal for the whole read. Now such a manifest is held on the node it is placed on (refuse, with why) and stands in elsewhere as its unjudged stub without items; Compose, Answer and PlansHeld follow the one rule. A bus that does not answer still refuses whole. Quick fix: skip the manifest; thorough (chosen): the rule input already applied to an unreadable build. Third of the kind today (user list, provisioner plans, node composition). Wait for this pull request's mesh/check to pass before merging: today's #565 merged with its check pending and the composition never run, which let the bar item fault reach every machine. Merge order: mesh-sdk first, then mesh-host and mesh-catalog (they pin mesh-sdk 754edfa). Reviewed-by: rev-sweep@shanks at 754edfae69244246faaabfd5072fdfab452ef9fe
mesh-tools added 1 commit 2026-10-30 18:30:25 +00:00
Hold only the module whose manifest the mesh refuses, so one bad item no longer fails every node's composition (issue 774)
mesh/delivery merged: source.main moved to novox/mesh-sdk@16932c93d672
mesh/delivery-group group fix/one-bad-item-holds-one-module merged: every member is merged
mesh/check checking 754edfae6924 on 16932c93d672 | novox/mesh-sdk#139 in group fix/one-bad-item-holds-one-module
754edfae69
On 2026-10-30 at 19:13 power's bar item (mesh-catalog ca8d6f33) was refused by ParseManifest, and frombus's input
returned that refusal for the whole read: every node-engine marked all its modules failed and no update could land.
The third of a kind that day, after the bus user list and the provisioner's plans (PlansHeld).

Quick fix: skip a manifest that does not parse in input's catalogue loop. Thorough fix: input follows the rule a build
that cannot be read already follows there (refuse + stub), so Compose, Answer and PlansHeld all hold the one module:
held with why on a node it is placed on, read for its offer alone (its unjudged stub, without items) elsewhere. A
manifest the bus does not answer for still ends the read (transient, waited out by the caller), and Input (refuse
unset, the check's whole composition) still refuses. Chose thorough: one place serves all three callers.
Author
Member

Delivery novox/mesh-sdk@754edfae6924 — merged since 2026-10-30T18:30:55Z

Source — source.main moved to novox/mesh-sdk@16932c93d6. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/one-bad-item-holds-one-module: novox/mesh-catalog@b4b22aac20, novox/mesh-host@4055e0094b, novox/mesh-sdk@754edfae69

Transitions

  • 2026-10-30 18:30 (new) → proposed (announced): novox/mesh-sdk#139's head announced
  • 2026-10-30 18:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 18:30 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@754edfae6924` — **merged** since 2026-10-30T18:30:55Z **Source** — source.main moved to novox/mesh-sdk@16932c93d672. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/one-bad-item-holds-one-module`: novox/mesh-catalog@b4b22aac2060, novox/mesh-host@4055e0094b48, novox/mesh-sdk@754edfae6924 **Transitions** - 2026-10-30 18:30 (new) → proposed (announced): novox/mesh-sdk#139's head announced - 2026-10-30 18:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 18:30 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 16932c93d6 into main 2026-10-30 18:30:53 +00:00
jschoubben deleted branch fix/one-bad-item-holds-one-module 2026-10-30 18:30:54 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#139