The resolver's own guards leave mesh-sdk; only the uplinks' cross-module check stays #179

2026-11-09T20:02:25Z

mesh-tools commented

2026-11-09 20:02:25 +00:00

Issue 1966. TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf failed on main for every mesh-sdk pull request (mesh-sdk #178's check): it expected the literal server=1.1.1.1 in mesh-catalog's dnsmasq manifest, which now takes its upstreams from settings. A test of one module's file belongs with that module: its guards move to mesh-catalog (fix/1966-resolver-test, modules/dnsmasq), and mesh-sdk keeps only the uplinks' resolv.conf check that spans networkmanager and systemd-networkd.

Quick fix: change the literal (minutes). Thorough fix (chosen): the module's own tests hold its file. Every old assertion is held now (listed in the review). Merge with or after the mesh-catalog pull request of the same branch.

Reviewed-by: mesh-code-reviewer@shanks at a330d7b0da

https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

Issue 1966. TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf failed on main for every mesh-sdk pull request (mesh-sdk #178's check): it expected the literal server=1.1.1.1 in mesh-catalog's dnsmasq manifest, which now takes its upstreams from settings. A test of one module's file belongs with that module: its guards move to mesh-catalog (fix/1966-resolver-test, modules/dnsmasq), and mesh-sdk keeps only the uplinks' resolv.conf check that spans networkmanager and systemd-networkd. Quick fix: change the literal (minutes). Thorough fix (chosen): the module's own tests hold its file. Every old assertion is held now (listed in the review). Merge with or after the mesh-catalog pull request of the same branch. Reviewed-by: mesh-code-reviewer@shanks at a330d7b0da161721a095e6999812420be8823a95 https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools added 1 commit 2026-11-09 20:02:26 +00:00

Hold the uplinks' resolver file here and the resolver's own configuration in its module (issue 1966)

mesh/check checking a330d7b0da16 on 4b9bac9c73a9 | novox/mesh-sdk#179 in group fix/1966-resolver-test

mesh/delivery merged: source.main moved to novox/mesh-sdk@4b9bac9c73a9

Details

mesh/delivery-group group fix/1966-resolver-test merged: every member is merged

Details

a330d7b0da

The literal server=1.1.1.1 broke on every pull request when the upstreams became settings; the dnsmasq configuration is checked in the module that owns it.

Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools commented

2026-11-09 20:02:31 +00:00

Delivery novox/mesh-sdk@a330d7b0da16 — merged since 2026-11-09T20:09:33Z

Source — source.main moved to novox/mesh-sdk@4b9bac9c73. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1966-resolver-test: novox/mesh-catalog@a7dc4534d7, novox/mesh-sdk@a330d7b0da

Transitions

2026-11-09 20:02 (new) → proposed (announced): novox/mesh-sdk#179's head announced
2026-11-09 20:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-09 20:09 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-sdk@a330d7b0da16` — **merged** since 2026-11-09T20:09:33Z **Source** — source.main moved to novox/mesh-sdk@4b9bac9c73a9. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1966-resolver-test`: novox/mesh-catalog@a7dc4534d73a, novox/mesh-sdk@a330d7b0da16 **Transitions** - 2026-11-09 20:02 (new) → proposed (announced): novox/mesh-sdk#179's head announced - 2026-11-09 20:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-09 20:09 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 4b9bac9c73 into main

2026-11-09 20:09:31 +00:00

mesh-tools deleted branch fix/1966-resolver-test

2026-11-09 20:09:31 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#179