Design lines: hq design/47-H1-answers-59 at 6b3356ba and b7d01fce (lead answer H-A-472, its seventh and eighth addenda).
Purpose
The tool runner creates its own _tools consumer from the spec a heard entry of the membership carries; the grants part composes none. So a heard entry must carry the consumer's whole spec.
Change
membership.HeardIssued gains Filters, AckWaitSeconds, MaxDeliver, MaxAckPending, DeliverPolicy and HasSpec, all omitempty; entries written before this change still decode (HasSpec false).
Tests
go/membership/membership_test.go: a heard entry with a spec round-trips whole; an old entry without one decodes with HasSpec false.
Reviewed-by: mesh-code-reviewer@shanks at ed9e5bd700
Pushed-by: lead-47@shanks
Design lines: hq `design/47-H1-answers-59` at 6b3356ba and b7d01fce (lead answer H-A-472, its seventh and eighth addenda).
## Purpose
The tool runner creates its own `_tools` consumer from the spec a heard entry of the membership carries; the grants part composes none. So a heard entry must carry the consumer's whole spec.
## Change
`membership.HeardIssued` gains `Filters`, `AckWaitSeconds`, `MaxDeliver`, `MaxAckPending`, `DeliverPolicy` and `HasSpec`, all `omitempty`; entries written before this change still decode (`HasSpec` false).
## Tests
`go/membership/membership_test.go`: a heard entry with a spec round-trips whole; an old entry without one decodes with `HasSpec` false.
Reviewed-by: mesh-code-reviewer@shanks at ed9e5bd700bda7869ca6250f5d9d93f8ca57c9f4
Pushed-by: lead-47@shanks
A part that creates a hearing consumer itself (the tool runner, for a module's
_tools twin) reads the filters, ack wait, max deliver, max ack pending and
deliver policy from the membership instead of computing them, so the grants
part stays the one composer of filters. The fields are omitted when unset: an
older grants part's membership still reads, and an older reader ignores them.
HasSpec says which an entry is, so a reader binds an older entry by name and
creates a newer one from its spec.
Builds: design 47 H2 H-A-472 (seventh addendum, eighth addendum)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Design lines: hq
design/47-H1-answers-59at 6b3356ba and b7d01fce (lead answer H-A-472, its seventh and eighth addenda).Purpose
The tool runner creates its own
_toolsconsumer from the spec a heard entry of the membership carries; the grants part composes none. So a heard entry must carry the consumer's whole spec.Change
membership.HeardIssuedgainsFilters,AckWaitSeconds,MaxDeliver,MaxAckPending,DeliverPolicyandHasSpec, allomitempty; entries written before this change still decode (HasSpecfalse).Tests
go/membership/membership_test.go: a heard entry with a spec round-trips whole; an old entry without one decodes withHasSpecfalse.Reviewed-by: mesh-code-reviewer@shanks at
ed9e5bd700Pushed-by: lead-47@shanks