Build steps: run every test step of a level and name every failure in the verdict (issue 1921) #87

2026-10-26T10:17:11Z

mesh-tools commented

2026-10-26 10:17:11 +00:00

Group fix/1921-every-failure-r (mesh-sdk, mesh-delivery, mesh-catalog), one Approve. Issue 1921: a check showed one failure per round, so a group's faults were found one try at a time. buildstep.RunAsk runs every test step of a level instead of returning at the first failing one (the level still fails, no later level runs, ADR 0484 clause 13 unchanged); delivery.Verdict gains Failures (every failed test with its first line, at most 50 and 'and N more'), decoded compatibly (older readers ignore it, older verdicts have none).

The fix was reviewed and tried on 2026-10-25 (reviewer-r6m at bc16740f) and never merged; this is the same patch on today's main (range-diff identical). Try try-1793008703311913390 passed.

Reviewed-by: review-1921r@shanks at 79649c3fa9

Group fix/1921-every-failure-r (mesh-sdk, mesh-delivery, mesh-catalog), one Approve. Issue 1921: a check showed one failure per round, so a group's faults were found one try at a time. buildstep.RunAsk runs every test step of a level instead of returning at the first failing one (the level still fails, no later level runs, ADR 0484 clause 13 unchanged); delivery.Verdict gains Failures (every failed test with its first line, at most 50 and 'and N more'), decoded compatibly (older readers ignore it, older verdicts have none). The fix was reviewed and tried on 2026-10-25 (reviewer-r6m at bc16740f) and never merged; this is the same patch on today's main (range-diff identical). Try try-1793008703311913390 passed. Reviewed-by: review-1921r@shanks at 79649c3fa9f41c5949636df7f5590126b1040a08

mesh-tools added 1 commit 2026-10-26 10:17:12 +00:00

Run every test step of a check's level after a failure, and let a verdict name every failed test (issue 1921)

mesh/delivery merged: source.main moved to novox/mesh-sdk@85fa8511c4b3

Details

mesh/delivery-group group fix/1921-every-failure-r merged: every member is merged

Details

mesh/check checking 79649c3fa9f4 on c3544b6a17a2 | novox/mesh-sdk#87 in group fix/1921-every-failure-r

79649c3fa9

A check ask stopped its level at the first test step that did not pass,
so the packages after the changed ones never ran and a check found one
fault per round. Every step now runs; the level still fails, and no
later level runs (ADR 0484 clause 13). The verdict gains Failures, every
failed test with its first line, at most MaxFailures and a count.

mesh-tools commented

2026-10-26 10:17:14 +00:00

Delivery novox/mesh-sdk@79649c3fa9f4 — merged since 2026-10-26T10:18:06Z

Source — source.main moved to novox/mesh-sdk@85fa8511c4. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1921-every-failure-r: novox/mesh-catalog@15a5fe09b6, novox/mesh-delivery@04a56b7aff, novox/mesh-sdk@79649c3fa9

Transitions

2026-10-26 10:17 (new) → proposed (announced): novox/mesh-sdk#87's head announced
2026-10-26 10:17 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 10:18 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-sdk@79649c3fa9f4` — **merged** since 2026-10-26T10:18:06Z **Source** — source.main moved to novox/mesh-sdk@85fa8511c4b3. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1921-every-failure-r`: novox/mesh-catalog@15a5fe09b62e, novox/mesh-delivery@04a56b7aff66, novox/mesh-sdk@79649c3fa9f4 **Transitions** - 2026-10-26 10:17 (new) → proposed (announced): novox/mesh-sdk#87's head announced - 2026-10-26 10:17 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 10:18 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-10-26 10:17:20 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools commented

2026-10-26 10:17:25 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit 85fa8511c4 into main

2026-10-26 10:18:05 +00:00

mesh-tools deleted branch fix/1921-every-failure-r

2026-10-26 10:18:08 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#87