jschoubben
3218da4ee4
The unit test functions fall from 587 to 476 (the budget is 500): the cases of each of twenty test files in declaration and provider/harness become subtests of one test named for the file, under their own names, their bodies unchanged. Integration tests stay at 30 (budget 50). Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig
56 lines
2.0 KiB
Go
56 lines
2.0 KiB
Go
package declaration
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// novox/hq ADR 0177: a unit is in the system manager or an account's own; a user-scoped one names
|
|
// the account, a system one may not, and any other word is refused.
|
|
func testAUserScopedUnitNamesItsAccountAndASystemOneMayNot(t *testing.T) {
|
|
cases := []struct{ scope, user, wants string }{
|
|
{"user", "ops", ""},
|
|
{"", "", ""},
|
|
{"system", "", ""},
|
|
{"user", "", "names the account"},
|
|
{"", "ops", "names no user"},
|
|
{"session", "ops", "scope \"session\""},
|
|
}
|
|
for _, c := range cases {
|
|
s := &Service{ID: "m.u", Type: TypeService, Unit: "u.service", State: "running", Scope: c.scope, User: c.user}
|
|
problems := s.validate("m.u", false)
|
|
got := strings.Join(problems, "; ")
|
|
if c.wants == "" && len(problems) != 0 {
|
|
t.Fatalf("scope %q user %q refused: %s", c.scope, c.user, got)
|
|
}
|
|
if c.wants != "" && !strings.Contains(got, c.wants) {
|
|
t.Fatalf("scope %q user %q: wanted a refusal saying %q, got %q", c.scope, c.user, c.wants, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// novox/hq ADR 0177: lingering is a field of the account, absent meaning nothing asserted.
|
|
func testAnAccountMayBeDeclaredToLinger(t *testing.T) {
|
|
d, err := Parse([]byte(`{"declaration":1,"resources":[{"id":"m.login","type":"user","name":"ops","linger":true}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
u, ok := d.Resources[0].(*User)
|
|
if !ok || u.Linger == nil || !*u.Linger {
|
|
t.Fatalf("linger not read: %+v", d.Resources[0])
|
|
}
|
|
d, err = Parse([]byte(`{"declaration":1,"resources":[{"id":"m.login","type":"user","name":"ops"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if u := d.Resources[0].(*User); u.Linger != nil {
|
|
t.Fatal("an account that said nothing about lingering asserts it")
|
|
}
|
|
}
|
|
|
|
// TestUserscope holds this file's cases, each a subtest of its own name (mesh-sdk's test budget: at most 500 unit tests).
|
|
func TestUserscope(t *testing.T) {
|
|
t.Run("AUserScopedUnitNamesItsAccountAndASystemOneMayNot", testAUserScopedUnitNamesItsAccountAndASystemOneMayNot)
|
|
t.Run("AnAccountMayBeDeclaredToLinger", testAnAccountMayBeDeclaredToLinger)
|
|
}
|