52 lines
2.2 KiB
Go
52 lines
2.2 KiB
Go
package catalogue
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// 1943/AC4: the delivery seat keeps the merge's verbs and no longer offers times, what-if, release, stop or
|
|
// retire-history: each is a row with no input, optional so the holder of before and the holder of release 6 both hold
|
|
// the seat, refusing it by name; mark-ready, served by nobody since issue 1022, is gone.
|
|
func TestTheDeliverySeatHasNoPlanVerbs(t *testing.T) {
|
|
seat, ok := SeatNamed(DeliverySeat)
|
|
if !ok {
|
|
t.Fatal("the delivery seat is not in the set")
|
|
}
|
|
rows := map[string]Verb{}
|
|
for _, v := range seat.Serves {
|
|
rows[v.Name] = v
|
|
}
|
|
for _, name := range []string{"times", "what-if", "release", "stop", "retire-history"} {
|
|
v, ok := rows[name]
|
|
replacement := strings.TrimPrefix(v.Description, "Removed in R6 (ADR 0539): refused by name, naming its replacement: ")
|
|
if !ok || replacement == "" || replacement == v.Description {
|
|
t.Errorf("%s: in the table %v, replacement %q", name, ok, replacement)
|
|
continue
|
|
}
|
|
if !strings.HasPrefix(v.Description, "Removed in R6 (ADR 0539): refused by name") || !strings.Contains(v.Description, replacement) || !v.Optional {
|
|
t.Errorf("%s = %q (optional %v), want an optional row refusing it by name", name, v.Description, v.Optional)
|
|
}
|
|
if props, _ := v.Input["properties"].(map[string]any); len(props) > 0 {
|
|
t.Errorf("%s still takes %v", name, props)
|
|
}
|
|
}
|
|
if _, ok := rows["mark-ready"]; ok {
|
|
t.Errorf("mark-ready is still promised")
|
|
}
|
|
for _, kept := range []string{"deliveries", "show", "groups", "checks", "table", "recheck", "close", "stalled", "settle"} {
|
|
if v, ok := rows[kept]; !ok || strings.HasPrefix(v.Description, "Removed") {
|
|
t.Errorf("%s is not kept (ADR 0539 clause 17)", kept)
|
|
}
|
|
}
|
|
gate := Manifest{Module: "mesh-delivery", Claims: []Claim{{Name: DeliverySeat, Scope: ScopeMesh,
|
|
Serves: []string{"deliveries", "show", "groups", "checks", "table", "stalled", "recheck", "close"}}}}
|
|
if err := CanHold(gate, seat); err != nil {
|
|
t.Errorf("the gate of release 6 cannot hold the seat: %v", err)
|
|
}
|
|
gate.Claims[0].Serves = append(gate.Claims[0].Serves, "times", "what-if", "release", "stop", "retire-history")
|
|
if err := CanHold(gate, seat); err != nil {
|
|
t.Errorf("the gate of release 5 cannot hold the seat: %v", err)
|
|
}
|
|
}
|