jschoubben
3218da4ee4
The unit test functions fall from 587 to 476 (the budget is 500): the cases of each of twenty test files in declaration and provider/harness become subtests of one test named for the file, under their own names, their bodies unchanged. Integration tests stay at 30 (budget 50). Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig
44 lines
1.8 KiB
Go
44 lines
1.8 KiB
Go
package declaration
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Defends novox/hq ADR 0349 §4 (issue 668): the declaration names the account the provisioner's client runs as,
|
|
// the only one whose write of a filled file the node-engine accepts. Read here before any controller sends it.
|
|
|
|
func testTheDeclarationNamesTheProvisionersAccount(t *testing.T) {
|
|
d, err := Parse([]byte(`{"declaration":1,"provisioner_account":"mesh-node-provisioner","filled_files":["/etc/a"],
|
|
"resources":[{"id":"a","type":"file","path":"/etc/a","content":"a","owner-at-runtime":"owned"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if d.Provisioner != "mesh-node-provisioner" {
|
|
t.Errorf("the provisioner's account read as %q", d.Provisioner)
|
|
}
|
|
d, err = Parse([]byte(`{"declaration":1,"resources":[{"id":"a","type":"file","path":"/etc/a","content":"a"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if d.Provisioner != "" {
|
|
t.Errorf("a declaration naming no account names %q", d.Provisioner)
|
|
}
|
|
}
|
|
|
|
func testAProvisionersAccountThatIsNoAccountIsRefused(t *testing.T) {
|
|
for name, account := range map[string]string{"root": "root", "not a name": "a b", "a path": "../x"} {
|
|
_, err := Parse([]byte(`{"declaration":1,"provisioner_account":"` + account + `",
|
|
"resources":[{"id":"a","type":"file","path":"/etc/a","content":"a"}]}`))
|
|
if err == nil || !strings.Contains(err.Error(), "provisioner_account") {
|
|
t.Errorf("%s: want a refusal naming provisioner_account, got %v", name, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestProvisioner holds this file's cases, each a subtest of its own name (mesh-sdk's test budget: at most 500 unit tests).
|
|
func TestProvisioner(t *testing.T) {
|
|
t.Run("TheDeclarationNamesTheProvisionersAccount", testTheDeclarationNamesTheProvisionersAccount)
|
|
t.Run("AProvisionersAccountThatIsNoAccountIsRefused", testAProvisionersAccountThatIsNoAccountIsRefused)
|
|
}
|