jschoubben
68aaf235d4
Issue 1585, S19: the strict parser, every manifest problem function and the judge's tables (192 declarations, about 5,200 lines) and their 244 tests leave; composition keeps its own refusals and the helpers it uses. The catalogue's tests decode the manifests they build. ParseManifest, ParseManifestWith, ParseManifestForInputs, CatalogueProblems and the rest are gone; mesh-delivery-indexer/judge holds them. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
50 lines
2.0 KiB
Go
50 lines
2.0 KiB
Go
package catalogue
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
// Naming the image directly is the way out, and must stay accepted.
|
|
func TestAnArtifactStoreThatNamesItsImageIsAccepted(t *testing.T) {
|
|
_, err := decodeForTest([]byte(`{"module":"registry","version":"1",` +
|
|
`"provides":[{"name":"artifact-store","scope":"mesh"}],` +
|
|
`"resources":[{"id":"store","type":"container","name":"mesh-registry",` +
|
|
`"image":"registry@sha256:` +
|
|
`266f282fabd7cd3df053ee7c658c77b42380d1a2f0d8e5a1c0d7a6d5b5c4a3b2",` +
|
|
`"ports":["5000:5000"]}]}`))
|
|
if err != nil {
|
|
t.Fatalf("the one way an artifact store can be delivered was refused: %v", err)
|
|
}
|
|
}
|
|
|
|
// And an ordinary module still builds whatever it likes.
|
|
func TestAModuleThatDoesNotProvideTheStoreStillBuilds(t *testing.T) {
|
|
_, err := decodeForTest([]byte(`{"module":"forge","version":"1",` +
|
|
`"build":{"artifacts":[{"name":"forge","kind":"upstream","from":"gitea/gitea:1.22"}]},` +
|
|
`"resources":[{"id":"run","type":"container","name":"forge","artifact":"forge"}]}`))
|
|
if err != nil {
|
|
t.Fatalf("an ordinary module was caught by a rule about the artifact store: %v", err)
|
|
}
|
|
}
|
|
|
|
// A mapping that names an address still names the port, and the machine side is still the middle.
|
|
//
|
|
// The foundation bundle writes "127.0.0.1:5432:5432" today, so the shape is not hypothetical.
|
|
// Found in review: the first cut split on the first colon, read "127.0.0.1" as the machine port,
|
|
// failed to parse it, and silently skipped the mapping — which put the filter back on the
|
|
// declared port, the exact fault MachineSide was written to end.
|
|
func TestAnAddressedMappingStillNamesThePort(t *testing.T) {
|
|
m := Manifest{Module: "store", Resources: []map[string]any{
|
|
{"type": "container", "id": "server", "ports": []any{"127.0.0.1:8080:80"}},
|
|
}}
|
|
for _, named := range []int{8080, 80} {
|
|
at, mayAssign := m.MachineSide(named)
|
|
if mayAssign {
|
|
t.Fatalf("%d was reassigned though the manifest published it explicitly", named)
|
|
}
|
|
if at != 8080 {
|
|
t.Fatalf("naming %d gave %d; the machine side of 127.0.0.1:8080:80 is 8080", named, at)
|
|
}
|
|
}
|
|
}
|