jschoubben
06fe1ee8b3
A package or a non-Go bundle may name its build source; a Go program, an archive, an image and an upstream artifact refuse the word by name, as do a path leaving the module's directory, the whole directory and a pattern.
47 lines
2.8 KiB
Go
47 lines
2.8 KiB
Go
package catalogue
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// An artifact names the paths it is built from with `paths` (novox/hq ADR 0499 clause 1): a package, or a bundle in a
|
|
// language other than Go, may; a Go program's artifact, an archive, an image and an upstream artifact may not, and the
|
|
// refusal names the artifact and its kind. Each path stays inside the module's directory: no `..`, no absolute path,
|
|
// no pattern.
|
|
func TestAnArtifactNamesThePathsItIsBuiltFrom(t *testing.T) {
|
|
m, err := ParseManifest([]byte(`{"module":"mesh-sdk","version":"1","slug":"sdk","build":{"artifacts":[
|
|
{"name":"lib","kind":"package","language":"typescript",
|
|
"paths":["src","test","package.json","package-lock.json","tsconfig.json"]}]},"resources":[]}`))
|
|
if err != nil {
|
|
t.Fatalf("a package naming its paths was refused: %v", err)
|
|
}
|
|
if got := strings.Join(m.Build.Artifacts[0].Paths, ","); got != "src,test,package.json,package-lock.json,tsconfig.json" {
|
|
t.Fatalf("the paths were not kept as written: %q", got)
|
|
}
|
|
if _, err := ParseManifest([]byte(`{"module":"a","version":"1","build":{"artifacts":[
|
|
{"name":"tools","kind":"bundle","language":"typescript","entrypoints":["index.js"],"loads":["index.js"],"paths":["src","package.json"]}]}}`)); err != nil {
|
|
t.Fatalf("a TypeScript bundle naming its paths was refused: %v", err)
|
|
}
|
|
|
|
for _, c := range []struct{ artifact, says string }{
|
|
{`{"name":"x","kind":"bundle","language":"go","system":"linux-amd64","paths":["cmd"]}`, `"x" is a Go program`},
|
|
{`{"name":"x","kind":"archive","from":"files","paths":["files"]}`, `"x" is a "archive"`},
|
|
{`{"name":"x","kind":"image","from":"Dockerfile","paths":["src"]}`, `"x" is a "image"`},
|
|
{`{"name":"x","kind":"upstream","from":"nats:2.10","paths":["src"]}`, `"x" is a "upstream"`},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["../other"]}`, "leaves the module's directory"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["src/../../x"]}`, "leaves the module's directory"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["/etc"]}`, "leaves the module's directory"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["src/*.ts"]}`, "is a pattern"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["src/[ab]"]}`, "is a pattern"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":[""]}`, "names an empty path"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":["."]}`, "names the module's whole directory"},
|
|
{`{"name":"x","kind":"package","language":"typescript","paths":[]}`, "names no path"},
|
|
} {
|
|
_, err := ParseManifest([]byte(`{"module":"a","version":"1","build":{"artifacts":[` + c.artifact + `]}}`))
|
|
if err == nil || !strings.Contains(err.Error(), c.says) {
|
|
t.Errorf("%s: %v, wanted a refusal saying %q", c.artifact, err, c.says)
|
|
}
|
|
}
|
|
}
|