Remove the TypeScript runtime code that called the old catalog module's tools; a test finds no file naming one (ADR 0604 section 4, issue 774)
This commit is contained in:
@@ -1046,7 +1046,7 @@ func (c *Conn) AskAs(module, key string, body any) (Answered, error) {
|
||||
|
||||
// EventsStream is where every module's events land, and ConsumerOf the durable consumer the
|
||||
// mesh makes for a module on a machine: the same names the module's own runtime bound
|
||||
// (node-tools/src/broker-nats.ts), so moving the module into the node's runtime neither loses an
|
||||
// (the retired TypeScript runtime's broker-nats.ts), so moving the module into the node's runtime neither loses an
|
||||
// event nor sees one twice.
|
||||
const EventsStream = "EVENTS"
|
||||
|
||||
|
||||
@@ -110,6 +110,13 @@ func TestTheRepositoryHoldsNoCheckScriptAndNodeToolsIsItsOnlyModule(t *testing.T
|
||||
if !d.IsDir() && d.Name() == "module.json" {
|
||||
found = append(found, filepath.ToSlash(p))
|
||||
}
|
||||
// ADR 0604 section 4: the TypeScript that called the old catalog module's tools is gone, and nothing
|
||||
// under node-tools names one (the needle is built so this file does not name it either).
|
||||
if !d.IsDir() && strings.Contains(filepath.ToSlash(p), "/node-tools/") {
|
||||
if body, rerr := os.ReadFile(p); rerr == nil && strings.Contains(string(body), "catalog"+"_modules") {
|
||||
t.Errorf("%s names a catalog tool of the retired module", p)
|
||||
}
|
||||
}
|
||||
return nil
|
||||
})
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user