From ea516ece5aa8de1bc22602407a06cfb7db044b4a Mon Sep 17 00:00:00 2001 From: jochen Date: Tue, 3 Nov 2026 12:01:58 +0100 Subject: [PATCH] node-tools says it is the tool runner (tool-runner), so mesh-sdk and its readers never know it by its name; pinned at mesh-sdk a973bfa (issue 774, the operator 2026-11-03) --- node-tools/go.mod | 2 +- node-tools/go.sum | 6 ++++-- node-tools/internal/provide/provide_test.go | 9 +++++++-- node-tools/module.json | 1 + 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/node-tools/go.mod b/node-tools/go.mod index c355438..c5fe847 100644 --- a/node-tools/go.mod +++ b/node-tools/go.mod @@ -8,7 +8,7 @@ require ( ) require ( - git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103142843-f8bd12e4b7b1 + git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103105230-a973bfaf42b2 github.com/antithesishq/antithesis-sdk-go v0.7.0-default-no-op // indirect github.com/google/go-tpm v0.9.8 // indirect github.com/klauspost/compress v1.20.0 // indirect diff --git a/node-tools/go.sum b/node-tools/go.sum index 0111c9e..ad64e5d 100644 --- a/node-tools/go.sum +++ b/node-tools/go.sum @@ -1,5 +1,7 @@ -git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103142843-f8bd12e4b7b1 h1:T66tg9T/1hHg6KN/bDScHPT41IHkxLAGGO8VJiAOlb8= -git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103142843-f8bd12e4b7b1/go.mod h1:ouERNpZizzwZ0HLEtAypsY9FR20FyUgUYRni6J7kVCY= +git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261102191058-f02f142af128 h1:aI1DhZAuqVBXbybSqhLNOGX5rUOrn9T0cHNCDUQF7IQ= +git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261102191058-f02f142af128/go.mod h1:ouERNpZizzwZ0HLEtAypsY9FR20FyUgUYRni6J7kVCY= +git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103105230-a973bfaf42b2 h1:CMNEBKlWI36rQEG5lhFRKoICquvYP4hBD7h/jCVFIcc= +git.novox.be/novox/mesh-sdk/go v0.1.14-0.20261103105230-a973bfaf42b2/go.mod h1:ouERNpZizzwZ0HLEtAypsY9FR20FyUgUYRni6J7kVCY= github.com/antithesishq/antithesis-sdk-go v0.7.0-default-no-op h1:Z/MZK75wC/NSrkgqeNIa7jexam9uWzhLmFTSCPI/kn0= github.com/antithesishq/antithesis-sdk-go v0.7.0-default-no-op/go.mod h1:FQyySiasQQM8735Ddel3MRojmy4dA1IqCeyJ5jmPMbI= github.com/google/go-tpm v0.9.8 h1:slArAR9Ft+1ybZu0lBwpSmpwhRXaa85hWtMinMyRAWo= diff --git a/node-tools/internal/provide/provide_test.go b/node-tools/internal/provide/provide_test.go index a6aa784..47957c9 100644 --- a/node-tools/internal/provide/provide_test.go +++ b/node-tools/internal/provide/provide_test.go @@ -206,7 +206,12 @@ func TestTheManifestNamesNothingOfTheController(t *testing.T) { if err != nil { t.Fatal(err) } - if refused := catalogue.ManifestRefusals(map[string]catalogue.Manifest{Module: m}); len(refused) != 0 { - t.Errorf("the controller-dependence check refuses node-tools' manifest: %v", refused) + // Read as text, as mesh-catalog's controllerdeps check reads its own: mesh-sdk names no module (issue 774), and the + // manifest says it is the tool runner rather than being known by its name. + if strings.Contains(string(raw), "mesh-controller") { + t.Error("node-tools' manifest names the ended controller") + } + if !catalogue.IsToolRunner(m) { + t.Error("node-tools' manifest does not say it is the tool runner (\"tool-runner\": true)") } } diff --git a/node-tools/module.json b/node-tools/module.json index e6cb6db..535300f 100644 --- a/node-tools/module.json +++ b/node-tools/module.json @@ -2,6 +2,7 @@ "module": "node-tools", "version": "1", "slug": "node-tools", + "tool-runner": true, "invokes": [ "*" ],