Bring node-tools' lock back in step with package.json, and fail the check when it falls behind (issue 624) #33

Merged
mesh-admin merged 1 commits from fix/624-node-tools-lock-in-step into main 2026-10-13 13:19:41 +00:00
Contributor

Fixes issue 624 (the lab module's lab_run fails at setup).

What

  • node-tools/package-lock.json regenerated with npm install --package-lock-only (npm 10.9.2): root now records @novox/mesh-sdk ^0.1.6 (resolved 0.1.14) and the development dependencies esbuild, mongodb, mssql and pg.
  • New package node-tools/internal/npmlock: an offline Go check (no node needed, so it runs in the Go toolchain's mesh/repo-check) that names every way the lock's root entry differs from package.json, and every declared dependency the lock resolved no package for. TestNodeToolsLockIsInStepWithItsPackage runs it on node-tools itself; merge-check.sh already runs every package from go list ./....

Why

Lab run run-2026-10-13T13-00-17-386Z on shanks (all repos on main) installed and built mesh-sdk, then stopped in mesh-tools' node-tools: npm ci refused with EUSAGE, "lock file's @novox/mesh-sdk@0.1.1 does not satisfy @novox/mesh-sdk@0.1.14" and esbuild/mongodb/mssql/pg missing. The lock root still said ^0.1.0 and had none of the dev dependencies: package.json changed (issue 212's SDK range, issue 385's pg/mongodb/mssql) without the lock. The image build copies only package.json and runs npm install, so nothing that reads the lock ran until the lab did.

How it was tested

  • Reproduced on g14 in a fresh clone of main: npm ci --dry-run in node-tools gives the same EUSAGE and missing list as the lab log.
  • With the new lock: npm ci (108 packages) and npm run build (tsc) pass in node-tools, which is exactly the lab's install step for mesh-tools.
  • go test ./internal/npmlock: fails on main's lock (lists the SDK range and the four missing dev dependencies), passes with the fix; unit tests cover a lock behind its package, a lock in step, and lockfileVersion 1.
  • gofmt and go vet ./... clean. mesh-lab's and mesh-sdk's locks were checked with npm ci --dry-run and are in step.

The lab bed itself (genesis-keeps-its-bus) is still to be rerun on shanks with this branch as the mesh-tools ref.

Fixes issue 624 (the lab module's lab_run fails at setup). ## What - `node-tools/package-lock.json` regenerated with `npm install --package-lock-only` (npm 10.9.2): root now records `@novox/mesh-sdk ^0.1.6` (resolved 0.1.14) and the development dependencies esbuild, mongodb, mssql and pg. - New package `node-tools/internal/npmlock`: an offline Go check (no node needed, so it runs in the Go toolchain's `mesh/repo-check`) that names every way the lock's root entry differs from package.json, and every declared dependency the lock resolved no package for. `TestNodeToolsLockIsInStepWithItsPackage` runs it on node-tools itself; merge-check.sh already runs every package from `go list ./...`. ## Why Lab run run-2026-10-13T13-00-17-386Z on shanks (all repos on main) installed and built mesh-sdk, then stopped in mesh-tools' node-tools: `npm ci` refused with EUSAGE, "lock file's @novox/mesh-sdk@0.1.1 does not satisfy @novox/mesh-sdk@0.1.14" and esbuild/mongodb/mssql/pg missing. The lock root still said `^0.1.0` and had none of the dev dependencies: package.json changed (issue 212's SDK range, issue 385's pg/mongodb/mssql) without the lock. The image build copies only package.json and runs `npm install`, so nothing that reads the lock ran until the lab did. ## How it was tested - Reproduced on g14 in a fresh clone of main: `npm ci --dry-run` in node-tools gives the same EUSAGE and missing list as the lab log. - With the new lock: `npm ci` (108 packages) and `npm run build` (tsc) pass in node-tools, which is exactly the lab's install step for mesh-tools. - `go test ./internal/npmlock`: fails on main's lock (lists the SDK range and the four missing dev dependencies), passes with the fix; unit tests cover a lock behind its package, a lock in step, and lockfileVersion 1. - gofmt and `go vet ./...` clean. mesh-lab's and mesh-sdk's locks were checked with `npm ci --dry-run` and are in step. The lab bed itself (genesis-keeps-its-bus) is still to be rerun on shanks with this branch as the mesh-tools ref.
mesh-admin added 1 commit 2026-10-13 13:12:23 +00:00
Bring node-tools' lock back in step with package.json, and fail the check when it falls behind (hq issue 624)
mesh/merge-gate head 52e275ad2f3a merged into trunk 954e1a53eef9 — pass, with a note: builds mesh-tools (+39 dependent(s)) → ace, g14, novox, shanks; no bu…
mesh/repo-check head 52e275ad2f3a merged into trunk 954e1a53eef9 — pass: its merge-check.sh passed
mesh/delivery delivered
52e275ad2f
The lab installs node-tools with npm ci, which refuses a lock that no longer
describes package.json; the SDK's range and the toolchain's development
dependencies had moved in package.json alone, so every lab run stopped at
setup. The image's build runs npm install and never read the lock, so nothing
noticed.
Author
Contributor

Delivery novox/mesh-tools@52e275ad2f3a — delivered since 2026-10-13T13:42:02Z

Delivery plan — builds mesh-tools (+39 dependent(s)) → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person

  • tier 0: mesh-tools
  • tier 1: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh
  • ace: receives baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh; waits for a person: mssql, nftables
  • g14: receives netcheck, zsh; waits for a person: nftables
  • novox: receives gitea, mesh-catalog, mesh-vault, netcheck, nextcloud, umami, zsh; waits for a person: mailu, minio, mongodb, mssql, nftables
  • shanks: receives lab, netcheck, zsh; waits for a person: nftables
  • baserow keeps data (ADR 0233): what it holds is backed up before it moves
  • bazarr keeps data (ADR 0233): what it holds is backed up before it moves
  • bookshelf keeps data (ADR 0233): what it holds is backed up before it moves
  • gitea provides npm-package-registry, git: its consumers are sent again after it
  • gitea keeps data (ADR 0233): what it holds is backed up before it moves
  • grafana keeps data (ADR 0233): what it holds is backed up before it moves
  • home-assistant keeps data (ADR 0233): what it holds is backed up before it moves
  • icecast keeps data (ADR 0233): what it holds is backed up before it moves
  • influxdb provides influxdb-api: its consumers are sent again after it
  • influxdb keeps data (ADR 0233): what it holds is backed up before it moves
  • jackett provides jackett-api: its consumers are sent again after it
  • jackett keeps data (ADR 0233): what it holds is backed up before it moves
  • kometa keeps data (ADR 0233): what it holds is backed up before it moves
  • lab keeps data (ADR 0233): what it holds is backed up before it moves
  • lidarr provides lidarr-api: its consumers are sent again after it
  • lidarr keeps data (ADR 0233): what it holds is backed up before it moves
  • mailu waits for a person: its policy records (module)
  • mailu provides smtp: its consumers are sent again after it
  • mailu keeps data (ADR 0233): what it holds is backed up before it moves
  • mesh-vault provides secret: its consumers are sent again after it
  • mesh-vault keeps data (ADR 0233): what it holds is backed up before it moves
  • minio waits for a person: its policy records (module)
  • minio provides s3-bucket: its consumers are sent again after it
  • minio keeps data (ADR 0233): what it holds is backed up before it moves
  • mongodb waits for a person: its policy records (module)
  • mongodb provides mongodb-database: its consumers are sent again after it
  • mongodb keeps data (ADR 0233): what it holds is backed up before it moves
  • mosquitto provides mqtt-topic: its consumers are sent again after it
  • mosquitto keeps data (ADR 0233): what it holds is backed up before it moves
  • mssql waits for a person: its policy records (module)
  • mssql provides mssql-database: its consumers are sent again after it
  • mssql keeps data (ADR 0233): what it holds is backed up before it moves
  • nextcloud keeps data (ADR 0233): what it holds is backed up before it moves
  • nftables waits for a person: its policy records (module)
  • nodered keeps data (ADR 0233): what it holds is backed up before it moves
  • ombi keeps data (ADR 0233): what it holds is backed up before it moves
  • radarr provides radarr-api: its consumers are sent again after it
  • radarr keeps data (ADR 0233): what it holds is backed up before it moves
  • redis provides redis-cache: its consumers are sent again after it
  • redis keeps data (ADR 0233): what it holds is backed up before it moves
  • searxng keeps data (ADR 0233): what it holds is backed up before it moves
  • sonarr provides sonarr-api: its consumers are sent again after it
  • sonarr keeps data (ADR 0233): what it holds is backed up before it moves
  • tautulli keeps data (ADR 0233): what it holds is backed up before it moves
  • umami provides analytics: its consumers are sent again after it
  • umami keeps data (ADR 0233): what it holds is backed up before it moves
  • unifi keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, lab, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh is judged on its first machine

Machines

  • mesh-tools on every machine running it: sent
  • audit-logger on every machine running it: sent
  • baserow on ace: passed — healthy 1 times over 1m50s
  • bazarr on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • bookshelf on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • confluence on every machine running it: sent
  • gitlab on every machine running it: sent
  • grafana on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • home-assistant on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • icecast on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • influxdb on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • jackett on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • jira on every machine running it: sent
  • kometa on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • letta on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • lidarr on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • mosquitto on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • netcheck on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • nodered on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • ombi on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • openai-consumer on every machine running it: sent
  • radarr on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • redis on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • route-adapter on every machine running it: sent
  • searxng on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • sonarr on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • tautulli on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • unifi on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • zsh on ace: passed — judged with baserow: healthy 1 times over 1m50s
  • gitea on novox: passed — healthy 1 times over 40s
  • mesh-catalog on novox: passed — judged with gitea: healthy 1 times over 40s
  • mesh-vault on novox: passed — judged with gitea: healthy 1 times over 40s
  • nextcloud on novox: passed — judged with gitea: healthy 1 times over 40s
  • umami on novox: passed — judged with gitea: healthy 1 times over 40s
  • lab on shanks: passed — healthy 1 times over 33s
  • gitea on the rest running it: sent
  • lab on the rest running it: sent
  • mesh-catalog on the rest running it: sent
  • mesh-vault on the rest running it: sent
  • nextcloud on the rest running it: sent
  • umami on the rest running it: sent
  • baserow on the rest running it: sent
  • bazarr on the rest running it: sent
  • bookshelf on the rest running it: sent
  • grafana on the rest running it: sent
  • home-assistant on the rest running it: sent
  • icecast on the rest running it: sent
  • influxdb on the rest running it: sent
  • jackett on the rest running it: sent
  • kometa on the rest running it: sent
  • letta on the rest running it: sent
  • lidarr on the rest running it: sent
  • mosquitto on the rest running it: sent
  • netcheck on the rest running it: sent
  • nodered on the rest running it: sent
  • ombi on the rest running it: sent
  • radarr on the rest running it: sent
  • redis on the rest running it: sent
  • searxng on the rest running it: sent
  • sonarr on the rest running it: sent
  • tautulli on the rest running it: sent
  • unifi on the rest running it: sent
  • zsh on the rest running it: sent

Transitions

  • 2026-10-13 13:12 (new) → proposed (announced): novox/mesh-tools#33's head announced
  • 2026-10-13 13:14 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 13:14 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 13:26 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 13:26 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-13 13:42 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-tools@52e275ad2f3a` — **delivered** since 2026-10-13T13:42:02Z **Delivery plan** — builds mesh-tools (+39 dependent(s)) → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person - tier 0: mesh-tools - tier 1: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh - ace: receives baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh; waits for a person: mssql, nftables - g14: receives netcheck, zsh; waits for a person: nftables - novox: receives gitea, mesh-catalog, mesh-vault, netcheck, nextcloud, umami, zsh; waits for a person: mailu, minio, mongodb, mssql, nftables - shanks: receives lab, netcheck, zsh; waits for a person: nftables - baserow keeps data (ADR 0233): what it holds is backed up before it moves - bazarr keeps data (ADR 0233): what it holds is backed up before it moves - bookshelf keeps data (ADR 0233): what it holds is backed up before it moves - gitea provides npm-package-registry, git: its consumers are sent again after it - gitea keeps data (ADR 0233): what it holds is backed up before it moves - grafana keeps data (ADR 0233): what it holds is backed up before it moves - home-assistant keeps data (ADR 0233): what it holds is backed up before it moves - icecast keeps data (ADR 0233): what it holds is backed up before it moves - influxdb provides influxdb-api: its consumers are sent again after it - influxdb keeps data (ADR 0233): what it holds is backed up before it moves - jackett provides jackett-api: its consumers are sent again after it - jackett keeps data (ADR 0233): what it holds is backed up before it moves - kometa keeps data (ADR 0233): what it holds is backed up before it moves - lab keeps data (ADR 0233): what it holds is backed up before it moves - lidarr provides lidarr-api: its consumers are sent again after it - lidarr keeps data (ADR 0233): what it holds is backed up before it moves - mailu waits for a person: its policy records (module) - mailu provides smtp: its consumers are sent again after it - mailu keeps data (ADR 0233): what it holds is backed up before it moves - mesh-vault provides secret: its consumers are sent again after it - mesh-vault keeps data (ADR 0233): what it holds is backed up before it moves - minio waits for a person: its policy records (module) - minio provides s3-bucket: its consumers are sent again after it - minio keeps data (ADR 0233): what it holds is backed up before it moves - mongodb waits for a person: its policy records (module) - mongodb provides mongodb-database: its consumers are sent again after it - mongodb keeps data (ADR 0233): what it holds is backed up before it moves - mosquitto provides mqtt-topic: its consumers are sent again after it - mosquitto keeps data (ADR 0233): what it holds is backed up before it moves - mssql waits for a person: its policy records (module) - mssql provides mssql-database: its consumers are sent again after it - mssql keeps data (ADR 0233): what it holds is backed up before it moves - nextcloud keeps data (ADR 0233): what it holds is backed up before it moves - nftables waits for a person: its policy records (module) - nodered keeps data (ADR 0233): what it holds is backed up before it moves - ombi keeps data (ADR 0233): what it holds is backed up before it moves - radarr provides radarr-api: its consumers are sent again after it - radarr keeps data (ADR 0233): what it holds is backed up before it moves - redis provides redis-cache: its consumers are sent again after it - redis keeps data (ADR 0233): what it holds is backed up before it moves - searxng keeps data (ADR 0233): what it holds is backed up before it moves - sonarr provides sonarr-api: its consumers are sent again after it - sonarr keeps data (ADR 0233): what it holds is backed up before it moves - tautulli keeps data (ADR 0233): what it holds is backed up before it moves - umami provides analytics: its consumers are sent again after it - umami keeps data (ADR 0233): what it holds is backed up before it moves - unifi keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, lab, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh is judged on its first machine **Machines** - mesh-tools on every machine running it: sent - audit-logger on every machine running it: sent - baserow on ace: passed — healthy 1 times over 1m50s - bazarr on ace: passed — judged with baserow: healthy 1 times over 1m50s - bookshelf on ace: passed — judged with baserow: healthy 1 times over 1m50s - confluence on every machine running it: sent - gitlab on every machine running it: sent - grafana on ace: passed — judged with baserow: healthy 1 times over 1m50s - home-assistant on ace: passed — judged with baserow: healthy 1 times over 1m50s - icecast on ace: passed — judged with baserow: healthy 1 times over 1m50s - influxdb on ace: passed — judged with baserow: healthy 1 times over 1m50s - jackett on ace: passed — judged with baserow: healthy 1 times over 1m50s - jira on every machine running it: sent - kometa on ace: passed — judged with baserow: healthy 1 times over 1m50s - letta on ace: passed — judged with baserow: healthy 1 times over 1m50s - lidarr on ace: passed — judged with baserow: healthy 1 times over 1m50s - mosquitto on ace: passed — judged with baserow: healthy 1 times over 1m50s - netcheck on ace: passed — judged with baserow: healthy 1 times over 1m50s - nodered on ace: passed — judged with baserow: healthy 1 times over 1m50s - ombi on ace: passed — judged with baserow: healthy 1 times over 1m50s - openai-consumer on every machine running it: sent - radarr on ace: passed — judged with baserow: healthy 1 times over 1m50s - redis on ace: passed — judged with baserow: healthy 1 times over 1m50s - route-adapter on every machine running it: sent - searxng on ace: passed — judged with baserow: healthy 1 times over 1m50s - sonarr on ace: passed — judged with baserow: healthy 1 times over 1m50s - tautulli on ace: passed — judged with baserow: healthy 1 times over 1m50s - unifi on ace: passed — judged with baserow: healthy 1 times over 1m50s - zsh on ace: passed — judged with baserow: healthy 1 times over 1m50s - gitea on novox: passed — healthy 1 times over 40s - mesh-catalog on novox: passed — judged with gitea: healthy 1 times over 40s - mesh-vault on novox: passed — judged with gitea: healthy 1 times over 40s - nextcloud on novox: passed — judged with gitea: healthy 1 times over 40s - umami on novox: passed — judged with gitea: healthy 1 times over 40s - lab on shanks: passed — healthy 1 times over 33s - gitea on the rest running it: sent - lab on the rest running it: sent - mesh-catalog on the rest running it: sent - mesh-vault on the rest running it: sent - nextcloud on the rest running it: sent - umami on the rest running it: sent - baserow on the rest running it: sent - bazarr on the rest running it: sent - bookshelf on the rest running it: sent - grafana on the rest running it: sent - home-assistant on the rest running it: sent - icecast on the rest running it: sent - influxdb on the rest running it: sent - jackett on the rest running it: sent - kometa on the rest running it: sent - letta on the rest running it: sent - lidarr on the rest running it: sent - mosquitto on the rest running it: sent - netcheck on the rest running it: sent - nodered on the rest running it: sent - ombi on the rest running it: sent - radarr on the rest running it: sent - redis on the rest running it: sent - searxng on the rest running it: sent - sonarr on the rest running it: sent - tautulli on the rest running it: sent - unifi on the rest running it: sent - zsh on the rest running it: sent **Transitions** - 2026-10-13 13:12 (new) → proposed (announced): novox/mesh-tools#33's head announced - 2026-10-13 13:14 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 13:14 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 13:26 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 13:26 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-13 13:42 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 52e275ad
Judged: head 52e275ad2f3a merged into trunk 954e1a53eef9; read beside it: mesh-catalog a84d0094a0a3, mesh-controller 6f1a05366c1d, mesh-controller-main 6f1a05366c1d, mesh-host 0e92ef3d1b21

  • mesh/merge-gate: PASS, WITH A NOTE — a merge rebuilds 40 module(s) in 2 tier(s) (modules: mesh-tools; built after them: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-tools (+39 dependent(s)) → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person

  • tier 0: mesh-tools
  • tier 1: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh
  • ace: receives baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh; waits for a person: mssql, nftables
  • g14: receives netcheck, zsh; waits for a person: nftables
  • novox: receives gitea, mesh-catalog, mesh-vault, netcheck, nextcloud, umami, zsh; waits for a person: mailu, minio, mongodb, mssql, nftables
  • shanks: receives lab, netcheck, zsh; waits for a person: nftables
  • baserow keeps data (ADR 0233): what it holds is backed up before it moves
  • bazarr keeps data (ADR 0233): what it holds is backed up before it moves
  • bookshelf keeps data (ADR 0233): what it holds is backed up before it moves
  • gitea provides npm-package-registry, git: its consumers are sent again after it
  • gitea keeps data (ADR 0233): what it holds is backed up before it moves
  • grafana keeps data (ADR 0233): what it holds is backed up before it moves
  • home-assistant keeps data (ADR 0233): what it holds is backed up before it moves
  • icecast keeps data (ADR 0233): what it holds is backed up before it moves
  • influxdb provides influxdb-api: its consumers are sent again after it
  • influxdb keeps data (ADR 0233): what it holds is backed up before it moves
  • jackett provides jackett-api: its consumers are sent again after it
  • jackett keeps data (ADR 0233): what it holds is backed up before it moves
  • kometa keeps data (ADR 0233): what it holds is backed up before it moves
  • lab keeps data (ADR 0233): what it holds is backed up before it moves
  • lidarr provides lidarr-api: its consumers are sent again after it
  • lidarr keeps data (ADR 0233): what it holds is backed up before it moves
  • mailu waits for a person: its policy records (module)
  • mailu provides smtp: its consumers are sent again after it
  • mailu keeps data (ADR 0233): what it holds is backed up before it moves
  • mesh-vault provides secret: its consumers are sent again after it
  • mesh-vault keeps data (ADR 0233): what it holds is backed up before it moves
  • minio waits for a person: its policy records (module)
  • minio provides s3-bucket: its consumers are sent again after it
  • minio keeps data (ADR 0233): what it holds is backed up before it moves
  • mongodb waits for a person: its policy records (module)
  • mongodb provides mongodb-database: its consumers are sent again after it
  • mongodb keeps data (ADR 0233): what it holds is backed up before it moves
  • mosquitto provides mqtt-topic: its consumers are sent again after it
  • mosquitto keeps data (ADR 0233): what it holds is backed up before it moves
  • mssql waits for a person: its policy records (module)
  • mssql provides mssql-database: its consumers are sent again after it
  • mssql keeps data (ADR 0233): what it holds is backed up before it moves
  • nextcloud keeps data (ADR 0233): what it holds is backed up before it moves
  • nftables waits for a person: its policy records (module)
  • nodered keeps data (ADR 0233): what it holds is backed up before it moves
  • ombi keeps data (ADR 0233): what it holds is backed up before it moves
  • radarr provides radarr-api: its consumers are sent again after it
  • radarr keeps data (ADR 0233): what it holds is backed up before it moves
  • redis provides redis-cache: its consumers are sent again after it
  • redis keeps data (ADR 0233): what it holds is backed up before it moves
  • searxng keeps data (ADR 0233): what it holds is backed up before it moves
  • sonarr provides sonarr-api: its consumers are sent again after it
  • sonarr keeps data (ADR 0233): what it holds is backed up before it moves
  • tautulli keeps data (ADR 0233): what it holds is backed up before it moves
  • umami provides analytics: its consumers are sent again after it
  • umami keeps data (ADR 0233): what it holds is backed up before it moves
  • unifi keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, lab, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh is judged on its first machine

Run by the build seat on ace as build-1791897149289906863 (builds --log build-1791897149289906863).

--- the gate: mesh-tools
mesh-tools: ok
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T13:07:29Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: WARNING — a merge rebuilds 40 module(s) in 2 tier(s)
judged by controller development build against the facts of 2026-10-13T13:07:29Z

warns:
  - a merge rebuilds 40 module(s) in 2 tier(s)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 40 module(s) in 2 tier(s)
--- its merge-check.sh (go toolchain)
NOT TESTED HERE: internal/runtime and internal/console launch bundles that need node and @novox/mesh-sdk
?   	github.com/novox/mesh-tools/node-tools/cmd/node-tools	[no test files]
ok  	github.com/novox/mesh-tools/node-tools/internal/alive	1.192s
ok  	github.com/novox/mesh-tools/node-tools/internal/announce	9.258s
ok  	github.com/novox/mesh-tools/node-tools/internal/bus	12.418s
ok  	github.com/novox/mesh-tools/node-tools/internal/launch	1.089s
ok  	github.com/novox/mesh-tools/node-tools/internal/meshtest	1.123s
ok  	github.com/novox/mesh-tools/node-tools/internal/npmlock	1.017s
?   	github.com/novox/mesh-tools/node-tools/internal/wire	[no test files]
ok  	github.com/novox/mesh-tools/node-tools/internal/console	11.384s
ok  	github.com/novox/mesh-tools/node-tools/internal/runtime	1.896s
NOT TESTED HERE: node-tools/src (TypeScript) needs @novox/mesh-sdk from the package registry
**Merge check** at `52e275ad` Judged: head `52e275ad2f3a` merged into trunk `954e1a53eef9`; read beside it: mesh-catalog `a84d0094a0a3`, mesh-controller `6f1a05366c1d`, mesh-controller-main `6f1a05366c1d`, mesh-host `0e92ef3d1b21` - `mesh/merge-gate`: **PASS, WITH A NOTE** — a merge rebuilds 40 module(s) in 2 tier(s) (modules: mesh-tools; built after them: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-tools (+39 dependent(s)) → ace, g14, novox, shanks; no bus step; 9 wait(s) for a person - tier 0: mesh-tools - tier 1: audit-logger, baserow, bazarr, bookshelf, confluence, gitea, gitlab, grafana, home-assistant, icecast, influxdb, jackett, jira, kometa, lab, letta, lidarr, mailu, mesh-catalog, mesh-vault, minio, mongodb, mosquitto, mssql, netcheck, nextcloud, nftables, nodered, ombi, openai-consumer, radarr, redis, route-adapter, searxng, sonarr, tautulli, umami, unifi, zsh - ace: receives baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh; waits for a person: mssql, nftables - g14: receives netcheck, zsh; waits for a person: nftables - novox: receives gitea, mesh-catalog, mesh-vault, netcheck, nextcloud, umami, zsh; waits for a person: mailu, minio, mongodb, mssql, nftables - shanks: receives lab, netcheck, zsh; waits for a person: nftables - baserow keeps data (ADR 0233): what it holds is backed up before it moves - bazarr keeps data (ADR 0233): what it holds is backed up before it moves - bookshelf keeps data (ADR 0233): what it holds is backed up before it moves - gitea provides npm-package-registry, git: its consumers are sent again after it - gitea keeps data (ADR 0233): what it holds is backed up before it moves - grafana keeps data (ADR 0233): what it holds is backed up before it moves - home-assistant keeps data (ADR 0233): what it holds is backed up before it moves - icecast keeps data (ADR 0233): what it holds is backed up before it moves - influxdb provides influxdb-api: its consumers are sent again after it - influxdb keeps data (ADR 0233): what it holds is backed up before it moves - jackett provides jackett-api: its consumers are sent again after it - jackett keeps data (ADR 0233): what it holds is backed up before it moves - kometa keeps data (ADR 0233): what it holds is backed up before it moves - lab keeps data (ADR 0233): what it holds is backed up before it moves - lidarr provides lidarr-api: its consumers are sent again after it - lidarr keeps data (ADR 0233): what it holds is backed up before it moves - mailu waits for a person: its policy records (module) - mailu provides smtp: its consumers are sent again after it - mailu keeps data (ADR 0233): what it holds is backed up before it moves - mesh-vault provides secret: its consumers are sent again after it - mesh-vault keeps data (ADR 0233): what it holds is backed up before it moves - minio waits for a person: its policy records (module) - minio provides s3-bucket: its consumers are sent again after it - minio keeps data (ADR 0233): what it holds is backed up before it moves - mongodb waits for a person: its policy records (module) - mongodb provides mongodb-database: its consumers are sent again after it - mongodb keeps data (ADR 0233): what it holds is backed up before it moves - mosquitto provides mqtt-topic: its consumers are sent again after it - mosquitto keeps data (ADR 0233): what it holds is backed up before it moves - mssql waits for a person: its policy records (module) - mssql provides mssql-database: its consumers are sent again after it - mssql keeps data (ADR 0233): what it holds is backed up before it moves - nextcloud keeps data (ADR 0233): what it holds is backed up before it moves - nftables waits for a person: its policy records (module) - nodered keeps data (ADR 0233): what it holds is backed up before it moves - ombi keeps data (ADR 0233): what it holds is backed up before it moves - radarr provides radarr-api: its consumers are sent again after it - radarr keeps data (ADR 0233): what it holds is backed up before it moves - redis provides redis-cache: its consumers are sent again after it - redis keeps data (ADR 0233): what it holds is backed up before it moves - searxng keeps data (ADR 0233): what it holds is backed up before it moves - sonarr provides sonarr-api: its consumers are sent again after it - sonarr keeps data (ADR 0233): what it holds is backed up before it moves - tautulli keeps data (ADR 0233): what it holds is backed up before it moves - umami provides analytics: its consumers are sent again after it - umami keeps data (ADR 0233): what it holds is backed up before it moves - unifi keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before baserow, bazarr, bookshelf, grafana, home-assistant, icecast, influxdb, jackett, kometa, lab, letta, lidarr, mosquitto, netcheck, nodered, ombi, radarr, redis, searxng, sonarr, tautulli, unifi, zsh is judged on its first machine Run by the build seat on ace as `build-1791897149289906863` (`builds --log build-1791897149289906863`). ``` --- the gate: mesh-tools mesh-tools: ok long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T13:07:29Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: WARNING — a merge rebuilds 40 module(s) in 2 tier(s) judged by controller development build against the facts of 2026-10-13T13:07:29Z warns: - a merge rebuilds 40 module(s) in 2 tier(s) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 40 module(s) in 2 tier(s) --- its merge-check.sh (go toolchain) NOT TESTED HERE: internal/runtime and internal/console launch bundles that need node and @novox/mesh-sdk ? github.com/novox/mesh-tools/node-tools/cmd/node-tools [no test files] ok github.com/novox/mesh-tools/node-tools/internal/alive 1.192s ok github.com/novox/mesh-tools/node-tools/internal/announce 9.258s ok github.com/novox/mesh-tools/node-tools/internal/bus 12.418s ok github.com/novox/mesh-tools/node-tools/internal/launch 1.089s ok github.com/novox/mesh-tools/node-tools/internal/meshtest 1.123s ok github.com/novox/mesh-tools/node-tools/internal/npmlock 1.017s ? github.com/novox/mesh-tools/node-tools/internal/wire [no test files] ok github.com/novox/mesh-tools/node-tools/internal/console 11.384s ok github.com/novox/mesh-tools/node-tools/internal/runtime 1.896s NOT TESTED HERE: node-tools/src (TypeScript) needs @novox/mesh-sdk from the package registry ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 52e275ad2f

Independent review of issue 624 (node-tools' lock behind its package.json).

Lock (node-tools/package-lock.json)

  • lockfileVersion 3. The root entry now matches package.json exactly: @novox/mesh-sdk ^0.1.6, plus esbuild, mongodb, mssql and pg in devDependencies.
  • @novox/mesh-sdk resolves to 0.1.14 from git.novox.be/api/packages/novox/npm, with an integrity hash. Main had 0.1.1, with no resolved URL or integrity.
  • There are 126 new package entries. All are dev, and all are the transitive tree of the four new devDependencies (the azure/tedious tree for mssql, bson for mongodb, the pg-* packages, and esbuild's optional platform packages). No existing entry was removed or changed except the SDK. Resolved hosts: registry.npmjs.org 126 and git.novox.be 1. Nothing else.
  • Only esbuild has an install script.

Check (node-tools/internal/npmlock)

  • It cannot pass vacuously. A missing package.json or lock is an error, and the test calls t.Fatal (I checked by removing the lock). A lockfileVersion below 2 is a finding, and so is a lock without a root entry.
  • Swapping in main's lock makes TestNodeToolsLockIsInStepWithItsPackage fail with 9 findings: the SDK range, plus each of the four packages missing from the root and from node_modules.
  • It needs no change to merge-check.sh, because that script tests go list ./.... The repo-check report shows ok .../internal/npmlock.

Run locally (clone since deleted)

  • npm ci --ignore-scripts: added 108 packages, and node_modules/@novox/mesh-sdk is 0.1.14. That works with no @novox registry line in npmrc, because the lock carries the forge URL.
  • go test ./... (nice, -p=2, GOMAXPROCS=4) after npm ci: every package is ok, including internal/runtime and internal/console. Before npm ci, those two fail, as merge-check.sh already says they will without node_modules.

Non-blocking notes

  1. npmlock.go:60-74 compares range strings and checks that node_modules/ exists. It does not check that the resolved version satisfies the range, and it does not check packages beyond the root. npm ci also rejects a hand-edited lock whose root range matches but whose resolved version is outside it. That is unlikely here, because the lock is generated.
  2. npmlock.go reads no workspaces field and no entries for nested workspace packages. node-tools has no workspaces, so this does not apply today. A short comment saying so would help.
  3. Six entries are left over from main's lock with a version but no resolved URL or integrity hash: nats, nkeys.js, tweetnacl, typescript, @types/node and undici-types. npm install --package-lock-only kept them as they were. npm ci fetches them by version without an integrity check. A full regenerate (delete the lock, then npm install --package-lock-only) would pin them. This was the same on main, so it is not a regression.

Statuses at this head: mesh/merge-gate success (WARNING: a merge rebuilds 40 modules in 2 tiers), mesh/repo-check success (PASS: its merge-check.sh passed), mesh/delivery success (ready: it delivers once merged).

Verdict: approve at 52e275ad2f3a522f1df2d89d86406d65e421f8f1 Independent review of issue 624 (node-tools' lock behind its package.json). Lock (node-tools/package-lock.json) - lockfileVersion 3. The root entry now matches package.json exactly: @novox/mesh-sdk ^0.1.6, plus esbuild, mongodb, mssql and pg in devDependencies. - @novox/mesh-sdk resolves to 0.1.14 from git.novox.be/api/packages/novox/npm, with an integrity hash. Main had 0.1.1, with no resolved URL or integrity. - There are 126 new package entries. All are dev, and all are the transitive tree of the four new devDependencies (the azure/tedious tree for mssql, bson for mongodb, the pg-* packages, and esbuild's optional platform packages). No existing entry was removed or changed except the SDK. Resolved hosts: registry.npmjs.org 126 and git.novox.be 1. Nothing else. - Only esbuild has an install script. Check (node-tools/internal/npmlock) - It cannot pass vacuously. A missing package.json or lock is an error, and the test calls t.Fatal (I checked by removing the lock). A lockfileVersion below 2 is a finding, and so is a lock without a root entry. - Swapping in main's lock makes TestNodeToolsLockIsInStepWithItsPackage fail with 9 findings: the SDK range, plus each of the four packages missing from the root and from node_modules. - It needs no change to merge-check.sh, because that script tests `go list ./...`. The repo-check report shows `ok .../internal/npmlock`. Run locally (clone since deleted) - npm ci --ignore-scripts: added 108 packages, and node_modules/@novox/mesh-sdk is 0.1.14. That works with no @novox registry line in npmrc, because the lock carries the forge URL. - go test ./... (nice, -p=2, GOMAXPROCS=4) after npm ci: every package is ok, including internal/runtime and internal/console. Before npm ci, those two fail, as merge-check.sh already says they will without node_modules. Non-blocking notes 1. npmlock.go:60-74 compares range strings and checks that node_modules/<name> exists. It does not check that the resolved version satisfies the range, and it does not check packages beyond the root. npm ci also rejects a hand-edited lock whose root range matches but whose resolved version is outside it. That is unlikely here, because the lock is generated. 2. npmlock.go reads no `workspaces` field and no entries for nested workspace packages. node-tools has no workspaces, so this does not apply today. A short comment saying so would help. 3. Six entries are left over from main's lock with a version but no resolved URL or integrity hash: nats, nkeys.js, tweetnacl, typescript, @types/node and undici-types. npm install --package-lock-only kept them as they were. npm ci fetches them by version without an integrity check. A full regenerate (delete the lock, then npm install --package-lock-only) would pin them. This was the same on main, so it is not a regression. Statuses at this head: mesh/merge-gate success (WARNING: a merge rebuilds 40 modules in 2 tiers), mesh/repo-check success (PASS: its merge-check.sh passed), mesh/delivery success (ready: it delivers once merged).
mesh-admin merged commit d0dcae53a8 into main 2026-10-13 13:19:41 +00:00
mesh-admin deleted branch fix/624-node-tools-lock-in-step 2026-10-13 13:19:41 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-tools#33