Bound a state watch's hand-over by its progress, not its whole set, so the gitea module binds the checker's owed statuses again (issue 1726) #41

Merged
jschoubben merged 1 commits from fix/1726-group-check-status into main 2026-10-24 10:35:43 +00:00
Member

Issue 1726, met again: since node-tools restarted on novox at 03:05:44, the gitea module's watch of mesh-delivery-checker.owed never binds. StateWatch (node-tools/internal/bus/state.go) gave the whole set of current values 10 s; with about 200 owed keys, one stdio round trip each, that is slower than 10 s. Every newer mesh/check is dropped ('names no watch of this bundle'), so no pull request becomes ready and no Approve ask is raised (fix/1937-done-key-blobs passed at 07:26 and has no mesh/check).

StateWatch now restarts its 10 s bound on each value handed over; a bundle that takes nothing for 10 s is still refused. New integration test node-tools/internal/bus/state_watch_test.go (33 keys at 3x the bound, in order, then a live change; and a hung bundle refused). Try try-1792820537728056102 passed (2m46s).

Recovery once delivered: node-tools restarts on novox, the gitea watch binds and writes every owed key's latest mesh/check, the fix/1937 group's passes included. This pull request's own check meets the same broken watch, so it needs the operator's hand merge.

Reviewed-by: review-1726b@shanks at 0211844e6a
Pushed-by: lead-47@shanks

Issue 1726, met again: since node-tools restarted on novox at 03:05:44, the gitea module's watch of mesh-delivery-checker.owed never binds. StateWatch (node-tools/internal/bus/state.go) gave the whole set of current values 10 s; with about 200 owed keys, one stdio round trip each, that is slower than 10 s. Every newer mesh/check is dropped ('names no watch of this bundle'), so no pull request becomes ready and no Approve ask is raised (fix/1937-done-key-blobs passed at 07:26 and has no mesh/check). StateWatch now restarts its 10 s bound on each value handed over; a bundle that takes nothing for 10 s is still refused. New integration test node-tools/internal/bus/state_watch_test.go (33 keys at 3x the bound, in order, then a live change; and a hung bundle refused). Try try-1792820537728056102 passed (2m46s). Recovery once delivered: node-tools restarts on novox, the gitea watch binds and writes every owed key's latest mesh/check, the fix/1937 group's passes included. This pull request's own check meets the same broken watch, so it needs the operator's hand merge. Reviewed-by: review-1726b@shanks at 0211844e6ad31523bc41b4a557db5f8b7dd65ead Pushed-by: lead-47@shanks
mesh-tools added 1 commit 2026-10-24 05:48:25 +00:00
Bound a state watch's hand-over by its progress, not its whole set, so a large state's newest keys are handed over (issue 1726)
mesh/delivery delivering: 0 machine step(s) passed
mesh/check pass 0211844e6ad3 on 0e985f9bf186 | unit 0 run 117 kept | int 0 run 119 kept | clone 5.4s | composition passed on 4 machines
0211844e6a
The gitea module's watch of mesh-delivery-checker.owed failed at every attempt
since 03:05 on novox: about 200 owed keys, each a round trip to the bundle,
outlast a 10 s bound for the whole set. The bundle dropped its handler, the
oldest keys were written again every 40 s and the newest, handed over last,
never were: group fix/1937-done-key-blobs's pass never reached mesh/check.
StateWatch now fails only when no current value is handed over within
StateTimeout.
Author
Member

Delivery novox/mesh-tools@0211844e6ad3 — delivered since 2026-10-24T10:38:09Z

Delivery plan — builds node-tools → ace, g14, novox, shanks; no bus step

  • tier 0: node-tools
  • ace: receives node-tools
  • g14: receives node-tools
  • novox: receives node-tools
  • shanks: receives node-tools
  • node-tools provides mcp-endpoint: its consumers are sent again after it
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before node-tools is judged on its first machine

Machines

  • node-tools on every machine running it: sent

Transitions

  • 2026-10-24 05:48 (new) → proposed (announced): novox/mesh-tools#41's head announced
  • 2026-10-24 10:35 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on
  • 2026-10-24 10:35 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's plans go
  • 2026-10-24 10:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-tools@0211844e6ad3` — **delivered** since 2026-10-24T10:38:09Z **Delivery plan** — builds node-tools → ace, g14, novox, shanks; no bus step - tier 0: node-tools - ace: receives node-tools - g14: receives node-tools - novox: receives node-tools - shanks: receives node-tools - node-tools provides mcp-endpoint: its consumers are sent again after it - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before node-tools is judged on its first machine **Machines** - node-tools on every machine running it: sent **Transitions** - 2026-10-24 05:48 (new) → proposed (announced): novox/mesh-tools#41's head announced - 2026-10-24 10:35 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on - 2026-10-24 10:35 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's `plans go` - 2026-10-24 10:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben merged commit 77b05089c8 into main 2026-10-24 10:35:43 +00:00
jschoubben deleted branch fix/1726-group-check-status 2026-10-24 10:35:44 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-tools#41