From 40e0e8282b382eb2c0d5204b1aba3d6cde89f303 Mon Sep 17 00:00:00 2001 From: jochen Date: Tue, 3 Nov 2026 21:28:29 +0100 Subject: [PATCH] Take tool-runner out of node-tools' manifest until the judge that knows it runs The running indexer's judge refuses the word, a refused manifest holds the bus's user list, and so the indexer build that knows the word is never granted. The node-engine on main and node-tools find the runner by its name; the grants part keeps the runner's users as they run while no manifest says it; the word comes back once the new judge runs (issue 774). Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn --- node-tools/internal/provide/provide_test.go | 10 ++++++---- node-tools/module.json | 1 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/node-tools/internal/provide/provide_test.go b/node-tools/internal/provide/provide_test.go index 47957c9..413825d 100644 --- a/node-tools/internal/provide/provide_test.go +++ b/node-tools/internal/provide/provide_test.go @@ -206,12 +206,14 @@ func TestTheManifestNamesNothingOfTheController(t *testing.T) { if err != nil { t.Fatal(err) } - // Read as text, as mesh-catalog's controllerdeps check reads its own: mesh-sdk names no module (issue 774), and the - // manifest says it is the tool runner rather than being known by its name. + // Read as text, as mesh-catalog's controllerdeps check reads its own: mesh-sdk names no module (issue 774). if strings.Contains(string(raw), "mesh-controller") { t.Error("node-tools' manifest names the ended controller") } - if !catalogue.IsToolRunner(m) { - t.Error("node-tools' manifest does not say it is the tool runner (\"tool-runner\": true)") + // The manifest says nothing of being the tool runner until the indexer whose judge knows the word runs (issue 774): + // the running judge refuses a manifest with "tool-runner", and while one manifest is refused the grants part holds + // the bus's user list, so the build of the indexer that knows it is never granted. The word comes back then. + if catalogue.IsToolRunner(m) { + t.Error("node-tools' manifest says \"tool-runner\" before the judge that reads it runs") } } diff --git a/node-tools/module.json b/node-tools/module.json index 535300f..e6cb6db 100644 --- a/node-tools/module.json +++ b/node-tools/module.json @@ -2,7 +2,6 @@ "module": "node-tools", "version": "1", "slug": "node-tools", - "tool-runner": true, "invokes": [ "*" ], -- 2.54.0