Stop compiling the toolkit by hand; it arrives compiled now #8

Merged
jschoubben merged 1 commits from feat/no-workaround-for-a-package-that-works into main 2026-09-14 09:09:06 +00:00
2 changed files with 5 additions and 8 deletions
+4 -7
View File
@@ -23,13 +23,10 @@ WORKDIR /app
COPY package.json package-lock.json ./ COPY package.json package-lock.json ./
# Development dependencies included: the compiler is one, and so is the toolkit's own. # Development dependencies included: the compiler is one, and so is the toolkit's own.
RUN npm install --no-audit --no-fund RUN npm install --no-audit --no-fund
# **And then compile the toolkit, because npm did not.** It declares a `prepare` script, the hook a # The toolkit arrives compiled. It used to arrive as sources, and this compiled it by hand — the
# package manager is supposed to run after installing from git, and this one does not run it — so # hook that builds it on install was running all along, and the result was then packed out of the
# the package arrives as sources with every entry point pointing at a compiled directory that is not # package, because with no explicit file list npm falls back to .gitignore and that ignores the
# there. Done explicitly rather than relying on a hook firing, which would break the day it stopped. # build output. Fixed where it belonged, in the toolkit.
RUN npm --prefix node_modules/@novox/mesh-sdk install --no-audit --no-fund \
&& npm --prefix node_modules/@novox/mesh-sdk run build \
&& npm --prefix node_modules/@novox/mesh-sdk prune --omit=dev
COPY tsconfig.json ./ COPY tsconfig.json ./
COPY src ./src COPY src ./src
RUN npm run build RUN npm run build
+1 -1
View File
@@ -11,7 +11,7 @@
"test": "node --test --experimental-strip-types 'test/*.test.ts'" "test": "node --test --experimental-strip-types 'test/*.test.ts'"
}, },
"dependencies": { "dependencies": {
"@novox/mesh-sdk": "git+https://git.novox.be/novox/mesh-sdk.git#a1ed33b", "@novox/mesh-sdk": "git+https://git.novox.be/novox/mesh-sdk.git#9213336",
"amqplib": "^0.10.9" "amqplib": "^0.10.9"
}, },
"devDependencies": { "devDependencies": {