jschoubben
a5b8ae1a72
Builds: design 47 G §368, §387, §196 (consumes catalog-revision; views.modules goes with T-2's first view) Held: waits (§426) goes with the every-event part, which removes the code reading it. Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ
76 lines
3.3 KiB
Go
76 lines
3.3 KiB
Go
package console
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// novox/hq ADR 0367 §5: the tool runner's manifest names the families a session waits on today, one by one,
|
|
// and the asker's `decided` for the claude-code module alone. Adding one is a reviewed change to this file
|
|
// (§6), so this list changes with it. The delivery's transitions are waited on under the gate's name alone (ADR 0450 §8, issues 1350
|
|
// and 1406): today's module is forgotten.
|
|
func TestTheManifestNamesTheFirstFamiliesOneByOne(t *testing.T) {
|
|
raw, err := os.ReadFile("../../module.json")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var m struct {
|
|
Module string `json:"module"`
|
|
Waits []string `json:"waits"`
|
|
Consumes []string `json:"consumes"`
|
|
Streams []struct {
|
|
Name string `json:"name"`
|
|
Events []string `json:"events"`
|
|
} `json:"streams"`
|
|
}
|
|
if err := json.Unmarshal(raw, &m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(m.Streams) != 1 || m.Streams[0].Name != "node-tools-findings" ||
|
|
!reflect.DeepEqual(m.Streams[0].Events, []string{"finding-written.*", "finding-cleared.*", "findings-stated.*"}) {
|
|
t.Errorf("the finding stream is %+v, want node-tools-findings with the three finding events (design 47 G §387)", m.Streams)
|
|
}
|
|
want := []string{"mesh-knowledge.reviewed", "mesh-delivery-gate.transition", "gitea.forge.status",
|
|
"mesh-self-check.checked", "operator-channel.decided.claude-code"}
|
|
if m.Module != "node-tools" || !reflect.DeepEqual(m.Waits, want) {
|
|
t.Errorf("%s waits on %v, want %v", m.Module, m.Waits, want)
|
|
}
|
|
for _, w := range m.Waits {
|
|
if strings.ContainsAny(w, "*>") {
|
|
t.Errorf("a family named by a wildcard: %s", w)
|
|
}
|
|
}
|
|
// A wait is no consumer (ADR 0367 §2): what it consumes is the four views families of its first views (ADR 0615 §5, issue
|
|
// 1966 TLS-5) and the two events of the seat that serves the seat list (ADR 0636 §4), and nothing else.
|
|
// Design 47 G §196, §387: the catalog half by `catalog-revision` (never the indexer's `views.modules`), and the keeper's
|
|
// `findings-asked`; the finding stream below. `views.modules` goes with the first view that follows it (T-2).
|
|
wantConsumes := []string{"mesh-catalog.catalog-revision", "mesh-catalog.seat-definition-changed", "mesh-catalog.seat-definition-removed",
|
|
"mesh-conditions.findings-asked", "mesh-delivery-assigner.views.assignments", "mesh-delivery-assigner.views.seat-holders",
|
|
"mesh-delivery-indexer.views.manifests", "mesh-delivery-indexer.views.modules"}
|
|
if !reflect.DeepEqual(m.Consumes, wantConsumes) {
|
|
t.Errorf("the tool runner consumes %v, want %v", m.Consumes, wantConsumes)
|
|
}
|
|
}
|
|
|
|
// issue 1966 TLS-1: the tool runner declares its own secret `ledgers`, each module's ledger credential, in the directory it
|
|
// keeps its broker credential in, which is where the runner reads it (runtime.LedgersFileOf).
|
|
func TestTheManifestDeclaresTheRunnersOwnSecretLedgers(t *testing.T) {
|
|
raw, err := os.ReadFile("../../module.json")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var m struct {
|
|
OwnSecrets map[string]string `json:"own-secrets"`
|
|
}
|
|
if err := json.Unmarshal(raw, &m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
want := map[string]string{"broker": "${dir:mesh-state}/broker", "ledgers": "${dir:mesh-state}/ledgers"}
|
|
if !reflect.DeepEqual(m.OwnSecrets, want) {
|
|
t.Errorf("own secrets %v, want %v", m.OwnSecrets, want)
|
|
}
|
|
}
|