jschoubben
481a83e11c
The tests G added fold into existing ones as subtests (design 47 G §626, A-306: 171 tests down to 154, integration 9 down to 7). TestMeshWaitRefusesLoudlyAndNeverLoops runs its groups of one-second rows as parallel subtests, each on a runtime of its own, 15 s down to 5 s (A-311: the one-second floor of a wait's timeout stands, no clock is injected). The go.mod no longer requires meshconditionsclient, which no package loads (T4). Node names in the lines G adds are role names (T5). Builds: design 47 G §626, design 34 every-event §19, A-306, A-311; review round 2 findings T2, T3, T4, T5 Claude-Session: https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h
76 lines
3.4 KiB
Go
76 lines
3.4 KiB
Go
package runtime
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/novox/mesh-tools/node-tools/internal/bus"
|
|
)
|
|
|
|
// novox/hq ADR 0259 §8: a runtime on a module's own account serves that module alone, and the machine's
|
|
// runtime never serves itself.
|
|
func TestARuntimeOnAModulesOwnAccountServesThatModuleAlone(t *testing.T) {
|
|
if got, err := ServedModulesFrom("telegram=/b/telegram/tools/telegram", "telegram"); err != nil || len(got) != 1 {
|
|
t.Fatalf("a module's own runtime could not serve it: %v", err)
|
|
}
|
|
if _, err := ServedModulesFrom("telegram=/b/t,dunst=/b/d", "telegram"); err == nil || !strings.Contains(err.Error(), "serves telegram alone") {
|
|
t.Errorf("a module's own runtime served another: %v", err)
|
|
}
|
|
if _, err := ServedModulesFrom("node-tools=/b/n", "node-tools"); err == nil {
|
|
t.Error("the machine's runtime served itself")
|
|
}
|
|
}
|
|
|
|
// No bus word reaches a bundle (security review of 2026-10-08), not even one its module's words name.
|
|
func TestNoBusWordReachesABundle(t *testing.T) {
|
|
base := []string{"MESH_BROKER_FILE=/etc/mesh/broker", "MESH_BROKER_URL=nats://x", "MESH_TOOL_ENV={}",
|
|
"MESH_TOOL_MODULES=a=/b", "MESH_CONSOLE_LISTEN=127.0.0.1:1", "PATH=/usr/bin"}
|
|
env := strings.Join(BundleEnv(base, map[string]string{"MESH_BROKER_FILE": "/again", "OWN": "1"}, "telegram", "anchor"), "\n")
|
|
for _, never := range []string{"MESH_BROKER_FILE", "MESH_BROKER_URL", "MESH_TOOL_ENV", "MESH_TOOL_MODULES", "MESH_CONSOLE_LISTEN"} {
|
|
if strings.Contains(env, never+"=") {
|
|
t.Errorf("%s reached the bundle", never)
|
|
}
|
|
}
|
|
for _, want := range []string{"PATH=/usr/bin", "OWN=1", "MESH_MODULE=telegram", "MESH_NODE=anchor"} {
|
|
if !strings.Contains(env, want) {
|
|
t.Errorf("%s did not reach the bundle", want)
|
|
}
|
|
}
|
|
// design 47 G §618, §519: the runtime's own fingerprint reaches no bundle; the fingerprint a module's composed words hold does.
|
|
t.Run("TheRuntimesOwnFingerprintReachesNoBundle", func(t *testing.T) {
|
|
base := []string{"MESH_FINGERPRINT=runner-build", "PATH=/usr/bin"}
|
|
for name, c := range map[string]struct {
|
|
given map[string]string
|
|
want string
|
|
}{
|
|
"composed with none sees none": {nil, ""},
|
|
"composed with one sees its own": {map[string]string{"MESH_FINGERPRINT": "module-build"}, "MESH_FINGERPRINT=module-build"},
|
|
} {
|
|
env := strings.Join(BundleEnv(base, c.given, "telegram", "anchor"), "\n")
|
|
if strings.Contains(env, "runner-build") {
|
|
t.Errorf("%s: the runtime's own fingerprint reached the bundle: %s", name, env)
|
|
}
|
|
if c.want == "" && strings.Contains(env, "MESH_FINGERPRINT") || !strings.Contains(env, c.want) {
|
|
t.Errorf("%s: the environment is %s", name, env)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
// A tool call reaches only a tool's subject: whatever key a caller names, it is never a seat's event, accept
|
|
// or proof — so no tool call says a choice, a link or a code, or submits an ask, in anybody's name.
|
|
func TestAToolCallNeverReachesASeatsEventAcceptOrProof(t *testing.T) {
|
|
for _, key := range []string{"seat:intake.event.choice.telegram", "seat:intake.proof.code.telegram",
|
|
"seat:operator-channel.accept.ask.mesh-delivery", "intake.event", "seat:operator-channel.event.decided.x@anchor",
|
|
"telegram.anything", "x"} {
|
|
subject, err := bus.ToolSubject(key, "node-tools")
|
|
if err != nil {
|
|
continue
|
|
}
|
|
tokens := strings.Split(subject, ".")
|
|
if len(tokens) < 4 || tokens[3] != "tool" {
|
|
t.Errorf("%q reaches %s, which is not a tool's subject", key, subject)
|
|
}
|
|
}
|
|
}
|