Design 47 H: H-A-373 to H-A-375, every publish names its version; a declared directory mode is applied to an existing directory; a step a node cannot run moves
This commit is contained in:
@@ -2315,3 +2315,32 @@ Where two preparers disagreed, the chosen one is named.
|
||||
with an empty version, so the builder says "package-published not said … a by-digest publish" and the bundle is
|
||||
not marked against its reservation. Fix in the Node build module: the publish carries the version the ask
|
||||
reserved. Test: a bundle's publish names the ask's version. P3, P-failure-loud.
|
||||
- **H-A-373 (every build module's publish names the ask's version, 23:50)** The developer of H-A-372 found the Go build
|
||||
module publishes every bundle and archive with an empty version too (its publish of an archive). The second of a
|
||||
kind: a build module's publish that names no version marks no reservation. Fix the kind: every build module's
|
||||
publish (the Go build module's bundles and archives, the Node build module's bundles, the image build module's
|
||||
images where it publishes) carries the version the ask reserved; the delivery SDK's publish refuses an empty version
|
||||
with a Go bundle or package, loudly, so no build module can publish by digest alone again. Built in the same change
|
||||
as H-A-371 and H-A-372, tested the same way. fix-a-bug-met-twice, P-failure-loud.
|
||||
- **H-A-374 (a directory's declared mode is applied to a directory that exists, 23:50)** Pipeline main.175 failed at
|
||||
23:24 because the Node build module's integration tests, asked of the Go build seat on ace, could not see the Node
|
||||
toolchain: ace's toolchain cache directory is 0700 on disk while the manifest's directory entry says 0711 (ADR 0533)
|
||||
and the other build nodes have 0711; the node-engine's composition on ace says "unchanged, equal to the composition
|
||||
the node runs". So the node-engine applies a directory entry's mode when it makes the directory and never when the
|
||||
directory exists with another mode, and its judgement reads what it wrote, not the disk. Fix in the node-engine
|
||||
(mesh-host, H2's E lines): applying a directory entry sets its owner and mode when they differ on disk, and the
|
||||
composition's diff names a directory whose mode on disk differs. Test: a directory that exists with another mode is
|
||||
set to the declared one at apply. Recovery tonight: the mode set through the files seat's chmod verb on ace with
|
||||
this answer as its reason; the engine's next apply must leave it. P-mesh-owns-the-truth, P-failure-loud.
|
||||
- **H-A-375 (a pipeline step a node cannot run moves to a node that can, 23:50)** The same failure showed a gap: the
|
||||
Go build module answered the integration step's digest "left to a node with node-build-node: this node lacks it",
|
||||
the step ended could not run, and the runner counted that as failed and ended the pipeline; nothing placed the step
|
||||
on g14 or shanks, which have the need. ADR 0552 §2 and §4 decide this for check asks (a holder lacking a need
|
||||
declines; the asker places the unmet packages again on a node with the need) and no design line carried it to the
|
||||
pipeline's step asks. Carry it: the runner's step ask names the packages' needs (read from the module's needs
|
||||
marker, as the Go build module does for its digest); a build seat holder lacking a need declines the ask instead of
|
||||
ending it could not run; the runner places a declined step again on a node that has the need, once per node at
|
||||
most, and a step no node can run ends could not run naming the need and the nodes asked. Built by H2's
|
||||
mesh-delivery developer (the runner's placing and the delivery SDK's step run) after its Left list, in H2's one
|
||||
review; it is not a small fix. Until then a could-not-run step is rerun by hand (runner_rerun). P-NATS-native,
|
||||
P-failure-loud, ADR 0552.
|
||||
|
||||
Reference in New Issue
Block a user