novox/hq
13
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Judge a catalogue removal by the controller's unit tests against the catalogue's branch, not by a try
mesh/merge-gate head 5705da30c006 merged into trunk a5c6c98ecca0 — pass: the change touches no module of the mesh's graph
Details
mesh/repo-check head 5705da30c006 merged into trunk a5c6c98ecca0 — pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details

Browse Source 
A controller try reads the catalogue's main, so it would have passed for mesh-catalog #381 (review round 1).
This commit is contained in:
mesh-tools
2026-10-20 17:59:47 +00:00
parent 1d7cfed47a
commit 5705da30c0
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
00-META/process/07-feature-branches.md
+8 -4
View File
@@ -225,10 +225,14 @@ never into the running one, unless it blocks the running one.
`Reviewed-by: <who@node> at <full sha>` (the issue 1022 note gives its form). mesh-delivery reads it at every new
head and puts it in the Approve's ask; a missing line, or one naming another commit, is said first in the ask.
It is never a gate.
**A catalogue pull request that removes a module, or a subject a module names, is also tried against the
controller** (`mesh-controller.try` with mesh-controller's main), because the controller's own tests read the
catalogue: on 2026-10-20 mesh-catalog #381 removed the old delivery module, and every controller check failed
afterwards on a test of the catalogue's subjects until issue 1406 removed the name mesh-issues still listened to.
**A catalogue pull request that removes a module, or a subject a module names, is also judged by the
controller's unit tests against the catalogue's branch**, because those tests read the catalogue and no check
of the catalogue runs them: on 2026-10-20 mesh-catalog #381 removed the old delivery module, and every
controller check failed afterwards on a test of the catalogue's subjects until issue 1406 removed the name
mesh-issues still listened to. A controller try does not find it, since a check reads the catalogue's main
(also in a delivery group that holds the catalogue's pull request); the lead runs mesh-controller's unit
suite with `MESH_CHECK_BESIDE` naming a directory that holds the catalogue's branch, as mesh-controller's
`internal/beside` says.
2. **The forge's merge checks run the integration tests again, as the gate** (`mesh/merge-gate`, `mesh/repo-check`). No
second review: step 2 reviewed this tree.
3. **A check that fails** goes back to the same reviewer, continued by its id, with the failure, for **one more cycle** of step 2 with