novox/hq
9
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Issue 324 and ADR 0258: a desk click performs only an acknowledgement, an answer is a one-time ticket #208

Merged
mesh-admin merged 3 commits from fix/notifications-after-review into main 2026-10-08 13:03:01 +00:00
Conversation 1 Commits 3 Files Changed 5
+216 -4
mesh-admin commented 2026-10-08 12:40:25 +00:00
Contributor
Copy Link
Copy Source

Review of ADR 0253 after it merged:

  • Issue 324: a desk click could release, stop or start a delivery or restart a service in the operator's name (any process of the account can choose a dunst action); tokens never expired; refused words weakened the verdict; sound words were refused; a quiet warning could stay quiet for ever; the desk's answers died.
  • ADR 0258 (extends 0253): a desk click performs only Details and Silence for a week until to-be 46 phase 5; one-time tokens bound to condition and machine, a day, once per event; the why says it was a desk click; a refused verdict is kept; the plain rule's false refusals end; a change of words is a condition-changed; a quiet warning is said after a day; answers do not expire and come back after a notifier restart; zone data carried.
  • ADR 0253 §6 gets a dated "mechanism changed" note (its decision record is not rewritten: hq's rule); to-be 45 §2/§5 and to-be 46 §11 amended.

Checks: records, index, cycle, words (with the catalogue's list) pass.

Group: novox/mesh-controller and novox/mesh-catalog fix/notifications-after-review. Do not merge without the operator.

Review of ADR 0253 after it merged: - **Issue 324**: a desk click could release, stop or start a delivery or restart a service in the operator's name (any process of the account can choose a dunst action); tokens never expired; refused words weakened the verdict; sound words were refused; a quiet warning could stay quiet for ever; the desk's answers died. - **ADR 0258** (extends 0253): a desk click performs only Details and Silence for a week until to-be 46 phase 5; one-time tokens bound to condition and machine, a day, once per event; the why says it was a desk click; a refused verdict is kept; the plain rule's false refusals end; a change of words is a `condition-changed`; a quiet warning is said after a day; answers do not expire and come back after a notifier restart; zone data carried. - ADR 0253 §6 gets a dated "mechanism changed" note (its decision record is not rewritten: hq's rule); to-be 45 §2/§5 and to-be 46 §11 amended. Checks: records, index, cycle, words (with the catalogue's list) pass. Group: novox/mesh-controller and novox/mesh-catalog `fix/notifications-after-review`. Do not merge without the operator.
mesh-admin added 1 commit 2026-10-08 12:40:25 +00:00
Issue 324 and ADR 0258: a desk click performs only an acknowledgement dd149a72c0 
Review found that ADR 0253 let any process at the operator's session release,
stop or start a delivery in the operator's name, and that its tokens, fallback
words and quiet warnings failed on the paths that go wrong.
jschoubben added 1 commit 2026-10-08 12:40:32 +00:00
Issue 324: name the pull requests that fix it
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery-group group fix/notifications-after-review checking: 2 of 3 member(s) ready
Details
mesh/delivery superseded: a newer head of the same pull request
Details
f5d08f4b6f
mesh-admin commented 2026-10-08 12:40:44 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/hq@3bfedcfa1561 — delivered since 2026-10-08T13:03:24Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Group fix/notifications-after-review, in order: novox/hq@3bfedcfa15 → novox/mesh-controller@76cfbac7a1 → novox/mesh-catalog@700dd7fa1a

Transitions

  • 2026-10-08 12:57 (new) → proposed (announced): novox/hq#208's head announced
  • 2026-10-08 12:59 proposed → checked (checked): the verdict names this commit
  • 2026-10-08 12:59 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-08 13:03 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-08 13:03 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@3bfedcfa1561` — **delivered** since 2026-10-08T13:03:24Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Group** `fix/notifications-after-review`, in order: novox/hq@3bfedcfa1561 → novox/mesh-controller@76cfbac7a1eb → novox/mesh-catalog@700dd7fa1abd - novox/mesh-controller@76cfbac7a1eb before novox/mesh-catalog@700dd7fa1abd: built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Transitions** - 2026-10-08 12:57 (new) → proposed (announced): novox/hq#208's head announced - 2026-10-08 12:59 proposed → checked (checked): the verdict names this commit - 2026-10-08 12:59 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-08 13:03 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-08 13:03 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-08 12:56:50 +00:00
ADR 0258 and issue 324: the live window, data loss never silenced from a click, and where to give what no notification can
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
mesh/delivery-group group fix/notifications-after-review merged: every member is merged
Details
3bfedcfa15 
The second review found the fix could not read what the live build kept, missed
quiet warnings known from history, and let a click silence data loss.
mesh-admin merged commit fc9df13497 into main 2026-10-08 13:03:01 +00:00
mesh-admin deleted branch fix/notifications-after-review 2026-10-08 13:03:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#208