To-be 46: an approved settings change is sent at once (issue 641, ADR 0344) #346

Merged
mesh-admin merged 2 commits from design/641-an-approved-setting-is-sent into main 2026-10-13 15:27:04 +00:00
Contributor

Gives ADR 0344 (proposed, needs the operator's Approve) its home in to-be 46 §10: the table row for a proposed setting no longer says the push stays a separate act, and a short section says what the one Approve now does (a settings walk, judged per machine, told once at its end; a failure leaves the layer set), and that applying a delivered file is the module's (Betterbird: issue 643).

Code: novox/mesh-controller#305.

Checks run locally: records, index, cycle, words, and sh merge-check.sh pass.

Fixes issue 641 (design part).

Gives ADR 0344 (proposed, needs the operator's Approve) its home in to-be 46 §10: the table row for a proposed setting no longer says the push stays a separate act, and a short section says what the one Approve now does (a settings walk, judged per machine, told once at its end; a failure leaves the layer set), and that applying a delivered file is the module's (Betterbird: issue 643). Code: novox/mesh-controller#305. Checks run locally: records, index, cycle, words, and `sh merge-check.sh` pass. Fixes issue 641 (design part).
mesh-admin added 1 commit 2026-10-13 14:40:35 +00:00
Give ADR 0344 a home in design 46: an approved settings change is sent at once (issue 641)
mesh/merge-gate head 417a50d06c4a merged into trunk 471f99344b8d — pass: the change touches no module of the mesh's graph
mesh/repo-check head 417a50d06c4a merged into trunk 471f99344b8d — pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
417a50d06c
Author
Contributor

Delivery novox/hq@732e8bd4d940 — delivered since 2026-10-13T15:27:22Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-13 14:50 (new) → proposed (announced): novox/hq#346's head announced
  • 2026-10-13 14:51 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 14:51 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 15:27 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 15:27 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@732e8bd4d940` — **delivered** since 2026-10-13T15:27:22Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-13 14:50 (new) → proposed (announced): novox/hq#346's head announced - 2026-10-13 14:51 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 14:51 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 15:27 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 15:27 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-13 14:50:10 +00:00
Design 46: a settings walk sends the layer and no build, and stops before a data move (ADR 0344 v4)
mesh/merge-gate head 732e8bd4d940 merged into trunk 471f99344b8d — pass: the change touches no module of the mesh's graph
mesh/repo-check head 732e8bd4d940 merged into trunk 471f99344b8d — pass: its merge-check.sh passed
mesh/delivery delivered
732e8bd4d9
mesh-admin left a comment
Author
Contributor

Verdict: approve at 732e8bd4d9

Independent review of the design half of issue 641 (to-be 46, ADR 0344).

Checks at this head: mesh/repo-check success (merge-check.sh passed), mesh/merge-gate success (the change touches no module of the mesh's graph), mesh/delivery success (ready: waits for its merge). No mesh/delivery-group status is set. Locally, merge-check.sh passes: records, index, cycle (436 documents) and words. The catalogue copy of the list was not compared, because MESH_CATALOG_DIR is not set.

The new section matches ADR 0344 v8 clause by clause. It covers the walk on Approve with the control node last, the layer sent with no build, a stop before a data move naming push --move, the end told as every walk's is, the layer left set on a failure, the ask's wording, a layer set by hand still waiting for a push, and applying a delivered file being the module's (issue 643). The approval-table row now says the one Approve also sends it. Frontmatter: ADR 0344 added, updated 2026-10-13. No node names, addresses or paths appear, so it is safe for a public repository.

Nits, not blocking:

  • The section leaves out ADR 0344 §6's rule that a machine not heard from is passed over, named, and takes the layer at its next send. One clause would add it.
  • 'How it is checked' could name the away-machine case, which the controller's tests do cover.
Verdict: approve at 732e8bd4d940a75b71648a27f4f5a33e17d852c2 Independent review of the design half of issue 641 (to-be 46, ADR 0344). Checks at this head: mesh/repo-check success (merge-check.sh passed), mesh/merge-gate success (the change touches no module of the mesh's graph), mesh/delivery success (ready: waits for its merge). No mesh/delivery-group status is set. Locally, merge-check.sh passes: records, index, cycle (436 documents) and words. The catalogue copy of the list was not compared, because MESH_CATALOG_DIR is not set. The new section matches ADR 0344 v8 clause by clause. It covers the walk on Approve with the control node last, the layer sent with no build, a stop before a data move naming `push --move`, the end told as every walk's is, the layer left set on a failure, the ask's wording, a layer set by hand still waiting for a push, and applying a delivered file being the module's (issue 643). The approval-table row now says the one Approve also sends it. Frontmatter: ADR 0344 added, updated 2026-10-13. No node names, addresses or paths appear, so it is safe for a public repository. Nits, not blocking: - The section leaves out ADR 0344 §6's rule that a machine not heard from is passed over, named, and takes the layer at its next send. One clause would add it. - 'How it is checked' could name the away-machine case, which the controller's tests do cover.
mesh-admin merged commit 0f5aab10b4 into main 2026-10-13 15:27:04 +00:00
mesh-admin deleted branch design/641-an-approved-setting-is-sent 2026-10-13 15:27:04 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#346