novox/hq
9
0
Fork 0
Code Issues Pull Requests 2 Releases Wiki Activity

Issue 347: a pull request opened after its push is never checked, and nothing says so #247

Merged
mesh-admin merged 2 commits from issues/347-a-pull-request-opened-after-its-push-is-never-checked into main 2026-10-09 11:38:40 +00:00
Conversation 1 Commits 2 Files Changed 1
+73
mesh-admin commented 2026-10-09 10:57:01 +00:00
Contributor
Copy Link
Copy Source

Records the announcer gap the review of ADR 0272 measured (mesh-sdk #14 never got a merge check): pollPulls looks only at repositories whose update time moved, and opening a PR does not move it. Located in modules/gitea; fixed in mesh-catalog PR fix/347-a-pull-request-opened-after-its-push-is-never-checked (search by the PR's own update time + a 10-minute sweep, a condition via ADR 0224's provider standing for a PR unchecked for 10 min, and a refusal of pulls/NaN). Number 347 checked free across main and every open branch right before the commit (344–346 taken). merge-check.sh passes locally.

Records the announcer gap the review of ADR 0272 measured (mesh-sdk #14 never got a merge check): `pollPulls` looks only at repositories whose update time moved, and opening a PR does not move it. Located in modules/gitea; fixed in mesh-catalog PR `fix/347-a-pull-request-opened-after-its-push-is-never-checked` (search by the PR's own update time + a 10-minute sweep, a condition via ADR 0224's provider standing for a PR unchecked for 10 min, and a refusal of `pulls/NaN`). Number 347 checked free across main and every open branch right before the commit (344–346 taken). `merge-check.sh` passes locally.
mesh-admin added 1 commit 2026-10-09 10:57:01 +00:00
Issue 347: a pull request opened after its push is never checked, and nothing says so
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery superseded: a newer head of the same pull request
Details
2ba0d68306 
The forge's announcer reads only repositories whose update time moved; a
pull request opened after its push does not move it. Located in the forge
module, with the fix (mesh-catalog) and how it is checked.
mesh-admin commented 2026-10-09 10:57:33 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/hq@fc449617be07 — delivered since 2026-10-09T11:39:01Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-09 11:16 (new) → proposed (announced): novox/hq#247's head announced
  • 2026-10-09 11:17 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 11:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 11:39 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 11:39 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@fc449617be07` — **delivered** since 2026-10-09T11:39:01Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-09 11:16 (new) → proposed (announced): novox/hq#247's head announced - 2026-10-09 11:17 proposed → checked (checked): the verdict names this commit - 2026-10-09 11:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 11:39 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 11:39 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-09 11:16:28 +00:00
Issue 347: a base requiring only mesh/repo-check counts, and the delivery's owner says it
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
fc449617be 
The confirmation review: hq requires only mesh/repo-check, so a watcher
that looked for mesh/merge-gate alone would never have said this
repository's own unchecked pull request. And the delivery domain's own
condition, a delivery held past its bound, says it rather than a provider
standing.
mesh-admin merged commit 6ea93e824a into main 2026-10-09 11:38:40 +00:00
mesh-admin deleted branch issues/347-a-pull-request-opened-after-its-push-is-never-checked 2026-10-09 11:38:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#247