Playbook 08: check a module compiles with go vet, never go build in its folder (issue 1577) #450

Merged
mesh-tools merged 1 commits from fix/1577-no-build-in-module into main 2026-10-21 08:02:23 +00:00
Member

Issue 1577: go build ./... in a module's folder with one main package writes the program beside go.mod, and git add -A takes it. On 2026-10-21 two programs (okioki 10 MB, mesh-config 5 MB) were committed this way and caught only by the review. Playbook 08 step 3 now says to check compiling with go vet and to read git show --stat before pushing. The merge gate refusing an added executable stays open on issue 1577.

sh merge-check.sh passes. A playbook edit of a few lines: the operator's Approve of its merge is its review (playbook 08 step 4).

Reviewed-by: operator's Approve (playbook edit, playbook 08 step 4) at 9f0b0215ae

Issue 1577: `go build ./...` in a module's folder with one main package writes the program beside go.mod, and `git add -A` takes it. On 2026-10-21 two programs (okioki 10 MB, mesh-config 5 MB) were committed this way and caught only by the review. Playbook 08 step 3 now says to check compiling with go vet and to read `git show --stat` before pushing. The merge gate refusing an added executable stays open on issue 1577. `sh merge-check.sh` passes. A playbook edit of a few lines: the operator's Approve of its merge is its review (playbook 08 step 4). Reviewed-by: operator's Approve (playbook edit, playbook 08 step 4) at 9f0b0215ae6a823aeba8c73a6942fc148c29f0c9
mesh-tools added 1 commit 2026-10-21 07:58:53 +00:00
Playbook 08: check a module compiles with go vet, never go build in its folder (issue 1577)
mesh/merge-gate head 9f0b0215ae6a merged into trunk 86fd4adf9756 — pass: the change touches no module of the mesh's graph
mesh/repo-check head 9f0b0215ae6a merged into trunk 86fd4adf9756 — pass: its merge-check.sh passed
mesh/delivery delivered
9f0b0215ae
go build in a module's folder writes the program beside go.mod, and two such programs were
committed on 2026-10-21, caught only by the review.
Author
Member

Delivery novox/hq@9f0b0215ae6a — delivered since 2026-10-21T08:02:25Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-21 07:58 (new) → proposed (announced): novox/hq#450's head announced
  • 2026-10-21 08:00 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-21 08:00 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-21 08:02 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-21 08:02 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@9f0b0215ae6a` — **delivered** since 2026-10-21T08:02:25Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-21 07:58 (new) → proposed (announced): novox/hq#450's head announced - 2026-10-21 08:00 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-21 08:00 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-21 08:02 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-21 08:02 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-tools merged commit a0ab91dcae into main 2026-10-21 08:02:23 +00:00
mesh-tools deleted branch fix/1577-no-build-in-module 2026-10-21 08:02:23 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#450