Developer definition: the manifest validator gets one predefined key list for both cases, always (issue 1585) #518

2026-11-05T01:16:18Z

mesh-tools commented

2026-11-05 01:16:18 +00:00

Why: hq #517's review noted that the checker always passes one predefined key list (the change's when the change alters it, else the trunk's), on one request carrying both cases change and trunk, while the developer definition said only "when the change alters it". A developer following the old text could validate without the list, or the trunk case against another list, and see verdicts the merge check never gives. Last open subtask of issue 1585 (ADR 0633, the take-in step).

What: one sentence in .claude/agents/mesh-developer.md, checked against judgeManifests and predefinedList in mesh-delivery's modules/mesh-delivery-checker/internal/check/manifests_judge.go at 4596fbe1.

Notes from the review, not taken in (no round): the trunk's list is, in the checker, the indexer's kept list (the trunk as the indexer last took it in); line 39 runs past the file's usual width.

go test ./... passes at the hq root.

Reviewed-by: mesh-code-reviewer@shanks at 304d17b561

https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

Why: hq #517's review noted that the checker always passes one predefined key list (the change's when the change alters it, else the trunk's), on one request carrying both cases `change` and `trunk`, while the developer definition said only "when the change alters it". A developer following the old text could validate without the list, or the trunk case against another list, and see verdicts the merge check never gives. Last open subtask of issue 1585 (ADR 0633, the take-in step). What: one sentence in `.claude/agents/mesh-developer.md`, checked against `judgeManifests` and `predefinedList` in mesh-delivery's `modules/mesh-delivery-checker/internal/check/manifests_judge.go` at 4596fbe1. Notes from the review, not taken in (no round): the trunk's list is, in the checker, the indexer's kept list (the trunk as the indexer last took it in); line 39 runs past the file's usual width. `go test ./...` passes at the hq root. Reviewed-by: mesh-code-reviewer@shanks at 304d17b5612c4f53f5c2bdcc37d65ed4148f1934 https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

mesh-tools added 1 commit 2026-11-05 01:16:18 +00:00

Developer definition: the manifest validator always gets a predefined key list, as the checker passes one

mesh/delivery merged: source.main moved to novox/hq@d1e2059dab3f

Details

mesh/check being carried to 304d17b5612c on d1e2059dab3f | from 331e5707922b

304d17b561

The review of hq #517 noted that the checker always passes the predefined key list (the change's when it alters it,
else the trunk's), while the text said only "when the change alters it" (issue 1585).

Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn

mesh-tools commented

2026-11-05 01:16:22 +00:00

Delivery novox/hq@304d17b5612c — merged since 2026-11-05T01:28:06Z

Source — source.main moved to novox/hq@d1e2059dab. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-05 01:16 (new) → proposed (announced): novox/hq#518's head announced
2026-11-05 01:16 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-05 01:28 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/hq@304d17b5612c` — **merged** since 2026-11-05T01:28:06Z **Source** — source.main moved to novox/hq@d1e2059dab3f. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-05 01:16 (new) → proposed (announced): novox/hq#518's head announced - 2026-11-05 01:16 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-05 01:28 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit d1e2059dab into main

2026-11-05 01:28:04 +00:00

mesh-tools deleted branch agents/validator-key-list

2026-11-05 01:28:04 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/hq#518