Asker rename R2: the build modules' tests read a named ask's step under its asker

Builds: design 47 G §481, §483, A-163

Claude-Session: https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h
This commit is contained in:
2026-11-12 18:37:29 +01:00
parent ec646f55ee
commit d638856768
6 changed files with 10 additions and 6 deletions
@@ -87,7 +87,11 @@ func TestTheModuleTakesADeliveryAskBeforeAnEarlierCheck(t *testing.T) {
ended := 0
states.mu.Lock()
for _, a := range []sdkstep.StepAsk{first, check} {
key, _ := sdkstep.AskStepKey("ace", a.ID)
asker := "mesh-delivery-checker" // a named ask's step is keyed under its asker, main's under its node (§481)
if a.Kind == sdkstep.AskDelivery {
asker = ""
}
key, _ := sdkstep.AskStepKey(asker, "ace", a.ID)
v := append([]sdkstep.Step(nil), states.steps[key]...)
ran[a.ID] = v
if len(v) > 0 && v[len(v)-1].State != sdkstep.StepRunning {
@@ -57,7 +57,7 @@ func TestAPulledAskRunsTheBuildAndItsKeyNamesTheReference(t *testing.T) {
ctx, stop := context.WithCancel(context.Background())
defer stop()
go p.Pull(ctx)
key, _ := sdkstep.AskStepKey("ace", a.ID)
key, _ := sdkstep.AskStepKey("", "ace", a.ID)
var step sdkstep.Step
for deadline := time.Now().Add(30 * time.Second); ; time.Sleep(5 * time.Millisecond) {
states.mu.Lock()
@@ -212,7 +212,7 @@ func TestAComposeAskIsBuiltOnceAndAnsweredOnTheBus(t *testing.T) {
if _, err := js.Publish(ctx, subject, raw); err != nil {
t.Fatal(err)
}
key, _ := sdkstep.AskStepKey("ace", a.ID)
key, _ := sdkstep.AskStepKey("", "ace", a.ID)
for deadline := time.Now().Add(90 * time.Second); time.Now().Before(deadline); time.Sleep(50 * time.Millisecond) {
states.mu.Lock()
v := states.steps[key]
@@ -111,7 +111,7 @@ func TestARunAskIsAnsweredOnTheBusAndItsProgramIsShutOff(t *testing.T) {
if _, err := js.Publish(ctx, subject, raw); err != nil {
t.Fatal(err)
}
stepKey, _ := sdkstep.AskStepKey("ace", a.ID)
stepKey, _ := sdkstep.AskStepKey("", "ace", a.ID)
var step sdkstep.Step
for deadline := time.Now().Add(60 * time.Second); time.Now().Before(deadline); time.Sleep(50 * time.Millisecond) {
states.mu.Lock()
@@ -43,7 +43,7 @@ func TestAPulledImageAskCopiesThenBuilds(t *testing.T) {
ctx, stop := context.WithCancel(context.Background())
defer stop()
go p.Pull(ctx)
key, _ := sdkstep.AskStepKey("ace", a.ID)
key, _ := sdkstep.AskStepKey("", "ace", a.ID)
var step sdkstep.Step
for deadline := time.Now().Add(3 * time.Second); ; time.Sleep(5 * time.Millisecond) {
states.mu.Lock()
@@ -70,7 +70,7 @@ func TestAPulledNodeAskRunsItsJob(t *testing.T) {
if got := strings.Join(calls, ","); got != "build_node_fetch,build_node_build,build_node_fetch,build_node_test" {
t.Errorf("calls = %s, want the delivery ask's job first, then the check's", got)
}
key, _ := sdkstep.AskStepKey("ace", build.ID)
key, _ := sdkstep.AskStepKey("", "ace", build.ID)
states.mu.Lock()
v := states.steps[key]
states.mu.Unlock()