mesh-delivery: a stop ends a shared walk only with the last delivery it carries (hq issue 459) #220

Closed
mesh-admin wants to merge 1 commits from fix/459-a-stop-stops-only-its-own into main
Contributor

Fixes novox/hq issue 459 (stopping one group member stops its whole walk, and with it unrelated deliveries that share the walk).

Where the fix sits. In mesh-delivery, not the controller. The controller's delivery-stop ends a walk whole, and it cannot end only one delivery's part of a walk: a walk is one commit's build, rolled tier by tier. What was wrong is that mesh-delivery asked for that end while other live deliveries rode the walk.

What a stop now does. Both stop paths (a group's stopInGroup and a person's stop verb) go through one endWalk. It ends the walk only when no live delivery rides it any more. A live delivery is one that follows the walk, or one that the walk's record answers and that follows it now. While one rides it, the walk goes on. The stopped delivery says so in a note on its commit (and on its merge commit), naming what the walk goes on for. A person's stop answers the same. The last stop on the walk ends it. This is the issue's first expected behaviour: the walk is stopped only when every delivery it carries is stopped. It also says the second: the others are carried on, and this is said. What the stopped delivery's change asked of the walk still builds and is sent with the walk, because one walk cannot leave one merge out.

It also removes the race from the review of #203: one pass no longer asks both deliver and delivery-stop for one walk.

Tests (issue459_test.go, foldShape from issue 445: group member B and C, a delivery in no group, on one walk plan-2):

  • TestAGroupStopLeavesAWalkThatCarriesAnotherDelivery: B is stopped by its group. plan-2 is not ended, C is let go and delivered on it, B stays stopped and says the walk goes on for C.
  • TestAPersonsStopEndsTheWalkOnlyWithItsLastDelivery: a person stops B while B and C deliver. plan-2 goes on and the answer names C. Stopping C then ends plan-2.

Both tests failed on main: plan-2 was ended in each. go vet ./..., go test -race ./... -count=1 and the words check pass.

Fixes novox/hq issue 459 (stopping one group member stops its whole walk, and with it unrelated deliveries that share the walk). **Where the fix sits.** In mesh-delivery, not the controller. The controller's `delivery-stop` ends a walk whole, and it cannot end only one delivery's part of a walk: a walk is one commit's build, rolled tier by tier. What was wrong is that mesh-delivery asked for that end while other live deliveries rode the walk. **What a stop now does.** Both stop paths (a group's `stopInGroup` and a person's `stop` verb) go through one `endWalk`. It ends the walk only when no live delivery rides it any more. A live delivery is one that follows the walk, or one that the walk's record answers and that follows it now. While one rides it, the walk goes on. The stopped delivery says so in a note on its commit (and on its merge commit), naming what the walk goes on for. A person's `stop` answers the same. The last stop on the walk ends it. This is the issue's first expected behaviour: the walk is stopped only when every delivery it carries is stopped. It also says the second: the others are carried on, and this is said. What the stopped delivery's change asked of the walk still builds and is sent with the walk, because one walk cannot leave one merge out. It also removes the race from the review of #203: one pass no longer asks both `deliver` and `delivery-stop` for one walk. **Tests** (`issue459_test.go`, foldShape from issue 445: group member B and C, a delivery in no group, on one walk `plan-2`): - `TestAGroupStopLeavesAWalkThatCarriesAnotherDelivery`: B is stopped by its group. plan-2 is not ended, C is let go and delivered on it, B stays stopped and says the walk goes on for C. - `TestAPersonsStopEndsTheWalkOnlyWithItsLastDelivery`: a person stops B while B and C deliver. plan-2 goes on and the answer names C. Stopping C then ends plan-2. Both tests failed on main: plan-2 was ended in each. `go vet ./...`, `go test -race ./... -count=1` and the words check pass.
mesh-admin added 1 commit 2026-10-11 17:39:41 +00:00
mesh-delivery: end a shared walk only with the last delivery it carries, so a stop stops only its own (hq issue 459)
mesh/merge-gate pass: builds mesh-delivery → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery stopped: the pull request closed unmerged
c0bc4b6a83
Since the merge window one walk carries every merge of its batch, and the
controller ends a walk whole: stopping one group member, or one delivery on
a person's word, ended the rollout of unrelated deliveries on the same walk.
A stop now ends the walk only when no live delivery rides it; otherwise the
walk goes on and the stopped delivery says so on its commit.
Author
Contributor

Delivery novox/mesh-catalog@c0bc4b6a835e — stopped since 2026-10-11T17:42:46Z

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Transitions

  • 2026-10-11 17:39 (new) → proposed (announced): novox/mesh-catalog#220's head announced
  • 2026-10-11 17:42 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 17:42 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 17:42 ready → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@c0bc4b6a835e` — **stopped** since 2026-10-11T17:42:46Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Transitions** - 2026-10-11 17:39 (new) → proposed (announced): novox/mesh-catalog#220's head announced - 2026-10-11 17:42 proposed → checked (checked): the verdict names this commit - 2026-10-11 17:42 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 17:42 ready → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at c0bc4b6a

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery
  • read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue459_test.go

Run by the build seat on shanks as build-1791740386878816835 (builds --log build-1791740386878816835).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:31:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T17:31:39Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery

notes:
  - modules/mesh-delivery/cmd/mesh-delivery/issue459_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 41867 strings of 678 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.012s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	2.318s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `c0bc4b6a` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue459_test.go Run by the build seat on shanks as `build-1791740386878816835` (`builds --log build-1791740386878816835`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T17:31:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T17:31:39Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery notes: - modules/mesh-delivery/cmd/mesh-delivery/issue459_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 41867 strings of 678 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.012s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 2.318s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin closed this pull request 2026-10-11 17:42:25 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#220