mesh-delivery: a stop ends a shared walk only with the last delivery it carries (hq issue 459) #220
Closed
mesh-admin
wants to merge 1 commits from
fix/459-a-stop-stops-only-its-own into main
pull from: fix/459-a-stop-stops-only-its-own
merge into: :main
:main
:fix/nats-stream-purge
:fix/47-G-start-2
:feat/47-G-join11
:fix/1966-gate-record-catalog
:pre/registry-milestone
:fix/1748-retake-and-resolver
:pin/sdk1
:fix/check-every-failure
:feat/l5-l7
:feat/l5-l7-a3
:feat/judge-once-pkgs
:fix/turn-handed-on-approve
:fix/checker-full-failure
:revert/774-l3
:fix/check-names-every-conflict
:fix/check-speed
:probe/1126-seed-10
:probe/1126-seed-9
:probe/1126-seed-8
:probe/1126-seed-7
:probe/1126-seed-6
:probe/1126-seed-5
:feat/1126-seed-4
:revert/1126-seed-2
:feat/774-vault-mints
:fix/1901-node-test-cause
:fix/1945-adopt-hashes
:fix/1945-vault-hashing
:feat/try-speed
:fix/1921-every-failure
:feat/r4g-finish-composer
:feat/r4g-finish-1935
:fix/1901
:fix/forge-requires-no-status
:feat/mail-list
:feat/modules-name-no-node
:fix/r4e-r2
:fix/r4e-k2
:fix/r4e-k1
:feat/r4e-leaf
:feat/r4e-buildmods
:feat/r4e-gate
:fix/1106-sdk-member-merges
:feat/r4c5-checker
:fix/xterm-config-defaults
:fix/1165-fill-retry
:feat/r4d-automx-go
:feat/r4d-n8n
:fix/1275-group-merges-whole-or-not
:fix/1129-no-drift-pass
:fix/270-nats-emits-bus-faults
:fix/claude-code-tips-preference
:fix/628-modules-declare-every-package-they-need
:fix/613-home-network-shares
:feat/bus-websocket-listener
:fix/340-tool-servers-only-from-the-terminal
:feat/the-store-collects-nightly-again
:feat/dbus-module
No Reviewers
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
agent-ace
agent-g14
agent-novox
agent-shanks
jschoubben
mesh-tools
miel.truyen
nox-agent
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: novox/mesh-catalog#220
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes novox/hq issue 459 (stopping one group member stops its whole walk, and with it unrelated deliveries that share the walk).
Where the fix sits. In mesh-delivery, not the controller. The controller's
delivery-stopends a walk whole, and it cannot end only one delivery's part of a walk: a walk is one commit's build, rolled tier by tier. What was wrong is that mesh-delivery asked for that end while other live deliveries rode the walk.What a stop now does. Both stop paths (a group's
stopInGroupand a person'sstopverb) go through oneendWalk. It ends the walk only when no live delivery rides it any more. A live delivery is one that follows the walk, or one that the walk's record answers and that follows it now. While one rides it, the walk goes on. The stopped delivery says so in a note on its commit (and on its merge commit), naming what the walk goes on for. A person'sstopanswers the same. The last stop on the walk ends it. This is the issue's first expected behaviour: the walk is stopped only when every delivery it carries is stopped. It also says the second: the others are carried on, and this is said. What the stopped delivery's change asked of the walk still builds and is sent with the walk, because one walk cannot leave one merge out.It also removes the race from the review of #203: one pass no longer asks both
deliveranddelivery-stopfor one walk.Tests (
issue459_test.go, foldShape from issue 445: group member B and C, a delivery in no group, on one walkplan-2):TestAGroupStopLeavesAWalkThatCarriesAnotherDelivery: B is stopped by its group. plan-2 is not ended, C is let go and delivered on it, B stays stopped and says the walk goes on for C.TestAPersonsStopEndsTheWalkOnlyWithItsLastDelivery: a person stops B while B and C deliver. plan-2 goes on and the answer names C. Stopping C then ends plan-2.Both tests failed on main: plan-2 was ended in each.
go vet ./...,go test -race ./... -count=1and the words check pass.Delivery
novox/mesh-catalog@c0bc4b6a835e— stopped since 2026-10-11T17:42:46ZDelivery plan — builds mesh-delivery → novox; no bus step
Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.Merge check at
c0bc4b6amesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)Delivery plan — builds mesh-delivery → novox; no bus step
Run by the build seat on shanks as
build-1791740386878816835(builds --log build-1791740386878816835).Pull request closed