mesh-delivery: a stop a later merge covered reads covered, and stays in deliveries while stalled lists it (hq issue 480) #242

Merged
mesh-admin merged 2 commits from fix/480-a-covered-stop-reads-covered into main 2026-10-12 11:56:11 +00:00
Contributor

Fixes points 1 and 3 of novox/hq issue 480. Point 2 (an acknowledge verb with who and why) is not built here: the triage says it needs a decision.

Cause. A delivery stopped because its walk ended done before its word without building its modules (issue 474) is still read for a later merge that covers it (holder.go, the strandedUncovered branch of plan()). When one did, only CoveredBy was set and kept: nothing was owed to the forge, and statusOf (effects.go) mapped every stopped to error: stopped: …. Deliveries (verbs.go) hid every final delivery after a day, while Stalled keeps listing an uncovered stranded stop.

Change.

  • Covered is a reading of the stop, not a transition: stopped is final in the table and nothing moves it, as a covered superseded member stays superseded (issue 442). coveredStop() is true only for stopped + Stranded + CoveredBy, where CoveredBy comes from ADR 0270's full cover test.
  • For such a stop, the mesh/delivery status says success covered after its stop: a later merge that contains it was delivered: <merge>; the view and show (field reads) say the same; a note line is appended on its head and its merge commit. This is told once (CoverTold, kept), so a restart, or a stop covered before this was built, is told from what is kept.
  • deliveries keeps a final delivery that stalled lists, marks it stalled, and says what it waits for.

Tests (issue480_test.go). Three fail on main: the status after a cover, the status after a restart over a stop covered before, and deliveries past a day. One guard test checks that a person's stop, or an uncovered stranded stop, keeps its error.

go vet, go test -race, and merge-check.sh with MESH_CHECK_MODULES=modules/mesh-delivery pass locally. The controller's module check did not run locally because no controller was built beside the check.

Not changed: a group whose member is a covered stop still reads stopped (GroupState). Issue 480 does not ask for that.

Fixes points 1 and 3 of novox/hq issue 480. Point 2 (an acknowledge verb with who and why) is not built here: the triage says it needs a decision. **Cause.** A delivery stopped because its walk ended done before its word without building its modules (issue 474) is still read for a later merge that covers it (`holder.go`, the `strandedUncovered` branch of `plan()`). When one did, only `CoveredBy` was set and kept: nothing was owed to the forge, and `statusOf` (`effects.go`) mapped every `stopped` to `error: stopped: …`. `Deliveries` (`verbs.go`) hid every final delivery after a day, while `Stalled` keeps listing an uncovered stranded stop. **Change.** - Covered is a reading of the stop, not a transition: `stopped` is final in the table and nothing moves it, as a covered superseded member stays superseded (issue 442). `coveredStop()` is true only for `stopped` + `Stranded` + `CoveredBy`, where `CoveredBy` comes from ADR 0270's full cover test. - For such a stop, the `mesh/delivery` status says `success covered after its stop: a later merge that contains it was delivered: <merge>`; the view and `show` (field `reads`) say the same; a note line is appended on its head and its merge commit. This is told once (`CoverTold`, kept), so a restart, or a stop covered before this was built, is told from what is kept. - `deliveries` keeps a final delivery that `stalled` lists, marks it stalled, and says what it waits for. **Tests** (`issue480_test.go`). Three fail on main: the status after a cover, the status after a restart over a stop covered before, and `deliveries` past a day. One guard test checks that a person's stop, or an uncovered stranded stop, keeps its error. `go vet`, `go test -race`, and `merge-check.sh` with `MESH_CHECK_MODULES=modules/mesh-delivery` pass locally. The controller's module check did not run locally because no controller was built beside the check. Not changed: a group whose member is a covered stop still reads `stopped` (`GroupState`). Issue 480 does not ask for that.
mesh-admin added 2 commits 2026-10-12 11:47:11 +00:00
A stop for a walk that never built its modules (issue 474) kept saying "error: stopped" on the forge and in
show after a later delivered merge carried its change to every machine. The stop stays final, as a covered
superseded member stays superseded (issue 442); its status, view, note and show now say covered and by which
merge, told once and from what is kept, so a restart or a stop covered before this tells it too. deliveries
dropped such a stop after a day while stalled still listed it; it now lists it as long as stalled does.

novox/hq issue 480, points 1 and 3.
Say in the deliveries verb's description that a stop stalled lists stays listed
mesh/merge-gate pass: builds mesh-delivery → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
7ad54356fd
Author
Contributor

Delivery novox/mesh-catalog@7ad54356fd25 — delivered since 2026-10-12T12:06:42Z

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Machines

  • route-proxy on ace: passed — carried by plan-1791805651201498587
  • mesh-delivery on novox: passed — healthy 3 times over 2m9s
  • mesh-delivery on the rest running it: sent

Transitions

  • 2026-10-12 11:47 (new) → proposed (announced): novox/mesh-catalog#242's head announced
  • 2026-10-12 11:49 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 11:49 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 12:02 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 12:02 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 12:06 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@7ad54356fd25` — **delivered** since 2026-10-12T12:06:42Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Machines** - route-proxy on ace: passed — carried by plan-1791805651201498587 - mesh-delivery on novox: passed — healthy 3 times over 2m9s - mesh-delivery on the rest running it: sent **Transitions** - 2026-10-12 11:47 (new) → proposed (announced): novox/mesh-catalog#242's head announced - 2026-10-12 11:49 proposed → checked (checked): the verdict names this commit - 2026-10-12 11:49 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 12:02 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 12:02 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 12:06 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 7ad54356

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery
  • read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue480_test.go

Run by the build seat on shanks as build-1791805643802273506 (builds --log build-1791805643802273506).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T11:40:33Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T11:40:33Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery

notes:
  - modules/mesh-delivery/cmd/mesh-delivery/issue480_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 43153 strings of 690 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.012s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.408s
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	3.101s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `7ad54356` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue480_test.go Run by the build seat on shanks as `build-1791805643802273506` (`builds --log build-1791805643802273506`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T11:40:33Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T11:40:33Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery notes: - modules/mesh-delivery/cmd/mesh-delivery/issue480_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 43153 strings of 690 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.012s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.408s testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 3.101s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit d1baca9b94 into main 2026-10-12 11:56:11 +00:00
mesh-admin deleted branch fix/480-a-covered-stop-reads-covered 2026-10-12 11:56:12 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#242