Follows #266 (issue 238, hq ADR 0339). Its walk fails on ace.
Symptom: on ace, fail2ban_health says "the jail(s) recidive, route-proxy, sshd do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". Yet fail2ban_settings for sshd on ace shows the entry, as file://var/lib/mesh-fail2ban/own-addresses.
Cause: fail2ban 1.1 reads file:/var/lib/… and prints it back as file://var/lib/… (server/ipdns.py, FileIPAddrSet.__repr__ is 'file:' + '/' + fileName). The watch compared the literal text. The same form is the by … source in the daemon's Ignore <address> by … log lines, so #266 would also never have counted a failure from the operator's own address: the warning of ADR 0339 §4 could not fire.
Fix:isOurList compares the path after file:, with the slashes read as fail2ban reads them, both in the jails' ignore lists and in the log lines.
Tests:ignoring and the log lines now use fail2ban's real file://var/lib/… form, plus TestTheListIsKnownInTheFormFail2banPrintsItBack, which covers both forms and near misses. On main's own.go and watch.go, TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLast and TestAJailThatLeavesTheListOutABadEntryAndAStoppedWatchAreSaid fail. With the fix all pass under -race. MESH_GATE=<controller from mesh-controller main 1826b68> MESH_CHECK_MODULES=fail2ban sh merge-check.sh exits 0.
Reviewers' checklist: after delivery, ace/fail2ban.fail2ban_health is healthy and names every jail. Nothing is banned or unbanned live. Only the comparison changed: no manifest change.
Follows #266 (issue 238, hq ADR 0339). Its walk fails on ace.
**Symptom:** on ace, `fail2ban_health` says "the jail(s) recidive, route-proxy, sshd do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". Yet `fail2ban_settings` for sshd on ace shows the entry, as `file://var/lib/mesh-fail2ban/own-addresses`.
**Cause:** fail2ban 1.1 reads `file:/var/lib/…` and prints it back as `file://var/lib/…` (server/ipdns.py, `FileIPAddrSet.__repr__` is `'file:' + '/' + fileName`). The watch compared the literal text. The same form is the `by …` source in the daemon's `Ignore <address> by …` log lines, so #266 would also never have counted a failure from the operator's own address: the warning of ADR 0339 §4 could not fire.
**Fix:** `isOurList` compares the path after `file:`, with the slashes read as fail2ban reads them, both in the jails' ignore lists and in the log lines.
**Tests:** `ignoring` and the log lines now use fail2ban's real `file://var/lib/…` form, plus `TestTheListIsKnownInTheFormFail2banPrintsItBack`, which covers both forms and near misses. On main's own.go and watch.go, `TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLast` and `TestAJailThatLeavesTheListOutABadEntryAndAStoppedWatchAreSaid` fail. With the fix all pass under -race. `MESH_GATE=<controller from mesh-controller main 1826b68> MESH_CHECK_MODULES=fail2ban sh merge-check.sh` exits 0.
**Reviewers' checklist:** after delivery, `ace/fail2ban.fail2ban_health` is healthy and names every jail. Nothing is banned or unbanned live. Only the comparison changed: no manifest change.
mesh/merge-gate head c78d0a01342c merged into trunk f35b06750452 — pass: builds fail2ban → ace, g14, novox, shanks; no bus step; every machine composes wit…
mesh/repo-check head c78d0a01342c merged into trunk f35b06750452 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
fail2ban reads the ignoreip entry file:/var/lib/... and prints it back as file://var/lib/...,
in get <jail> ignoreip and in its "Ignore ... by ..." log lines alike. The watch compared the
text, so on ace it said every jail lacked the list while each held it, failing fail2ban's health
and its walk; and it would never have counted a failure from the operator's own address. Compare
the path instead, with a test on fail2ban's real form.
Deliverynovox/mesh-catalog@c78d0a01342c — delivered since 2026-10-13T09:23:37Z
Delivery plan — builds fail2ban → ace, g14, novox, shanks; no bus step
tier 0: fail2ban
ace: receives fail2ban
g14: receives fail2ban
novox: receives fail2ban
shanks: receives fail2ban
grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before fail2ban is judged on its first machine
Machines
fail2ban on ace: passed — healthy 1 times over 1m50s
fail2ban on the rest running it: sent
Transitions
2026-10-13 09:14 (new) → proposed (announced): novox/mesh-catalog#267's head announced
2026-10-13 09:17 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
2026-10-13 09:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-13 09:19 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-13 09:19 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
2026-10-13 09:23 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says
The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.
<!-- mesh-delivery:view -->
**Delivery** `novox/mesh-catalog@c78d0a01342c` — **delivered** since 2026-10-13T09:23:37Z
**Delivery plan** — builds fail2ban → ace, g14, novox, shanks; no bus step
- tier 0: fail2ban
- ace: receives fail2ban
- g14: receives fail2ban
- novox: receives fail2ban
- shanks: receives fail2ban
- grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before fail2ban is judged on its first machine
**Machines**
- fail2ban on ace: passed — healthy 1 times over 1m50s
- fail2ban on the rest running it: sent
**Transitions**
- 2026-10-13 09:14 (new) → proposed (announced): novox/mesh-catalog#267's head announced
- 2026-10-13 09:17 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
- 2026-10-13 09:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
- 2026-10-13 09:19 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
- 2026-10-13 09:19 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
- 2026-10-13 09:23 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says
The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Merge check at c78d0a01
Judged: head c78d0a01342c merged into trunk f35b06750452; read beside it: mesh-controller 1826b68a22b5, mesh-controller-main 1826b68a22b5, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9
mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)
mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
Delivery plan — builds fail2ban → ace, g14, novox, shanks; no bus step
tier 0: fail2ban
ace: receives fail2ban
g14: receives fail2ban
novox: receives fail2ban
shanks: receives fail2ban
grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before fail2ban is judged on its first machine
read by no module's build: modules/fail2ban/cmd/fail2ban-tools/own_test.go
Run by the build seat on ace as build-1791882893378798929 (builds --log build-1791882893378798929).
--- the gate: fail2ban
fail2ban: ok, 2 tool(s), ready: watch by its tool fail2ban_health every 1m0s; run by unit every 30s
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T09:09:10Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T09:09:10Z
machines:
- a machine (f35): composes
- holds mesh-dns-resolver (idt): composes
- holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
- a machine (yvbpsm): composes
a merge would rebuild 1 module(s) in 1 tier(s): fail2ban
notes:
- modules/fail2ban/cmd/fail2ban-tools/own_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok git.novox.be/novox/mesh-catalog/checks/words 0.003s
words: 12 retired words and 70 daemons' lines, none in the 46219 strings of 714 files
ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.011s
agent-home: no archive and no file written into under the agent's home
ok git.novox.be/novox/mesh-catalog/checks/secrets 0.011s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 66, as kept
ok git.novox.be/novox/mesh-catalog/checks/deps 0.204s
testing modules/fail2ban
ok fail2ban/cmd/fail2ban-tools 1.029s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `c78d0a01`
Judged: head `c78d0a01342c` merged into trunk `f35b06750452`; read beside it: mesh-controller `1826b68a22b5`, mesh-controller-main `1826b68a22b5`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9`
- `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)
- `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
**Delivery plan** — builds fail2ban → ace, g14, novox, shanks; no bus step
- tier 0: fail2ban
- ace: receives fail2ban
- g14: receives fail2ban
- novox: receives fail2ban
- shanks: receives fail2ban
- grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before fail2ban is judged on its first machine
- read by no module's build: modules/fail2ban/cmd/fail2ban-tools/own_test.go
Run by the build seat on ace as `build-1791882893378798929` (`builds --log build-1791882893378798929`).
```
--- the gate: fail2ban
fail2ban: ok, 2 tool(s), ready: watch by its tool fail2ban_health every 1m0s; run by unit every 30s
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T09:09:10Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T09:09:10Z
machines:
- a machine (f35): composes
- holds mesh-dns-resolver (idt): composes
- holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
- a machine (yvbpsm): composes
a merge would rebuild 1 module(s) in 1 tier(s): fail2ban
notes:
- modules/fail2ban/cmd/fail2ban-tools/own_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok git.novox.be/novox/mesh-catalog/checks/words 0.003s
words: 12 retired words and 70 daemons' lines, none in the 46219 strings of 714 files
ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.011s
agent-home: no archive and no file written into under the agent's home
ok git.novox.be/novox/mesh-catalog/checks/secrets 0.011s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 66, as kept
ok git.novox.be/novox/mesh-catalog/checks/deps 0.204s
testing modules/fail2ban
ok fail2ban/cmd/fail2ban-tools 1.029s
--- its merge-check-typescript.sh (typescript toolchain)
```
This follows my approval of #266 (now merged into main at f35b067), whose live gate failed on ace with exactly the symptom the coordinator described.
Does it compare paths, accepting both forms? Yes. own.go's new isOurList cuts the "file:" prefix, trims every leading slash from what remains, and re-adds exactly one before comparing to ListFile. I checked this against fail2ban 1.1's real behaviour (server/ipdns.py FileIPAddrSet.repr, cited in the comment): a single-slash entry (file:/var/lib/mesh-fail2ban/own-addresses, as the module writes it) and the double-slash form fail2ban prints back (file://var/lib/mesh-fail2ban/own-addresses) both normalise to the same path. watch.go's two call sites (the per-jail ignoreip check and the log-line match) both now go through isOurList/namesOurList instead of the literal IgnoredBy equality. I grepped the whole module for other literal comparisons: client.go (the ban verb's own spared() refusal) has none — it parses ignoreip entries as addresses/prefixes via entry(), which already discards any "file:..." word regardless of slash count, so the ban path was never affected by this bug. The only remaining literal use of IgnoredBy is in a human-readable warning string, not a comparison.
Do the tests use fail2ban's real file:// form, fail on main and pass at the head? Yes. own_test.go's fixtures now use asPrinted = "file://var/lib/mesh-fail2ban/own-addresses" (the double-slash form, noted as seen live on ace on 2026-10-13) in the ignoreip listing fixture and in the log lines, and the new TestTheListIsKnownInTheFormFail2banPrintsItBack checks isOurList against the single-slash, double-slash and triple-slash forms (all true) and against near misses — a bare path with no "file:" prefix, a different filename (.../other), a suffixed one (...own-addresses.new), a CIDR, and the daemon's "ip" source (all false) — and also checks namesOurList against the full fixture listing. I reproduced the fail/pass split myself, nice -n 15 with GOFLAGS=-p=2: copying only the updated own_test.go onto main (f35b067, which already has #266) fails to build ("undefined: isOurList", "undefined: namesOurList"); stripping just that one new test and keeping the two modified pre-existing tests against main's own.go/watch.go reproduces the live symptom exactly — TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLast fails with "the jail(s) gitea, recidive do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". At the head, go build ./... is clean and go test ./... -race passes all 18 tests including the new one.
Does merge-check.sh pass? Yes. Gitea's own checks on this head are green: mesh/merge-gate "PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)", and mesh/repo-check "PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)". The posted log confirms "ok fail2ban/cmd/fail2ban-tools 1.029s", "long-running resources without health: 66, as kept" and "files asking for a setting without saying whether it is trusted: 0" — unchanged from #266, confirming the manifest itself was not touched, as the PR states.
I found nothing else in the module comparing that string literally, and no manifest change. I banned and unbanned nothing on any machine.
Verdict: approve at c78d0a01342c6c83608c3ae9e6737d7247c79893
This follows my approval of #266 (now merged into main at f35b067), whose live gate failed on ace with exactly the symptom the coordinator described.
Does it compare paths, accepting both forms? Yes. own.go's new isOurList cuts the "file:" prefix, trims every leading slash from what remains, and re-adds exactly one before comparing to ListFile. I checked this against fail2ban 1.1's real behaviour (server/ipdns.py FileIPAddrSet.__repr__, cited in the comment): a single-slash entry (file:/var/lib/mesh-fail2ban/own-addresses, as the module writes it) and the double-slash form fail2ban prints back (file://var/lib/mesh-fail2ban/own-addresses) both normalise to the same path. watch.go's two call sites (the per-jail ignoreip check and the log-line match) both now go through isOurList/namesOurList instead of the literal IgnoredBy equality. I grepped the whole module for other literal comparisons: client.go (the ban verb's own spared() refusal) has none — it parses ignoreip entries as addresses/prefixes via entry(), which already discards any "file:..." word regardless of slash count, so the ban path was never affected by this bug. The only remaining literal use of IgnoredBy is in a human-readable warning string, not a comparison.
Do the tests use fail2ban's real file:// form, fail on main and pass at the head? Yes. own_test.go's fixtures now use asPrinted = "file://var/lib/mesh-fail2ban/own-addresses" (the double-slash form, noted as seen live on ace on 2026-10-13) in the ignoreip listing fixture and in the log lines, and the new TestTheListIsKnownInTheFormFail2banPrintsItBack checks isOurList against the single-slash, double-slash and triple-slash forms (all true) and against near misses — a bare path with no "file:" prefix, a different filename (.../other), a suffixed one (...own-addresses.new), a CIDR, and the daemon's "ip" source (all false) — and also checks namesOurList against the full fixture listing. I reproduced the fail/pass split myself, nice -n 15 with GOFLAGS=-p=2: copying only the updated own_test.go onto main (f35b067, which already has #266) fails to build ("undefined: isOurList", "undefined: namesOurList"); stripping just that one new test and keeping the two modified pre-existing tests against main's own.go/watch.go reproduces the live symptom exactly — TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLast fails with "the jail(s) gitea, recidive do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". At the head, go build ./... is clean and go test ./... -race passes all 18 tests including the new one.
Does merge-check.sh pass? Yes. Gitea's own checks on this head are green: mesh/merge-gate "PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)", and mesh/repo-check "PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)". The posted log confirms "ok fail2ban/cmd/fail2ban-tools 1.029s", "long-running resources without health: 66, as kept" and "files asking for a setting without saying whether it is trusted: 0" — unchanged from #266, confirming the manifest itself was not touched, as the PR states.
I found nothing else in the module comparing that string literally, and no manifest change. I banned and unbanned nothing on any machine.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follows #266 (issue 238, hq ADR 0339). Its walk fails on ace.
Symptom: on ace,
fail2ban_healthsays "the jail(s) recidive, route-proxy, sshd do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". Yetfail2ban_settingsfor sshd on ace shows the entry, asfile://var/lib/mesh-fail2ban/own-addresses.Cause: fail2ban 1.1 reads
file:/var/lib/…and prints it back asfile://var/lib/…(server/ipdns.py,FileIPAddrSet.__repr__is'file:' + '/' + fileName). The watch compared the literal text. The same form is theby …source in the daemon'sIgnore <address> by …log lines, so #266 would also never have counted a failure from the operator's own address: the warning of ADR 0339 §4 could not fire.Fix:
isOurListcompares the path afterfile:, with the slashes read as fail2ban reads them, both in the jails' ignore lists and in the log lines.Tests:
ignoringand the log lines now use fail2ban's realfile://var/lib/…form, plusTestTheListIsKnownInTheFormFail2banPrintsItBack, which covers both forms and near misses. On main's own.go and watch.go,TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLastandTestAJailThatLeavesTheListOutABadEntryAndAStoppedWatchAreSaidfail. With the fix all pass under -race.MESH_GATE=<controller from mesh-controller main 1826b68> MESH_CHECK_MODULES=fail2ban sh merge-check.shexits 0.Reviewers' checklist: after delivery,
ace/fail2ban.fail2ban_healthis healthy and names every jail. Nothing is banned or unbanned live. Only the comparison changed: no manifest change.Delivery
novox/mesh-catalog@c78d0a01342c— delivered since 2026-10-13T09:23:37ZDelivery plan — builds fail2ban → ace, g14, novox, shanks; no bus step
Machines
Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.Merge check at
c78d0a01Judged: head
c78d0a01342cmerged into trunkf35b06750452; read beside it: mesh-controller1826b68a22b5, mesh-controller-main1826b68a22b5, mesh-host7a41e120635b, mesh-tools954e1a53eef9mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)Delivery plan — builds fail2ban → ace, g14, novox, shanks; no bus step
Run by the build seat on ace as
build-1791882893378798929(builds --log build-1791882893378798929).Verdict: approve at
c78d0a0134This follows my approval of #266 (now merged into main at
f35b067), whose live gate failed on ace with exactly the symptom the coordinator described.Does it compare paths, accepting both forms? Yes. own.go's new isOurList cuts the "file:" prefix, trims every leading slash from what remains, and re-adds exactly one before comparing to ListFile. I checked this against fail2ban 1.1's real behaviour (server/ipdns.py FileIPAddrSet.repr, cited in the comment): a single-slash entry (file:/var/lib/mesh-fail2ban/own-addresses, as the module writes it) and the double-slash form fail2ban prints back (file://var/lib/mesh-fail2ban/own-addresses) both normalise to the same path. watch.go's two call sites (the per-jail ignoreip check and the log-line match) both now go through isOurList/namesOurList instead of the literal IgnoredBy equality. I grepped the whole module for other literal comparisons: client.go (the ban verb's own spared() refusal) has none — it parses ignoreip entries as addresses/prefixes via entry(), which already discards any "file:..." word regardless of slash count, so the ban path was never affected by this bug. The only remaining literal use of IgnoredBy is in a human-readable warning string, not a comparison.
Do the tests use fail2ban's real file:// form, fail on main and pass at the head? Yes. own_test.go's fixtures now use asPrinted = "file://var/lib/mesh-fail2ban/own-addresses" (the double-slash form, noted as seen live on ace on 2026-10-13) in the ignoreip listing fixture and in the log lines, and the new TestTheListIsKnownInTheFormFail2banPrintsItBack checks isOurList against the single-slash, double-slash and triple-slash forms (all true) and against near misses — a bare path with no "file:" prefix, a different filename (.../other), a suffixed one (...own-addresses.new), a CIDR, and the daemon's "ip" source (all false) — and also checks namesOurList against the full fixture listing. I reproduced the fail/pass split myself, nice -n 15 with GOFLAGS=-p=2: copying only the updated own_test.go onto main (
f35b067, which already has #266) fails to build ("undefined: isOurList", "undefined: namesOurList"); stripping just that one new test and keeping the two modified pre-existing tests against main's own.go/watch.go reproduces the live symptom exactly — TestAFailureIgnoredFromTheOperatorsOwnAddressIsSaidUntilADayAfterTheLast fails with "the jail(s) gitea, recidive do not ignore the operator's own addresses: their ignore list lacks file:/var/lib/mesh-fail2ban/own-addresses". At the head, go build ./... is clean and go test ./... -race passes all 18 tests including the new one.Does merge-check.sh pass? Yes. Gitea's own checks on this head are green: mesh/merge-gate "PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: fail2ban)", and mesh/repo-check "PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)". The posted log confirms "ok fail2ban/cmd/fail2ban-tools 1.029s", "long-running resources without health: 66, as kept" and "files asking for a setting without saying whether it is trusted: 0" — unchanged from #266, confirming the manifest itself was not touched, as the PR states.
I found nothing else in the module comparing that string literally, and no manifest change. I banned and unbanned nothing on any machine.