checks/words: a retired word's plural is the word (hq ADR 0244) #112

Merged
mesh-admin merged 1 commits from fix/words-match-plurals into main 2026-10-07 19:21:35 +00:00
Contributor

checks/words ended the match at the word itself, so a plural passed: "control planes" and "flavors" were fine while "control plane" and "flavor" were retired. hq's words.py had the same flaw and is fixed in novox/hq#176.

  • The pattern now accepts s or es on the last part of the word. Anything else joined on is still another word, so "flavored" and "mesh-console-x" do not match.
  • checks/words/main_test.go covers the change. It fails on the old pattern for three of its cases and passes on the new one.
  • merge-check.sh now runs that test before it runs the check.
  • Run over every module, the new pattern finds nothing: 12 retired words, none in the 27409 strings of 510 files.

Checks: sh merge-check.sh passes locally. The manifests were not checked, because no controller is built beside this check.

`checks/words` ended the match at the word itself, so a plural passed: "control planes" and "flavors" were fine while "control plane" and "flavor" were retired. hq's `words.py` had the same flaw and is fixed in novox/hq#176. - The pattern now accepts `s` or `es` on the last part of the word. Anything else joined on is still another word, so "flavored" and "mesh-console-x" do not match. - `checks/words/main_test.go` covers the change. It fails on the old pattern for three of its cases and passes on the new one. - `merge-check.sh` now runs that test before it runs the check. - Run over every module, the new pattern finds nothing: 12 retired words, none in the 27409 strings of 510 files. Checks: `sh merge-check.sh` passes locally. The manifests were not checked, because no controller is built beside this check.
mesh-admin added 1 commit 2026-10-07 19:08:40 +00:00
Hold a retired word's plural to the word in what the tools say (hq ADR 0244)
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
mesh/delivery-group group fix/words-match-plurals merged: every member is merged
362974244e
The pattern ended at the word, so control planes and flavors passed where
control plane and flavor fail. It now takes s or es on the last part; a
test holds it, and merge-check runs that test before the check.
Author
Contributor

Delivery novox/mesh-catalog@362974244ebc — delivered since 2026-10-07T19:21:44Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Group fix/words-match-plurals, in order: novox/hq@4b36234c9b → novox/mesh-catalog@362974244e

  • composed together: pass — the change touches no module of the mesh's graph

Transitions

  • 2026-10-07 19:09 (new) → proposed (announced): novox/mesh-catalog#112's head announced
  • 2026-10-07 19:09 proposed → checked (checked): the verdict names this commit
  • 2026-10-07 19:09 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-07 19:21 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-07 19:21 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@362974244ebc` — **delivered** since 2026-10-07T19:21:44Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Group** `fix/words-match-plurals`, in order: novox/hq@4b36234c9b13 → novox/mesh-catalog@362974244ebc - composed together: pass — the change touches no module of the mesh's graph **Transitions** - 2026-10-07 19:09 (new) → proposed (announced): novox/mesh-catalog#112's head announced - 2026-10-07 19:09 proposed → checked (checked): the verdict names this commit - 2026-10-07 19:09 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-07 19:21 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-07 19:21 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin merged commit 942f82f239 into main 2026-10-07 19:21:35 +00:00
mesh-admin deleted branch fix/words-match-plurals 2026-10-07 19:21:36 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#112