The catalogue's check type-checks and tests every touched TypeScript module #151

Merged
mesh-admin merged 3 commits from check/typescript-modules-tested into main 2026-10-09 07:29:36 +00:00
Contributor

Why. merge-check.sh runs in the Go toolchain and said "NOT TESTED HERE" for every TypeScript module. A change to the forge module (#150's gitea_contains) would first meet the compiler in its walk. This is the catalogue's twin of hq issue 311 (the media catalogue).

What. merge-check-typescript.sh, declared as # mesh-check-also: typescript merge-check-typescript.sh, runs in the TypeScript toolchain. It takes every touched module: the planner's MESH_CHECK_MODULES, plus the modules any changed file is in, because a change to a module's tests alone moves no build (ADR 0267) but must still run them. For each module with a package.json, working on a copy outside the clone:

  • dependencies are the toolchain's own /app/node_modules (the mesh SDK, @types/node, nats…), copied beside the copy and never fetched, because the check holds no registry credential. A module that needs a package the toolchain lacks is said NOT CHECKED: … depends on X;
  • type-check: tsc --noEmit over every source that is not a test, with the build's flags;
  • tests: test/*.test.ts run under node --test --experimental-strip-types, after the module is compiled to dist/ and in place, as its own npm test does after its build;
  • a module with no tests is said NOT TESTED.

Run over all 34 TypeScript modules on main, in the toolchain image mesh-tools-build:01c98db0:

  • 10 tested green: audit-logger, home-assistant, influxdb, mesh-vault, mosquitto, netcheck, nodered, powerlevel10k, route-adapter, zsh.
  • 17 type-check green, with no tests to run.
  • 4 NOT CHECKED: they depend on pg, mongodb or mssql.
  • 3 red:
    • gitea: its token test's expected tool list was stale. Fixed in #150.
    • nftables: remove.test.ts expects sudo, and the check runs as root.
    • showcase: type errors against the current SDK (provisioner, tool).

Only touched modules run, so nftables and showcase fail only when a change touches them. Each needs its own fix.

On the seat. This PR's own repo-check passed with main's check ("THE CHANGE ALTERS ITS OWN CHECK", hq issue 310). #150 is stacked on this branch, so the seat already ran this part on #150. Its build-1791509353373266855 type-checked gitea and passed its 32 tests.

Merge order. Merge this first; #150 then retargets to main. Do not merge before the operator's word.

**Why.** `merge-check.sh` runs in the Go toolchain and said "NOT TESTED HERE" for every TypeScript module. A change to the forge module (#150's `gitea_contains`) would first meet the compiler in its walk. This is the catalogue's twin of hq issue 311 (the media catalogue). **What.** `merge-check-typescript.sh`, declared as `# mesh-check-also: typescript merge-check-typescript.sh`, runs in the TypeScript toolchain. It takes every touched module: the planner's `MESH_CHECK_MODULES`, plus the modules any changed file is in, because a change to a module's tests alone moves no build (ADR 0267) but must still run them. For each module with a package.json, working on a copy outside the clone: - **dependencies** are the toolchain's own `/app/node_modules` (the mesh SDK, `@types/node`, nats…), copied beside the copy and never fetched, because the check holds no registry credential. A module that needs a package the toolchain lacks is said `NOT CHECKED: … depends on X`; - **type-check:** `tsc --noEmit` over every source that is not a test, with the build's flags; - **tests:** `test/*.test.ts` run under `node --test --experimental-strip-types`, after the module is compiled to `dist/` and in place, as its own `npm test` does after its build; - a module with no tests is said `NOT TESTED`. **Run over all 34 TypeScript modules on main, in the toolchain image `mesh-tools-build:01c98db0`:** - **10 tested green:** audit-logger, home-assistant, influxdb, mesh-vault, mosquitto, netcheck, nodered, powerlevel10k, route-adapter, zsh. - **17 type-check green, with no tests to run.** - **4 NOT CHECKED:** they depend on pg, mongodb or mssql. - **3 red:** - gitea: its token test's expected tool list was stale. Fixed in #150. - nftables: `remove.test.ts` expects `sudo`, and the check runs as root. - showcase: type errors against the current SDK (`provisioner`, `tool`). Only touched modules run, so nftables and showcase fail only when a change touches them. Each needs its own fix. **On the seat.** This PR's own repo-check passed with main's check ("THE CHANGE ALTERS ITS OWN CHECK", hq issue 310). #150 is stacked on this branch, so the seat already ran this part on #150. Its build-1791509353373266855 type-checked gitea and passed its 32 tests. **Merge order.** Merge this first; #150 then retargets to main. Do not merge before the operator's word.
mesh-admin added 1 commit 2026-10-09 01:22:35 +00:00
Type-check and test every touched TypeScript module before it merges
mesh/delivery superseded: a newer head of the same pull request
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
f072ca7297
The catalogue's check ran only Go. A TypeScript module's change, the forge's among them, ran nothing of
its own before it merged, and a type error would first have shown in its walk. A second part, declared
with mesh-check-also and run in the TypeScript toolchain, type-checks each touched TypeScript module with
the compiler and flags a build uses, against the SDK and Node types the toolchain holds, and runs its
tests as its own npm test does. A module that needs a package the toolchain lacks, or has no tests, is
said by name, never passed. The media catalogue's twin is hq issue 311.
Author
Contributor

Delivery novox/mesh-catalog@0d5227ee7777 — delivered since 2026-10-09T07:29:42Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-09 01:29 (new) → proposed (announced): novox/mesh-catalog#151's head announced
  • 2026-10-09 01:29 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 01:29 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 07:29 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 07:29 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@0d5227ee7777` — **delivered** since 2026-10-09T07:29:42Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-09 01:29 (new) → proposed (announced): novox/mesh-catalog#151's head announced - 2026-10-09 01:29 proposed → checked (checked): the verdict names this commit - 2026-10-09 01:29 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 07:29 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 07:29 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-09 01:23:03 +00:00
A TypeScript module with tests and no sources of its own is tested, not skipped
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
mesh/delivery superseded: a newer head of the same pull request
f72903d05d
powerlevel10k carries only data and a test that reads it; the part skipped it silently.
jschoubben added 1 commit 2026-10-09 01:29:02 +00:00
Test a TypeScript module whose tests alone changed
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
mesh/delivery delivered
0d5227ee77
A change to a module's tests moves no build (hq ADR 0267), so the planner's modules leave it out; the
TypeScript part also reads the modules the changed files are in.
mesh-admin merged commit 895e4a65b8 into main 2026-10-09 07:29:36 +00:00
mesh-admin deleted branch check/typescript-modules-tested 2026-10-09 07:29:36 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#151