mesh-delivery: cover a held merge whose module a backlog walk carried to every machine (hq issue 351) #163

Merged
mesh-admin merged 1 commits from fix/a-release-carried-module-counts-as-sent into main 2026-10-09 15:03:37 +00:00
Contributor

A build the controller held back for a person reaches its machines by a backlog walk on the operator's word (upgrade release-backlog). That walk credits the delivery that published the build one step per machine, never the walk's own "every machine running it"; and its last record keeps no gate, only the machines it is done on. mesh-delivery read nothing from that end, so the credited steps stayed judging for ever, and carries (hq ADR 0270) counted only the aggregate steps, so the held merge had no end but a person's wrong act. The case: the catalogue's #125 (openrazer), held 28 hours after ADR 0270 went live, raising its stalled condition every hour, while module list showed openrazer built from #127's merge on both machines.

hq issue 351 holds the report and the diagnosis.

What changes, in modules/mesh-delivery:

  • creditReleased: a finished backlog walk passes the steps it carried on the machines it is done on (release.done); a step it failed on and a step another walk carried are left as they are.
  • carries: a module is sent everywhere when the walk's own aggregate step says so, as before, or when a passed step stands on every machine the held delivery's plan sends it to (plan.machines[].receives). A plan naming no machines, a machine still judging, failed or never sent leaves the delivery held.
  • askWalk: a walk that carried a step still sent or judging is asked for by its id (delivery-walks with plan), at a start at once and then once an hour, and its record taken as said. The backlog walk of the case ended on 2026-10-08 and is no longer among the 50 ended walks the controller lists back at a start, so without this the steps would never move.

Everything else of ADR 0270 stands: the later merge is delivered on its own passing check, by its own walk of its merge commit on the same trunk, and the forge says that commit contains the held one's.

Tests (covered_test.go), each failing on main before this change: TestAModuleAReleaseCarriedToEveryMachineCovers, TestAFinishedReleaseMovesTheStepsItCarriedToPassed, TestAHeldDeliveryWhoseModuleAReleaseCarriedIsCoveredOnceTheReleaseIsDone (the day's case whole, with the finished walk read by its id).

After delivery: at the holder's first ticks with this build, #127's two judging steps are asked for by the backlog walk's id, pass, #127 then carries openrazer for #125, the forge is asked once whether bf542128 contains a6385479 (it does), and #125 ends covered by #127; its group feat/module-groups then reads delivered, and the stalled condition clears at the self-check's next reading.

A build the controller held back for a person reaches its machines by a backlog walk on the operator's word (`upgrade release-backlog`). That walk credits the delivery that published the build one step per machine, never the walk's own "every machine running it"; and its last record keeps no gate, only the machines it is done on. mesh-delivery read nothing from that end, so the credited steps stayed `judging` for ever, and `carries` (hq ADR 0270) counted only the aggregate steps, so the held merge had no end but a person's wrong act. The case: the catalogue's #125 (openrazer), held 28 hours after ADR 0270 went live, raising its stalled condition every hour, while `module list` showed openrazer built from #127's merge on both machines. hq issue 351 holds the report and the diagnosis. **What changes**, in `modules/mesh-delivery`: - `creditReleased`: a finished backlog walk passes the steps it carried on the machines it is done on (`release.done`); a step it failed on and a step another walk carried are left as they are. - `carries`: a module is sent everywhere when the walk's own aggregate step says so, as before, or when a `passed` step stands on every machine the held delivery's plan sends it to (`plan.machines[].receives`). A plan naming no machines, a machine still judging, failed or never sent leaves the delivery held. - `askWalk`: a walk that carried a step still `sent` or `judging` is asked for by its id (`delivery-walks` with `plan`), at a start at once and then once an hour, and its record taken as said. The backlog walk of the case ended on 2026-10-08 and is no longer among the 50 ended walks the controller lists back at a start, so without this the steps would never move. Everything else of ADR 0270 stands: the later merge is delivered on its own passing check, by its own walk of its merge commit on the same trunk, and the forge says that commit contains the held one's. **Tests** (`covered_test.go`), each failing on main before this change: `TestAModuleAReleaseCarriedToEveryMachineCovers`, `TestAFinishedReleaseMovesTheStepsItCarriedToPassed`, `TestAHeldDeliveryWhoseModuleAReleaseCarriedIsCoveredOnceTheReleaseIsDone` (the day's case whole, with the finished walk read by its id). **After delivery**: at the holder's first ticks with this build, #127's two judging steps are asked for by the backlog walk's id, pass, #127 then carries openrazer for #125, the forge is asked once whether bf542128 contains a6385479 (it does), and #125 ends `covered` by #127; its group `feat/module-groups` then reads delivered, and the stalled condition clears at the self-check's next reading.
Author
Contributor

Delivery novox/mesh-catalog@4e14ef9835e0 — delivered since 2026-10-09T15:11:40Z

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Machines

  • mesh-delivery on novox: passed — healthy 3 times over 7m9s
  • mesh-delivery on the rest running it: sent

Transitions

  • 2026-10-09 14:52 (new) → proposed (announced): novox/mesh-catalog#163's head announced
  • 2026-10-09 14:55 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 14:55 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 15:03 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 15:03 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-09 15:11 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@4e14ef9835e0` — **delivered** since 2026-10-09T15:11:40Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Machines** - mesh-delivery on novox: passed — healthy 3 times over 7m9s - mesh-delivery on the rest running it: sent **Transitions** - 2026-10-09 14:52 (new) → proposed (announced): novox/mesh-catalog#163's head announced - 2026-10-09 14:55 proposed → checked (checked): the verdict names this commit - 2026-10-09 14:55 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 15:03 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 15:03 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-09 15:11 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-09 14:52:40 +00:00
mesh-delivery: cover a held merge whose module a backlog walk carried to every machine (hq issue 351)
mesh/merge-gate pass: builds mesh-delivery → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
4e14ef9835
A build the controller held back for a person reaches its machines by a backlog walk on the
operator's word, which credits the delivery that published the build one step per machine and
never the walk's own "every machine running it". Its last record keeps no gate, only the machines
it is done on, so the credited steps stayed judging for ever, and `covered` read only the aggregate
steps, so the held merge had no end but a person's wrong act (the catalogue's #125, held 28 hours
after hq ADR 0270 went live).

A finished backlog walk now passes the steps it carried on the machines it is done on; `carries`
counts a module as sent everywhere when a passed step stands on every machine the held delivery's
plan sends it to; and a walk that carried a step still judging is asked for by its id, since one
that ended before the holder's restart may be older than the ended walks the controller lists
back. Three tests fail before and pass after.
jschoubben force-pushed fix/a-release-carried-module-counts-as-sent from d0cecb7f45 to 4e14ef9835 2026-10-09 14:52:40 +00:00 Compare
Author
Contributor

Merge check at d0cecb7f

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Run by the build seat on g14 as build-1791557445520238147 (builds --log build-1791557445520238147).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T14:42:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T14:42:25Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.001s
words: 12 retired words, none in the 35270 strings of 615 files
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.004s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 70, as kept
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	1.205s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `d0cecb7f` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery Run by the build seat on g14 as `build-1791557445520238147` (`builds --log build-1791557445520238147`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T14:42:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T14:42:25Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.001s words: 12 retired words, none in the 35270 strings of 615 files ok git.novox.be/novox/mesh-catalog/checks/paths 0.004s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 70, as kept testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 1.205s --- its merge-check-typescript.sh (typescript toolchain) ```
Author
Contributor

Merge check at 4e14ef98

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Run by the build seat on g14 as build-1791557568997240719 (builds --log build-1791557568997240719).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T14:52:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T14:52:25Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words, none in the 35270 strings of 615 files
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.008s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 70, as kept
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	1.282s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `4e14ef98` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery Run by the build seat on g14 as `build-1791557568997240719` (`builds --log build-1791557568997240719`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T14:52:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T14:52:25Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words, none in the 35270 strings of 615 files ok git.novox.be/novox/mesh-catalog/checks/paths 0.008s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 70, as kept testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 1.282s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit d902e1550e into main 2026-10-09 15:03:37 +00:00
mesh-admin deleted branch fix/a-release-carried-module-counts-as-sent 2026-10-09 15:03:37 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#163