mesh-knowledge: the review is shown every link kind propose accepts, and a research effort's status apart from its state (hq issue 492) #216

Merged
mesh-admin merged 1 commits from fix/492-the-review-sees-what-propose-accepts into main 2026-10-11 11:12:40 +00:00
Contributor

Fixes hq issue 492: the first live review sent research 046 back because (a) its rules named no link kinds, so touches looked unknown, and (b) the record showed status: proposed (the record's state) beside effort: active.

  • The review question now lists every kind in LinkKinds (the one list propose's link-kind rule checks) with its meaning from the new LinkMeanings, so the two cannot drift.
  • The record the judge sees shows state in the knowledge base: proposed (...not the record's own status) and, for research, research status: active; it no longer shows status: or effort: lines.

Tests (fail first, against origin/main): every LinkKinds entry appears in the judge's rules and has a meaning; a research proposal with touches links is shown its research status apart from its state. go test -race ok; merge-check.sh ok (69, as kept).

The judge's third finding on 046 (a deferral naming no tracking issue) is a rule finding about that record's text, not this fault. Live 046 needs its author to propose it again after delivery.

Fixes hq issue 492: the first live review sent research 046 back because (a) its rules named no link kinds, so `touches` looked unknown, and (b) the record showed `status: proposed` (the record's state) beside `effort: active`. - The review question now lists every kind in `LinkKinds` (the one list propose's `link-kind` rule checks) with its meaning from the new `LinkMeanings`, so the two cannot drift. - The record the judge sees shows `state in the knowledge base: proposed (...not the record's own status)` and, for research, `research status: active`; it no longer shows `status:` or `effort:` lines. Tests (fail first, against origin/main): every LinkKinds entry appears in the judge's rules and has a meaning; a research proposal with `touches` links is shown its research status apart from its state. `go test -race` ok; `merge-check.sh` ok (69, as kept). The judge's third finding on 046 (a deferral naming no tracking issue) is a rule finding about that record's text, not this fault. Live 046 needs its author to propose it again after delivery.
mesh-admin added 1 commit 2026-10-11 11:07:38 +00:00
mesh-knowledge: the review is shown every link kind propose accepts and a research effort's status apart from its state (hq issue 492)
mesh/merge-gate pass: builds mesh-knowledge → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
a6e2881448
The first live review sent research 046 back for a touches link the rules never named and a status proposed
that is the record's state, not the effort's. The rules now list LinkKinds, the one list propose holds a link
to, each with its meaning.
Author
Contributor

Delivery novox/mesh-catalog@a6e28814483e — delivered since 2026-10-11T11:19:39Z

Delivery plan — builds mesh-knowledge → novox; no bus step

  • tier 0: mesh-knowledge
  • novox: receives mesh-knowledge

Machines

  • mesh-knowledge on novox: passed — healthy 3 times over 3m54s
  • mesh-knowledge on the rest running it: sent

Transitions

  • 2026-10-11 11:07 (new) → proposed (announced): novox/mesh-catalog#216's head announced
  • 2026-10-11 11:10 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 11:10 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 11:14 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 11:14 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 11:19 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@a6e28814483e` — **delivered** since 2026-10-11T11:19:39Z **Delivery plan** — builds mesh-knowledge → novox; no bus step - tier 0: mesh-knowledge - novox: receives mesh-knowledge **Machines** - mesh-knowledge on novox: passed — healthy 3 times over 3m54s - mesh-knowledge on the rest running it: sent **Transitions** - 2026-10-11 11:07 (new) → proposed (announced): novox/mesh-catalog#216's head announced - 2026-10-11 11:10 proposed → checked (checked): the verdict names this commit - 2026-10-11 11:10 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 11:14 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 11:14 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 11:19 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at a6e28814

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-knowledge)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-knowledge → novox; no bus step

  • tier 0: mesh-knowledge
  • novox: receives mesh-knowledge
  • read by no module's build: modules/mesh-knowledge/README.md, modules/mesh-knowledge/cmd/mesh-knowledge/review_sees_test.go

Run by the build seat on ace as build-1791716859673416986 (builds --log build-1791716859673416986).

--- the gate: mesh-knowledge
note: mesh-knowledge uses the seat "operator-channel", which no module declares and the mesh does not define among the manifests given; registration judges it against the whole catalogue, and passing the declaring module's manifest too judges it here
mesh-knowledge: ok, 2 tool(s), invokes seat:issue-tracker.reserve, claude-code.claude_code_judge, records.records_status, records.records_list, records.records_read, seat:operator-channel.notify, ready: keep by unit every 30s; watch by its tool knowledge_health every 1m0s
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T11:02:35Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T11:02:35Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-knowledge

notes:
  - modules/mesh-knowledge/README.md and modules/mesh-knowledge/cmd/mesh-knowledge/review_sees_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words and 70 daemons' lines, none in the 41738 strings of 676 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.010s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.005s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
testing modules/mesh-knowledge
ok  	mesh-knowledge/cmd/mesh-knowledge	89.319s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `a6e28814` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-knowledge) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-knowledge → novox; no bus step - tier 0: mesh-knowledge - novox: receives mesh-knowledge - read by no module's build: modules/mesh-knowledge/README.md, modules/mesh-knowledge/cmd/mesh-knowledge/review_sees_test.go Run by the build seat on ace as `build-1791716859673416986` (`builds --log build-1791716859673416986`). ``` --- the gate: mesh-knowledge note: mesh-knowledge uses the seat "operator-channel", which no module declares and the mesh does not define among the manifests given; registration judges it against the whole catalogue, and passing the declaring module's manifest too judges it here mesh-knowledge: ok, 2 tool(s), invokes seat:issue-tracker.reserve, claude-code.claude_code_judge, records.records_status, records.records_list, records.records_read, seat:operator-channel.notify, ready: keep by unit every 30s; watch by its tool knowledge_health every 1m0s long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T11:02:35Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T11:02:35Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-knowledge notes: - modules/mesh-knowledge/README.md and modules/mesh-knowledge/cmd/mesh-knowledge/review_sees_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words and 70 daemons' lines, none in the 41738 strings of 676 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.010s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.005s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept testing modules/mesh-knowledge ok mesh-knowledge/cmd/mesh-knowledge 89.319s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit b687a98770 into main 2026-10-11 11:12:40 +00:00
mesh-admin deleted branch fix/492-the-review-sees-what-propose-accepts 2026-10-11 11:12:40 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#216