mesh-delivery: say how many owed effects were tried since the start (hq issue 407) #246

Merged
mesh-admin merged 1 commits from fix/407-owed-effects-are-counted into main 2026-10-12 12:23:37 +00:00
Contributor

Fixes novox/hq issue 407.

Cause. delivery_status (verbs.go, Status) said only how many effects are owed now (owed). Flush (effects.go) tried owed effects and counted nothing, so issue 326's rule (bucket writes in a window rise by no more than the owed effects tried in it) could not be judged in a window with retries.

Change. Flush counts each try by how it ended: done, failed (tried again later), or given up; and keeps the time of the last try. delivery_status says them as owed-tried: since (this owner's start), tried, done, failed, given-up, last (absent until something was tried). The count is not kept across a restart: it says since when it counts, so a window's tries are the difference of two readings in the same run. Memory: three integers and a time. Flushing itself is unchanged: the count is added after each try's outcome, under the same lock, and changes no owed list, retry time or write.

Tests (issue407_test.go, both fail on main):

  • TestDeliveryStatusCountsTheOwedEffectsTried: nothing tried at start; successes counted done; the forge away counts failed; a pass before the next try counts nothing; the forge back counts exactly the failed ones again; last is the time of the last try.
  • TestOwedTriedCountsSinceTheStart: a restarted holder counts from 0 since its own start.

go vet, go test -race and merge-check.sh (MESH_CHECK_MODULES=mesh-delivery) pass locally; the controller's manifest check was not run locally (no controller beside the check).

Fixes novox/hq issue 407. **Cause.** `delivery_status` (verbs.go, `Status`) said only how many effects are owed now (`owed`). `Flush` (effects.go) tried owed effects and counted nothing, so issue 326's rule (bucket writes in a window rise by no more than the owed effects tried in it) could not be judged in a window with retries. **Change.** `Flush` counts each try by how it ended: done, failed (tried again later), or given up; and keeps the time of the last try. `delivery_status` says them as `owed-tried`: `since` (this owner's start), `tried`, `done`, `failed`, `given-up`, `last` (absent until something was tried). The count is not kept across a restart: it says since when it counts, so a window's tries are the difference of two readings in the same run. Memory: three integers and a time. Flushing itself is unchanged: the count is added after each try's outcome, under the same lock, and changes no owed list, retry time or write. **Tests** (issue407_test.go, both fail on main): - `TestDeliveryStatusCountsTheOwedEffectsTried`: nothing tried at start; successes counted done; the forge away counts failed; a pass before the next try counts nothing; the forge back counts exactly the failed ones again; `last` is the time of the last try. - `TestOwedTriedCountsSinceTheStart`: a restarted holder counts from 0 since its own start. `go vet`, `go test -race` and `merge-check.sh` (MESH_CHECK_MODULES=mesh-delivery) pass locally; the controller's manifest check was not run locally (no controller beside the check).
mesh-admin added 1 commit 2026-10-12 12:17:10 +00:00
Count the owed effects mesh-delivery tried, so a window's writes can be judged against them
mesh/merge-gate pass: builds mesh-delivery → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
a3ad3c5061
delivery_status said only what is owed now; issue 326's rule needs the tries made in a window.
It now says the tries since this owner started, by how each ended, and the last try's time.
(novox/hq issue 407)
Author
Contributor

Delivery novox/mesh-catalog@a3ad3c506190 — delivered since 2026-10-12T12:28:42Z

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery

Machines

  • mesh-delivery on novox: passed — healthy 3 times over 2m26s
  • mesh-delivery on the rest running it: sent

Transitions

  • 2026-10-12 12:17 (new) → proposed (announced): novox/mesh-catalog#246's head announced
  • 2026-10-12 12:21 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:21 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 12:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 12:25 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 12:28 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@a3ad3c506190` — **delivered** since 2026-10-12T12:28:42Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Machines** - mesh-delivery on novox: passed — healthy 3 times over 2m26s - mesh-delivery on the rest running it: sent **Transitions** - 2026-10-12 12:17 (new) → proposed (announced): novox/mesh-catalog#246's head announced - 2026-10-12 12:21 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:21 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 12:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 12:25 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 12:28 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at a3ad3c50

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

  • tier 0: mesh-delivery
  • novox: receives mesh-delivery
  • read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue407_test.go

Run by the build seat on novox as build-1791807455190814435 (builds --log build-1791807455190814435).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:11:38Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:11:38Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery

notes:
  - modules/mesh-delivery/cmd/mesh-delivery/issue407_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.004s
words: 12 retired words and 70 daemons' lines, none in the 43219 strings of 690 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.013s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.008s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.265s
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	2.949s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `a3ad3c50` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue407_test.go Run by the build seat on novox as `build-1791807455190814435` (`builds --log build-1791807455190814435`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:11:38Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:11:38Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery notes: - modules/mesh-delivery/cmd/mesh-delivery/issue407_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.004s words: 12 retired words and 70 daemons' lines, none in the 43219 strings of 690 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.013s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.008s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.265s testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 2.949s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit 2772120758 into main 2026-10-12 12:23:37 +00:00
mesh-admin deleted branch fix/407-owed-effects-are-counted 2026-10-12 12:23:37 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#246