The store does not collect until every controller composes the window (hq ADR 0189) #254

Merged
mesh-admin merged 1 commits from fix/the-store-collects-once-the-window-is-understood into main 2026-10-04 02:26:57 +00:00
Contributor

Unblocks novox, which is refusing its whole declaration.

mesh-controller#259 fixes while-stopped to name the container as the machine knows it — distribution.store, not store. That fix is built and the declaration names it, but the deployed controller keeps reverting to an older build that still composes the broken form, so every push is refused and the fix cannot land through the normal path.

Taking the step out makes the declaration acceptable to any controller, old or new. Once the fixed controller is deployed and stays, the step goes back.

REGISTRY_STORAGE_DELETE_ENABLED stays — it is already applied on the machine and is harmless on its own.

The step does not come back without its window. A collect step with no while-stopped would run garbage collection against a live registry, which can sweep a blob a concurrent build is pushing. Half of this feature is worse than none of it.

**Unblocks novox, which is refusing its whole declaration.** mesh-controller#259 fixes `while-stopped` to name the container as the machine knows it — `distribution.store`, not `store`. That fix is built and the declaration names it, but the deployed controller keeps reverting to an older build that still composes the broken form, so every push is refused and the fix cannot land through the normal path. Taking the step out makes the declaration acceptable to *any* controller, old or new. Once the fixed controller is deployed and stays, the step goes back. `REGISTRY_STORAGE_DELETE_ENABLED` stays — it is already applied on the machine and is harmless on its own. **The step does not come back without its window.** A `collect` step with no `while-stopped` would run garbage collection against a live registry, which can sweep a blob a concurrent build is pushing. Half of this feature is worse than none of it.
mesh-admin added 1 commit 2026-10-04 02:26:50 +00:00
mesh-controller#259 fixes while-stopped to name the container as the machine
knows it — `distribution.store`, not `store`. Until that controller is the
one composing, novox refuses its whole declaration and takes nothing at all.

The step comes out; deletion stays on, already applied and harmless on its
own. A collect step without its window would be worse than none: garbage
collection against a live registry can sweep a blob a build is pushing.

Put back once the fixed controller is deployed and stays.
mesh-admin merged commit 27315d35cf into main 2026-10-04 02:26:57 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#254