betterbird: own Betterbird's whole configuration as settings, shown without a credential (hq issue 586, ADR 0329) #262

Merged
mesh-admin merged 2 commits from fix/586-betterbird-owns-its-configuration into main 2026-10-13 00:25:41 +00:00
Contributor

What

  • prefs is one entry per preference ({"prefs": {"mail.uifontsize": 14}}), merged key by key from the mesh-wide layer and a node's layer (null takes one out). It reaches the machine as ~/.config/betterbird/prefs.json (trusted, takes-settings: [prefs]); the old user-js resource and the settings.prefs declaration are gone, and the tools compose the user.js from the settings. install/defaults-pref/mesh-defaults.js keeps no value of the operator's (only the five "keeps Betterbird's default" names); the 21 approved preferences move to the mesh-wide layer through a proposal (below).
  • Five new settings (ADR 0329 §4): identities, calendars, address-books, filters in configuration.json (trusted, 0600) and tags in tags.json (trusted: false). Every mergeable file names its keys (ADR 0326).
  • Adopted as accounts are (§7): recorded key, module's own key (ident_mesh_<name>, mesh_<name>), node-layer key, else one match adopted / none created / several refused with the remedy. Leaving releases or removes preferences, never events, contacts or caches. Record in configuration-record.json.
  • Filters owned whole per declared account (§8): msgFilterRules.dat rendered from the list, folders by path turned into this node's address; first write keeps the replaced file in ~/.config/betterbird/kept/<profile>/; an account taken out keeps its last file.
  • Closed only (§9): every write to prefs.js (account lists too, since review 121) and the filter files happen only while no Betterbird runs and the profile has no lock, written atomically with a sync; the check counts waiting changes per kind.
  • Tools (§12): betterbird_identities, _calendars, _address_books, _filters, _tags (profile beside declared), betterbird_derive (all desktop nodes via mesh-controller.nodes/node and betterbird.betterbird_derive@<node> with here; layer per §10; propose one layer at a time, carrying the layer as it stands, refused while a module proposal waits, a desktop node does not answer, or the controller's answer cannot be read as the layer), betterbird_drift (§11). betterbird_accounts now lists values (Owl's marked by name and address) and its propose merges into the mesh-wide layer as it stands. betterbird_config keep proposes the node layer as it stands with the kept keys. Every tool answer passes credentialChecked (§2).
  • invokes gains seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive.

Why

hq issue 586: the module owned only the accounts' server fields, so identities, signatures, calendars, address books, filters and tags could differ between desktop nodes unseen, and the tools could not show the operator's own configuration. Operator rule for this build: the operator's choices live in the module's configuration (settings layers), never in catalogue files.

Decisions made in the build (the operator left the Betterbird choices to us)

  • A signature is a list of lines (a setting holds no line break, issue 339). signature-above-quote sets reply_on_top 1 and sig_bottom false.
  • An identities entry without address is its account's default identity and may not carry a name (both come from accounts).
  • Entry names are lower-case letters and digits, as account names; a tag is keyed by its own key; tag order is written as ordinal 1000+order.
  • A null entry in a node's layer takes a mesh-wide entry out on that node.
  • A filter value, name or folder may not hold a quote, backslash or parenthesis; Reply to template and add-on actions are not declarable (named as not derived).
  • An account whose filter file holds no filter is not put into filters by the derive (its file stays the person's).
  • An entry on some but not all desktop nodes goes into each holding node's own layer.
  • The mesh-wide layer's proposal never carries a key.
  • The five "keeps Betterbird's default" names stay in mesh-defaults.js (they hold no value).
  • Drift compares against what Betterbird reads at its next start (prefs.js with the profile's user.js over it).

Rollout order: no node on Betterbird's own defaults

  1. Merge this PR. The record upgrade policy holds the build back from the nodes.
  2. Propose the mesh-wide layer through mesh-controller.settings with propose: "true", carrying the current accounts verbatim plus prefs with the 21 values:
{"mail.uidensity": 0, "mail.uifontsize": 14, "mail.dark-reader.enabled": false, "mail.pane_config.dynamic": 2, "mail.pane_config.multiline_all": true, "mail.threadpane.listview": 0, "mailnews.default_view_flags": 1, "mail.warn_on_shift_delete": false, "mail.biff.show_alert": false, "mail.biff.play_sound": false, "mail.biff.show_tray_icon": false, "mail.biff.use_system_alert": true, "calendar.view.daystarthour": 9, "calendar.view.dayendhour": 20, "calendar.item.promptDelete": false, "calendar.timezone.useSystemTimezone": true, "calendar.alarms.show": true, "calendar.alarms.showmissed": true, "mail.chat.enabled": false, "mailnews.message_display.disable_remote_image": true, "privacy.donottrackheader.enabled": true}
  1. The operator approves.
  2. Only then push the desktop nodes. After that, betterbird_derive with propose proposes the identities, calendars, address books, filters and tags layer by layer.

Caveat: between that approval and a node's push, any other send to a desktop node writes the map's text into the old build's user.js, and betterbird_check there complains until the push.

Depends on

tags set directly through the settings verb (ADR 0329 §5) needs novox/mesh-controller #286; without it the controller keeps the whole betterbird layer at the terminal (fails closed, nothing breaks).

How it was tested

  • go vet and go test -race ./... in modules/betterbird (new: configuration_test.go, derive_test.go; adapted config, accounts, manifest tests). The new tests cover each line of ADR 0329's "How it is checked" that is the module's. Review 121 added TestTheAccountListsWaitWhileTheProfileIsLocked and TestALayerThatCannotBeReadRefusesTheProposal, both failing without the fix.
  • MESH_CHECK_MODULES=betterbird MESH_GATE=<mesh-controller main 454a3db> ./merge-check.sh: exit 0.

Fixes issue 586 (the catalogue part).

## What - **`prefs` is one entry per preference** (`{"prefs": {"mail.uifontsize": 14}}`), merged key by key from the mesh-wide layer and a node's layer (`null` takes one out). It reaches the machine as `~/.config/betterbird/prefs.json` (trusted, `takes-settings: [prefs]`); the old `user-js` resource and the `settings.prefs` declaration are gone, and the tools compose the user.js from the settings. `install/defaults-pref/mesh-defaults.js` keeps **no value of the operator's** (only the five "keeps Betterbird's default" names); the 21 approved preferences move to the mesh-wide layer through a proposal (below). - **Five new settings** (ADR 0329 §4): `identities`, `calendars`, `address-books`, `filters` in `configuration.json` (trusted, 0600) and `tags` in `tags.json` (`trusted: false`). Every mergeable file names its keys (ADR 0326). - **Adopted as accounts are** (§7): recorded key, module's own key (`ident_mesh_<name>`, `mesh_<name>`), node-layer `key`, else one match adopted / none created / several refused with the remedy. Leaving releases or removes preferences, never events, contacts or caches. Record in `configuration-record.json`. - **Filters owned whole per declared account** (§8): `msgFilterRules.dat` rendered from the list, folders by path turned into this node's address; first write keeps the replaced file in `~/.config/betterbird/kept/<profile>/`; an account taken out keeps its last file. - **Closed only** (§9): every write to prefs.js (account lists too, since review 121) and the filter files happen only while no Betterbird runs and the profile has no `lock`, written atomically with a sync; the check counts waiting changes per kind. - **Tools** (§12): `betterbird_identities`, `_calendars`, `_address_books`, `_filters`, `_tags` (profile beside declared), `betterbird_derive` (all desktop nodes via `mesh-controller.nodes`/`node` and `betterbird.betterbird_derive@<node>` with `here`; layer per §10; `propose` one layer at a time, carrying the layer as it stands, refused while a module proposal waits, a desktop node does not answer, or the controller's answer cannot be read as the layer), `betterbird_drift` (§11). `betterbird_accounts` now lists values (Owl's marked by name and address) and its propose merges into the mesh-wide layer as it stands. `betterbird_config` `keep` proposes the node layer as it stands with the kept keys. Every tool answer passes `credentialChecked` (§2). - `invokes` gains `seat:mesh-controller.nodes`, `seat:mesh-controller.node`, `betterbird.betterbird_derive`. ## Why hq issue 586: the module owned only the accounts' server fields, so identities, signatures, calendars, address books, filters and tags could differ between desktop nodes unseen, and the tools could not show the operator's own configuration. Operator rule for this build: the operator's choices live in the module's configuration (settings layers), never in catalogue files. ## Decisions made in the build (the operator left the Betterbird choices to us) - A signature is a list of lines (a setting holds no line break, issue 339). `signature-above-quote` sets `reply_on_top` 1 and `sig_bottom` false. - An identities entry without `address` is its account's default identity and may not carry a name (both come from `accounts`). - Entry names are lower-case letters and digits, as account names; a tag is keyed by its own key; tag order is written as ordinal `1000+order`. - A `null` entry in a node's layer takes a mesh-wide entry out on that node. - A filter value, name or folder may not hold a quote, backslash or parenthesis; `Reply to template` and add-on actions are not declarable (named as not derived). - An account whose filter file holds no filter is not put into `filters` by the derive (its file stays the person's). - An entry on some but not all desktop nodes goes into each holding node's own layer. - The mesh-wide layer's proposal never carries a `key`. - The five "keeps Betterbird's default" names stay in `mesh-defaults.js` (they hold no value). - Drift compares against what Betterbird reads at its next start (prefs.js with the profile's user.js over it). ## Rollout order: no node on Betterbird's own defaults 1. Merge this PR. The `record` upgrade policy holds the build back from the nodes. 2. Propose the mesh-wide layer through `mesh-controller.settings` with `propose: "true"`, carrying the current `accounts` verbatim plus `prefs` with the 21 values: ``` {"mail.uidensity": 0, "mail.uifontsize": 14, "mail.dark-reader.enabled": false, "mail.pane_config.dynamic": 2, "mail.pane_config.multiline_all": true, "mail.threadpane.listview": 0, "mailnews.default_view_flags": 1, "mail.warn_on_shift_delete": false, "mail.biff.show_alert": false, "mail.biff.play_sound": false, "mail.biff.show_tray_icon": false, "mail.biff.use_system_alert": true, "calendar.view.daystarthour": 9, "calendar.view.dayendhour": 20, "calendar.item.promptDelete": false, "calendar.timezone.useSystemTimezone": true, "calendar.alarms.show": true, "calendar.alarms.showmissed": true, "mail.chat.enabled": false, "mailnews.message_display.disable_remote_image": true, "privacy.donottrackheader.enabled": true} ``` 3. The operator approves. 4. Only then push the desktop nodes. After that, `betterbird_derive` with `propose` proposes the identities, calendars, address books, filters and tags layer by layer. Caveat: between that approval and a node's push, any other send to a desktop node writes the map's text into the old build's user.js, and `betterbird_check` there complains until the push. ## Depends on `tags` set directly through the `settings` verb (ADR 0329 §5) needs novox/mesh-controller #286; without it the controller keeps the whole betterbird layer at the terminal (fails closed, nothing breaks). ## How it was tested - `go vet` and `go test -race ./...` in `modules/betterbird` (new: `configuration_test.go`, `derive_test.go`; adapted config, accounts, manifest tests). The new tests cover each line of ADR 0329's "How it is checked" that is the module's. Review 121 added `TestTheAccountListsWaitWhileTheProfileIsLocked` and `TestALayerThatCannotBeReadRefusesTheProposal`, both failing without the fix. - `MESH_CHECK_MODULES=betterbird MESH_GATE=<mesh-controller main 454a3db> ./merge-check.sh`: exit 0. Fixes issue 586 (the catalogue part).
mesh-admin added 1 commit 2026-10-13 00:03:40 +00:00
betterbird: own Betterbird's whole configuration as settings, shown without a credential (hq issue 586, ADR 0329)
mesh/merge-gate head 1835f0efad0f merged into trunk 39e7a06e6293 — pass: builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person; every machin…
mesh/repo-check head 1835f0efad0f merged into trunk 39e7a06e6293 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
mesh/delivery superseded: a newer head of the same pull request
1835f0efad
The module owned only the accounts' server fields, so identities, signatures,
calendars, address books, filters and tags could differ between desktop nodes
unseen, and the operator's own preferences were shipped in the catalogue.

prefs becomes one entry per preference (a node's layer overrides one key) and the
defaults file keeps no value of the operator's; identities, calendars,
address-books, filters and tags become settings, adopted like accounts, filters
owned whole per account, and what Betterbird rewrites written only while it is
closed. New tools list each kind, derive the layers from every desktop node and
propose one at a time, and show drift; every answer passes a credential check.
Author
Contributor

Delivery novox/mesh-catalog@c9a711c259ed — delivered since 2026-10-13T00:27:16Z

Delivery plan — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person

  • tier 0: betterbird
  • g14: waits for a person: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)

Transitions

  • 2026-10-13 00:12 (new) → proposed (announced): novox/mesh-catalog#262's head announced
  • 2026-10-13 00:15 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 00:15 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 00:22 ready → proposed (trunk moved): out of date: judged against trunk 39e7a06e62, the trunk is now 827b89dbf109; judged again on a recheck or when it is merged
  • 2026-10-13 00:25 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 00:25 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 00:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 00:26 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-13 00:27 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@c9a711c259ed` — **delivered** since 2026-10-13T00:27:16Z **Delivery plan** — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person - tier 0: betterbird - g14: waits for a person: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) **Transitions** - 2026-10-13 00:12 (new) → proposed (announced): novox/mesh-catalog#262's head announced - 2026-10-13 00:15 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 00:15 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 00:22 ready → proposed (trunk moved): out of date: judged against trunk 39e7a06e6293, the trunk is now 827b89dbf109; judged again on a recheck or when it is merged - 2026-10-13 00:25 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 00:25 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 00:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 00:26 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-13 00:27 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 1835f0ef
Judged: head 1835f0efad0f merged into trunk 39e7a06e6293; read beside it: mesh-controller 454a3db69a1e, mesh-controller-main 454a3db69a1e, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person

  • tier 0: betterbird
  • g14: waits for a person: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)
  • read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go

Run by the build seat on g14 as build-1791849837865941519 (builds --log build-1791849837865941519).

--- the gate: betterbird
betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T23:40:10Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T23:40:10Z

modules the change moves:
  - betterbird (changed)

machines:
  - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)

a merge would rebuild 1 module(s) in 1 tier(s): betterbird

notes:
  - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 46081 strings of 712 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.017s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 67, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.458s
testing modules/betterbird
ok  	betterbird/cmd/betterbird-tools	3.134s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `1835f0ef` Judged: head `1835f0efad0f` merged into trunk `39e7a06e6293`; read beside it: mesh-controller `454a3db69a1e`, mesh-controller-main `454a3db69a1e`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person - tier 0: betterbird - g14: waits for a person: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) - read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go Run by the build seat on g14 as `build-1791849837865941519` (`builds --log build-1791849837865941519`). ``` --- the gate: betterbird betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T23:40:10Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T23:40:10Z modules the change moves: - betterbird (changed) machines: - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) a merge would rebuild 1 module(s) in 1 tier(s): betterbird notes: - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 46081 strings of 712 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.017s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 67, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.458s testing modules/betterbird ok betterbird/cmd/betterbird-tools 3.134s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin left a comment
Author
Contributor

Verdict: request changes at 1835f0efad

BLOCKING

  1. Not every write to prefs.js honours the profile lock or syncs before the rename. The new path (owned.go: closedFor, writeClosed, writeAtomic over writeSynced) refuses while Betterbird runs or while <profile>/lock exists, and fsyncs before renaming. But the same apply still calls writeAccountLists (accounts.go, about line 398) first, and that function checks only for a running process, never for the lock file, and writes with os.WriteFile then rename, with no fsync. After a crash that left the lock behind, the launcher's prepare writes the account lists into prefs.js while writeClosed in the very same run refuses. Route writeAccountLists through m.closedFor(profile) and writeAtomic, and add a test with a lock file and no process that shows prefs.js unchanged. This change touches the apply that calls it, and the review checklist requires every prefs.js write to be lock-guarded and synced.

NOT BLOCKING

  1. Sequencing of the operator's 21 preferences. The README (the table row about the configuration) and the pull request's body plan to move the 21 preferences with betterbird_derive after delivery, which leaves every pushed desktop node on Betterbird's own defaults (density, new-mail alerts, layout, calendar hours) until the operator approves. The policy lock on mail.shell.checkDefaultClient survives this change: install/distribution/policies.json is unchanged and still locks it, together with mail.inappnotifications.enabled and mailnews.start_page.enabled, so the default-client popup does not return. The window itself is avoidable. After this pull request merges, the controller holds the new definition, and the upgrade policy record holds the build until a person pushes (ADR 0242 §1). In that gap, the mesh-wide layer can be proposed through mesh-controller.settings with propose true, carrying the current accounts value verbatim and prefs with the 21 values. The operator approves it, and only then are the nodes pushed, so no node runs without them. Propose it after the merge, not before: on main's definition prefs is a user_pref text, and the controller would fill an object into the old user-js file as Go map text. One caveat applies between the Approve and the push. Any other send to a desktop node composes betterbird at its last-sent manifest, so the old user-js file receives that text. The old tools refuse to place it, and betterbird_check reports it until the push, while Betterbird keeps the 21 values from the old mesh-defaults.js. betterbird_derive cannot do this before the push, because it asks every desktop node and refuses while one does not answer. Please write this order into the README and the pull request's body in place of 'until that layer is approved, a node runs Betterbird's defaults'. I did not submit a proposal to test it.

  2. readLayer (derive.go) treats any answer of the settings verb that does not begin with '{' as an empty layer. Betterbird_derive then proposes with replace true, so if the verb's wording ever changes, or it answers with a line before the layer, the proposal would drop accounts. The answer today does begin with '{', or with 'betterbird on : no layer', so it works now. Refuse anything but those two forms, so that approving a proposal can never silently drop a key.

  3. The kept copy of a filter file is written before the first replace, and it is guarded by the record (was.Kept). However, its path is deterministic (kept//.msgFilterRules.dat). If configuration-record.json is lost after the first write, the next apply would overwrite the person's original copy with the module's own file. Do not overwrite a kept file that already exists.

  4. The user.js placement in betterbird.go (temp file and rename) still has no fsync. It is outside the checklist (user.js is only read at start), but writeAtomic is now available for it.

  5. tags set directly through the settings verb (ADR 0329 §5) depends on mesh-controller #286, as the body says. Until #286 merges, the controller keeps the whole layer for the operator. That fails closed, so it is a named gap, not a defect.

WHAT I CHECKED

I read ADR 0329 (all 13 clauses with its checks) and ADR 0326. Every clause is built: §1 and §2 through credentialChecked on every tool answer (main.go), §4 and §5 in module.json (three trusted files, tags.json untrusted, every mergeable file names its keys as ADR 0326 §2 asks), §6 in prefs.go (configurationOwned), §7 and §8 in owned.go and filters.go, §9 in closedFor and writeClosed, §10 to §12 in derive.go, listing.go and the 17 tools, and §13 in listing. go vet ./... is clean, and go test -race -count=1 ./... passes (GOTMPDIR=/var/tmp). With all non-test code reverted to main, the tests do not build. Six targeted mutations each fail a named test: credentialChecked made a no-op, the secret-name rule off, the password-in-address rule off, closedFor always open, the lock check off, and the kept copy skipped. No code path deletes mail, events, contacts or accounts: the only RemoveAll calls are the reminder test's own directory, and leaving a setting removes only preferences. Proposals carry the layer as it stands (withKinds over readLayer, and betterbird_accounts merges into the mesh-wide layer as it stands), except for the fragility in finding 3.

STATUSES AT THIS HEAD (gitea_commit_statuses, read 2026-10-13 about 02:10 local): mesh/merge-gate pending, 'building on g14 since 02:03'; mesh/delivery pending, 'checking'; mesh/repo-check missing. The combined state is pending, and the forge says it is not mergeable: main requires mesh/merge-gate and mesh/repo-check. Do not merge before both are green and read.

Verdict: request changes at 1835f0efad0f9d9b079ce54af35c3fba47e60221 BLOCKING 1. Not every write to prefs.js honours the profile lock or syncs before the rename. The new path (owned.go: closedFor, writeClosed, writeAtomic over writeSynced) refuses while Betterbird runs or while `<profile>/lock` exists, and fsyncs before renaming. But the same apply still calls writeAccountLists (accounts.go, about line 398) first, and that function checks only for a running process, never for the lock file, and writes with os.WriteFile then rename, with no fsync. After a crash that left the lock behind, the launcher's prepare writes the account lists into prefs.js while writeClosed in the very same run refuses. Route writeAccountLists through m.closedFor(profile) and writeAtomic, and add a test with a lock file and no process that shows prefs.js unchanged. This change touches the apply that calls it, and the review checklist requires every prefs.js write to be lock-guarded and synced. NOT BLOCKING 2. Sequencing of the operator's 21 preferences. The README (the table row about the configuration) and the pull request's body plan to move the 21 preferences with betterbird_derive after delivery, which leaves every pushed desktop node on Betterbird's own defaults (density, new-mail alerts, layout, calendar hours) until the operator approves. The policy lock on mail.shell.checkDefaultClient survives this change: install/distribution/policies.json is unchanged and still locks it, together with mail.inappnotifications.enabled and mailnews.start_page.enabled, so the default-client popup does not return. The window itself is avoidable. After this pull request merges, the controller holds the new definition, and the upgrade policy record holds the build until a person pushes (ADR 0242 §1). In that gap, the mesh-wide layer can be proposed through mesh-controller.settings with propose true, carrying the current `accounts` value verbatim and `prefs` with the 21 values. The operator approves it, and only then are the nodes pushed, so no node runs without them. Propose it after the merge, not before: on main's definition `prefs` is a user_pref text, and the controller would fill an object into the old user-js file as Go map text. One caveat applies between the Approve and the push. Any other send to a desktop node composes betterbird at its last-sent manifest, so the old user-js file receives that text. The old tools refuse to place it, and betterbird_check reports it until the push, while Betterbird keeps the 21 values from the old mesh-defaults.js. betterbird_derive cannot do this before the push, because it asks every desktop node and refuses while one does not answer. Please write this order into the README and the pull request's body in place of 'until that layer is approved, a node runs Betterbird's defaults'. I did not submit a proposal to test it. 3. readLayer (derive.go) treats any answer of the settings verb that does not begin with '{' as an empty layer. Betterbird_derive then proposes with replace true, so if the verb's wording ever changes, or it answers with a line before the layer, the proposal would drop `accounts`. The answer today does begin with '{', or with 'betterbird on <node>: no layer', so it works now. Refuse anything but those two forms, so that approving a proposal can never silently drop a key. 4. The kept copy of a filter file is written before the first replace, and it is guarded by the record (was.Kept). However, its path is deterministic (kept/<profile>/<account>.msgFilterRules.dat). If configuration-record.json is lost after the first write, the next apply would overwrite the person's original copy with the module's own file. Do not overwrite a kept file that already exists. 5. The user.js placement in betterbird.go (temp file and rename) still has no fsync. It is outside the checklist (user.js is only read at start), but writeAtomic is now available for it. 6. `tags` set directly through the settings verb (ADR 0329 §5) depends on mesh-controller #286, as the body says. Until #286 merges, the controller keeps the whole layer for the operator. That fails closed, so it is a named gap, not a defect. WHAT I CHECKED I read ADR 0329 (all 13 clauses with its checks) and ADR 0326. Every clause is built: §1 and §2 through credentialChecked on every tool answer (main.go), §4 and §5 in module.json (three trusted files, tags.json untrusted, every mergeable file names its keys as ADR 0326 §2 asks), §6 in prefs.go (configurationOwned), §7 and §8 in owned.go and filters.go, §9 in closedFor and writeClosed, §10 to §12 in derive.go, listing.go and the 17 tools, and §13 in listing. go vet ./... is clean, and go test -race -count=1 ./... passes (GOTMPDIR=/var/tmp). With all non-test code reverted to main, the tests do not build. Six targeted mutations each fail a named test: credentialChecked made a no-op, the secret-name rule off, the password-in-address rule off, closedFor always open, the lock check off, and the kept copy skipped. No code path deletes mail, events, contacts or accounts: the only RemoveAll calls are the reminder test's own directory, and leaving a setting removes only preferences. Proposals carry the layer as it stands (withKinds over readLayer, and betterbird_accounts merges into the mesh-wide layer as it stands), except for the fragility in finding 3. STATUSES AT THIS HEAD (gitea_commit_statuses, read 2026-10-13 about 02:10 local): mesh/merge-gate pending, 'building on g14 since 02:03'; mesh/delivery pending, 'checking'; mesh/repo-check missing. The combined state is pending, and the forge says it is not mergeable: main requires mesh/merge-gate and mesh/repo-check. Do not merge before both are green and read.
jschoubben added 1 commit 2026-10-13 00:12:10 +00:00
betterbird: write the account lists only while the profile is closed, and never propose over an unreadable layer (hq issue 586, review 121)
mesh/merge-gate head c9a711c259ed merged into trunk 827b89dbf109 — pass: builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person; every machin…
mesh/repo-check head c9a711c259ed merged into trunk 827b89dbf109 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
mesh/delivery delivered
c9a711c259
writeAccountLists checked only for a running Betterbird and wrote without a sync;
it now waits for the profile's lock too and writes atomically. readLayer read any
answer that was not JSON as an empty layer, and a proposal replaces the layer
whole, so a changed wording would have dropped accounts; it now refuses. The
README says the rollout order that leaves no node on Betterbird's defaults.
mesh-admin left a comment
Author
Contributor

Verdict: approve at c9a711c259

The blocking finding from review 121 is fixed. writeAccountLists (accounts.go) now refuses through m.closedFor(profile), which checks for a running Betterbird and for the profile's lock file. It writes prefs.js through writeAtomic: a temp file, writeSynced's fsync, then a rename. TestTheAccountListsWaitWhileTheProfileIsLocked shows that prefs.js stays unchanged while only the lock exists, and that the lists are written once the lock is gone. With accounts.go reverted to 1835f0e, that test fails.

Review 121's finding 3 is fixed. readLayer (derive.go) now accepts only two answers: one beginning with the layer's JSON, which must decode, and the controller's own 'betterbird on : no layer' words. Any other answer is an error that names the answer's first line. Both betterbird_derive and betterbird_accounts (accounts.go, readLayer("")) then refuse to propose. TestALayerThatCannotBeReadRefusesTheProposal covers both tools, shows that nothing was proposed, and shows that the 'no layer' answer still reads as an empty layer. With derive.go reverted to 1835f0e, that test fails. I could not see the controller's exact empty-layer words for the mesh-wide layer, because that layer holds accounts today. If they differ from 'betterbird on the whole mesh: no layer', the proposal is refused rather than dropping anything, so it fails closed.

The README section 'The order that leaves no node on Betterbird's own defaults', the README's table row, and the pull request's 'Rollout order' section now give the safe order. That order is: merge; propose the mesh-wide layer through mesh-controller.settings, carrying the current accounts verbatim and prefs with the 21 values; the operator approves; only then push the desktop nodes. All three also give the caveat about the old build's user.js between the approval and a push.

go vet ./... is clean, and go test -race -count=1 ./... passes (GOTMPDIR=/var/tmp).

The non-blocking notes 4 to 6 of review 121 still stand and do not block: a kept filter copy can be overwritten if the record is lost; the user.js placement has no fsync; and tags set directly depends on mesh-controller #286.

STATUSES AT THIS HEAD (gitea_commit_statuses): mesh/merge-gate pending, 'building on shanks since 02:12'; mesh/delivery pending, 'checking'; mesh/repo-check missing. The combined state is pending, and the forge says it is not mergeable yet. Merge only once mesh/merge-gate and mesh/repo-check are both green and read.

Verdict: approve at c9a711c259edaf3e00775deb2741ba89449f55b1 The blocking finding from review 121 is fixed. writeAccountLists (accounts.go) now refuses through m.closedFor(profile), which checks for a running Betterbird and for the profile's lock file. It writes prefs.js through writeAtomic: a temp file, writeSynced's fsync, then a rename. TestTheAccountListsWaitWhileTheProfileIsLocked shows that prefs.js stays unchanged while only the lock exists, and that the lists are written once the lock is gone. With accounts.go reverted to 1835f0e, that test fails. Review 121's finding 3 is fixed. readLayer (derive.go) now accepts only two answers: one beginning with the layer's JSON, which must decode, and the controller's own 'betterbird on <node or the whole mesh>: no layer' words. Any other answer is an error that names the answer's first line. Both betterbird_derive and betterbird_accounts (accounts.go, readLayer("")) then refuse to propose. TestALayerThatCannotBeReadRefusesTheProposal covers both tools, shows that nothing was proposed, and shows that the 'no layer' answer still reads as an empty layer. With derive.go reverted to 1835f0e, that test fails. I could not see the controller's exact empty-layer words for the mesh-wide layer, because that layer holds accounts today. If they differ from 'betterbird on the whole mesh: no layer', the proposal is refused rather than dropping anything, so it fails closed. The README section 'The order that leaves no node on Betterbird's own defaults', the README's table row, and the pull request's 'Rollout order' section now give the safe order. That order is: merge; propose the mesh-wide layer through mesh-controller.settings, carrying the current accounts verbatim and prefs with the 21 values; the operator approves; only then push the desktop nodes. All three also give the caveat about the old build's user.js between the approval and a push. go vet ./... is clean, and go test -race -count=1 ./... passes (GOTMPDIR=/var/tmp). The non-blocking notes 4 to 6 of review 121 still stand and do not block: a kept filter copy can be overwritten if the record is lost; the user.js placement has no fsync; and tags set directly depends on mesh-controller #286. STATUSES AT THIS HEAD (gitea_commit_statuses): mesh/merge-gate pending, 'building on shanks since 02:12'; mesh/delivery pending, 'checking'; mesh/repo-check missing. The combined state is pending, and the forge says it is not mergeable yet. Merge only once mesh/merge-gate and mesh/repo-check are both green and read.
Author
Contributor

Merge check at c9a711c2
Judged: head c9a711c259ed merged into trunk 39e7a06e6293; read beside it: mesh-controller 4473bc7d7315, mesh-controller-main 4473bc7d7315, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person

  • tier 0: betterbird
  • g14: waits for a person: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)
  • read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go

Run by the build seat on shanks as build-1791850336446209224 (builds --log build-1791850336446209224).

--- the gate: betterbird
betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T00:09:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T00:09:25Z

modules the change moves:
  - betterbird (changed)

machines:
  - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)

a merge would rebuild 1 module(s) in 1 tier(s): betterbird

notes:
  - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 46085 strings of 712 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.013s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 67, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.248s
testing modules/betterbird
ok  	betterbird/cmd/betterbird-tools	2.751s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `c9a711c2` Judged: head `c9a711c259ed` merged into trunk `39e7a06e6293`; read beside it: mesh-controller `4473bc7d7315`, mesh-controller-main `4473bc7d7315`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person - tier 0: betterbird - g14: waits for a person: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) - read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go Run by the build seat on shanks as `build-1791850336446209224` (`builds --log build-1791850336446209224`). ``` --- the gate: betterbird betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T00:09:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T00:09:25Z modules the change moves: - betterbird (changed) machines: - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) a merge would rebuild 1 module(s) in 1 tier(s): betterbird notes: - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 46085 strings of 712 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.013s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 67, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.248s testing modules/betterbird ok betterbird/cmd/betterbird-tools 2.751s --- its merge-check-typescript.sh (typescript toolchain) ```
Author
Contributor

Merge check at c9a711c2
Judged: head c9a711c259ed merged into trunk 827b89dbf109; read beside it: mesh-controller 4473bc7d7315, mesh-controller-main 4473bc7d7315, mesh-host 7a41e120635b, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person

  • tier 0: betterbird
  • g14: waits for a person: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)
  • read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go

Run by the build seat on g14 as build-1791850963322524478 (builds --log build-1791850963322524478).

--- the gate: betterbird
betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T00:18:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T00:18:25Z

modules the change moves:
  - betterbird (changed)

machines:
  - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js)

a merge would rebuild 1 module(s) in 1 tier(s): betterbird

notes:
  - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words and 70 daemons' lines, none in the 46085 strings of 712 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.009s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 67, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.193s
testing modules/betterbird
ok  	betterbird/cmd/betterbird-tools	2.798s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `c9a711c2` Judged: head `c9a711c259ed` merged into trunk `827b89dbf109`; read beside it: mesh-controller `4473bc7d7315`, mesh-controller-main `4473bc7d7315`, mesh-host `7a41e120635b`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds betterbird, sent nowhere; no bus step; 2 wait(s) for a person - tier 0: betterbird - g14: waits for a person: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) - read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go, modules/betterbird/cmd/betterbird-tools/manifest_test.go Run by the build seat on g14 as `build-1791850963322524478` (`builds --log build-1791850963322524478`). ``` --- the gate: betterbird betterbird: ok, 17 tool(s), invokes seat:mesh-controller.settings, seat:mesh-controller.nodes, seat:mesh-controller.node, betterbird.betterbird_derive long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T00:18:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T00:18:25Z modules the change moves: - betterbird (changed) machines: - a machine (f35): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes; the change adds 3 resource(s) and removes 1 (+file:betterbird.configuration, +file:betterbird.prefs, +file:betterbird.tags, -file:betterbird.user-js) a merge would rebuild 1 module(s) in 1 tier(s): betterbird notes: - modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/accounts_test.go, modules/betterbird/cmd/betterbird-tools/betterbird_test.go, modules/betterbird/cmd/betterbird-tools/config_test.go, modules/betterbird/cmd/betterbird-tools/configuration_test.go, modules/betterbird/cmd/betterbird-tools/derive_test.go and modules/betterbird/cmd/betterbird-tools/manifest_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words and 70 daemons' lines, none in the 46085 strings of 712 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.009s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 67, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.193s testing modules/betterbird ok betterbird/cmd/betterbird-tools 2.798s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit f88e3452f8 into main 2026-10-13 00:25:41 +00:00
mesh-admin deleted branch fix/586-betterbird-owns-its-configuration 2026-10-13 00:25:41 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#262