An answered ask keeps its question whole, its answer below it (issue 714) #299

Merged

mesh-admin merged 1 commits from fix/an-answered-ask-keeps-its-text into main 2026-10-14 18:11:07 +00:00

Conversation 2 Commits 1 Files Changed 10

+92 -36

mesh-admin commented 2026-10-14 18:06:57 +00:00

Contributor

Copy Link

Copy Source

Fixes hq issue 714 (answering an ask on Telegram replaces the ask).

Cause: modules/messenger/cmd/messenger/holder.go answeredWords (issue 372's fix, shortened by issue 639) made an answered ask's message one title, "You chose Approve at 20:03 on Telegram · ", and dropped the body and Details.

Fix: an answered ask keeps its headline as the title, its summary, points and link as the body, then its Details (whole on a proven kind, line by line under the content rule as on the open message). The note is how it ended and who acts on it. Buttons are gone as before. Telegram's partsOf cuts the body from its end past 4096 characters (the Details first), never the title or the note; a new telegram test pins that for an answered ask.

Tests: TestAnAsksMessageIsItsSummaryWithTheRestInItsNote now asserts the whole question plus the answer note; it fails on main. Expired, replaced, whole-words and feedback tests updated to the new shape. MESH_CHECK_MODULES=messenger,telegram sh merge-check.sh passes locally (manifests not read by a controller: none built beside it).

Fixes hq issue 714 (answering an ask on Telegram replaces the ask). **Cause:** `modules/messenger/cmd/messenger/holder.go` `answeredWords` (issue 372's fix, shortened by issue 639) made an answered ask's message one title, "You chose Approve at 20:03 on Telegram · <headline>", and dropped the body and Details. **Fix:** an answered ask keeps its headline as the title, its summary, points and link as the body, then its Details (whole on a proven kind, line by line under the content rule as on the open message). The note is how it ended and who acts on it. Buttons are gone as before. Telegram's `partsOf` cuts the body from its end past 4096 characters (the Details first), never the title or the note; a new telegram test pins that for an answered ask. **Tests:** `TestAnAsksMessageIsItsSummaryWithTheRestInItsNote` now asserts the whole question plus the answer note; it fails on main. Expired, replaced, whole-words and feedback tests updated to the new shape. `MESH_CHECK_MODULES=messenger,telegram sh merge-check.sh` passes locally (manifests not read by a controller: none built beside it).

mesh-admin added 1 commit 2026-10-14 18:06:57 +00:00

An answered ask keeps its question whole, its answer below it (issue 714) ... b7d9590fdc

Issue 372's fix with issue 639's one line edited an answered ask down to
'You chose X at HH:MM · headline', so the operator could not read back what
they approved. The headline stays the title, the summary, points, link and
Details stay the body, and how it ended and who acts on it become the note.
Telegram cuts the body from its end past 4096 characters, never the title or
the note.

mesh-admin commented 2026-10-14 18:07:05 +00:00

Author

Contributor

Copy Link

Copy Source

Delivery novox/mesh-catalog@b7d9590fdc95 — delivered since 2026-10-14T18:18:12Z

Delivery plan — builds messenger, telegram → novox; no bus step

• tier 0: messenger, telegram
• novox: receives messenger, telegram

Machines

• messenger on every machine running it: sent
• telegram on every machine running it: sent

Transitions

• 2026-10-14 18:07 (new) → proposed (announced): novox/mesh-catalog#299's head announced
• 2026-10-14 18:10 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-14 18:10 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-14 18:15 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-14 18:15 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-14 18:18 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@b7d9590fdc95` — **delivered** since 2026-10-14T18:18:12Z **Delivery plan** — builds messenger, telegram → novox; no bus step - tier 0: messenger, telegram - novox: receives messenger, telegram **Machines** - messenger on every machine running it: sent - telegram on every machine running it: sent **Transitions** - 2026-10-14 18:07 (new) → proposed (announced): novox/mesh-catalog#299's head announced - 2026-10-14 18:10 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-14 18:10 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-14 18:15 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-14 18:15 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-14 18:18 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin commented 2026-10-14 18:10:20 +00:00

Author

Contributor

Copy Link

Copy Source

Merge check at b7d9590f
Judged: head b7d9590fdc95 merged into trunk e1c8965ddbf1; read beside it: mesh-controller 4af9f1147de6, mesh-controller-main 4af9f1147de6, mesh-host 1a2677882380, mesh-tools 954e1a53eef9

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: messenger, telegram)
• mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds messenger, telegram → novox; no bus step

• tier 0: messenger, telegram
• novox: receives messenger, telegram
• read by no module's build: modules/messenger/README.md, modules/messenger/cmd/messenger/answers_test.go, modules/messenger/cmd/messenger/feedback_test.go, modules/messenger/cmd/messenger/glance_test.go, modules/messenger/cmd/messenger/replaced_test.go, modules/messenger/cmd/messenger/whole_test.go, modules/telegram/cmd/telegram/render_test.go

Run by the build seat on shanks as build-1792001221411214250 (builds --log build-1792001221411214250).

--- the gate: messenger, telegram
messenger: ok, 7 tool(s), invokes seat:mesh-controller.conditions, seat:mesh-controller.root-free, seat:issue-tracker.tracking, keeps state open, sent, asks, identities, walks; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
telegram: ok, 1 tool(s), keeps state offset, messages
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 1
2 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-14T17:56:50Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-14T17:56:50Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 1 tier(s): messenger, telegram

notes:
  - modules/messenger/README.md, modules/messenger/cmd/messenger/answers_test.go, modules/messenger/cmd/messenger/feedback_test.go, modules/messenger/cmd/messenger/glance_test.go, modules/messenger/cmd/messenger/replaced_test.go, modules/messenger/cmd/messenger/whole_test.go and modules/telegram/cmd/telegram/render_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 46927 strings of 719 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.013s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/secrets	0.012s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 62, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.213s
testing modules/messenger
ok  	messenger/cmd/messenger	2.323s
testing modules/telegram
ok  	telegram/cmd/telegram	1.064s
--- its merge-check-typescript.sh (typescript toolchain)

**Merge check** at `b7d9590f` Judged: head `b7d9590fdc95` merged into trunk `e1c8965ddbf1`; read beside it: mesh-controller `4af9f1147de6`, mesh-controller-main `4af9f1147de6`, mesh-host `1a2677882380`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: messenger, telegram) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds messenger, telegram → novox; no bus step - tier 0: messenger, telegram - novox: receives messenger, telegram - read by no module's build: modules/messenger/README.md, modules/messenger/cmd/messenger/answers_test.go, modules/messenger/cmd/messenger/feedback_test.go, modules/messenger/cmd/messenger/glance_test.go, modules/messenger/cmd/messenger/replaced_test.go, modules/messenger/cmd/messenger/whole_test.go, modules/telegram/cmd/telegram/render_test.go Run by the build seat on shanks as `build-1792001221411214250` (`builds --log build-1792001221411214250`). ``` --- the gate: messenger, telegram messenger: ok, 7 tool(s), invokes seat:mesh-controller.conditions, seat:mesh-controller.root-free, seat:issue-tracker.tracking, keeps state open, sent, asks, identities, walks; WARNING: settings ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) telegram: ok, 1 tool(s), keeps state offset, messages long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 1 2 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-14T17:56:50Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-14T17:56:50Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 1 tier(s): messenger, telegram notes: - modules/messenger/README.md, modules/messenger/cmd/messenger/answers_test.go, modules/messenger/cmd/messenger/feedback_test.go, modules/messenger/cmd/messenger/glance_test.go, modules/messenger/cmd/messenger/replaced_test.go, modules/messenger/cmd/messenger/whole_test.go and modules/telegram/cmd/telegram/render_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 46927 strings of 719 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.013s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/secrets 0.012s secrets: no setting can replace a vault secret in a mergeable file (1 known, nested) ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 62, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.213s testing modules/messenger ok messenger/cmd/messenger 2.323s testing modules/telegram ok telegram/cmd/telegram 1.064s --- its merge-check-typescript.sh (typescript toolchain) ```

mesh-admin merged commit e223262408 into main 2026-10-14 18:11:07 +00:00

mesh-admin deleted branch fix/an-answered-ask-keeps-its-text 2026-10-14 18:11:07 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jschoubben mesh-tools miel.truyen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#299