A delivering group says success on mesh/delivery-group, so its later members can merge (issue 902) #329

Merged

mesh-tools merged 1 commits from fix/902-group-member-merges-while-delivering into main 2026-10-16 09:16:37 +00:00

Conversation 3 Commits 1 Files Changed 3

+89 -6

mesh-tools commented 2026-10-16 09:13:05 +00:00

Member

Copy Link

Copy Source

Issue 902 (critical): group release/57-config-and-provisioning is stuck. hq and mesh-controller are delivered; mesh-host #116 and mesh-sdk #30 are ready and green but can never merge, because the merge rule (ADR 0382, gitea groupRefusal) needs mesh/delivery-group == success, and mesh-delivery wrote pending for a delivering group.

Fix in mesh-delivery:

• delivering writes success, only when the composed check passed for the members' current heads and is not out of date (otherwise pending);
• a closed group whose composed check failed for new heads reads rejected (review round 1);
• Group.SaidStatus: the status is written again when the status a state maps to changes, so a group already delivering gets success written once.

Tests (unit, 0.26 s package): TestReplay902 (mapping), TestReplay902TheNextMemberOfADeliveringGroupReadsSuccess (fails on main), TestReplay902AClosedGroupComposedAgainAndFailingSaysNoSuccess. Local cc9d5071, tree 2ed372db. Review: Opus round 1 CHANGES (applied), round 2 running. The operator chose this fix (option 3) at 11:06.

Issue 902 (critical): group release/57-config-and-provisioning is stuck. hq and mesh-controller are delivered; mesh-host #116 and mesh-sdk #30 are ready and green but can never merge, because the merge rule (ADR 0382, gitea groupRefusal) needs mesh/delivery-group == success, and mesh-delivery wrote pending for a delivering group. Fix in mesh-delivery: - delivering writes success, only when the composed check passed for the members' current heads and is not out of date (otherwise pending); - a closed group whose composed check failed for new heads reads rejected (review round 1); - Group.SaidStatus: the status is written again when the status a state maps to changes, so a group already delivering gets success written once. Tests (unit, 0.26 s package): TestReplay902 (mapping), TestReplay902TheNextMemberOfADeliveringGroupReadsSuccess (fails on main), TestReplay902AClosedGroupComposedAgainAndFailingSaysNoSuccess. Local cc9d5071, tree 2ed372db. Review: Opus round 1 CHANGES (applied), round 2 running. The operator chose this fix (option 3) at 11:06.

mesh-tools added 1 commit 2026-10-16 09:13:06 +00:00

A delivering group says success on mesh/delivery-group, so its later members can merge (issue 902) 8efe499db9

mesh-tools commented 2026-10-16 09:13:19 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-catalog@8efe499db965 — delivered since 2026-10-16T09:30:02Z

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery

Machines

• mesh-delivery on every machine running it: sent

Transitions

• 2026-10-16 09:13 (new) → proposed (announced): novox/mesh-catalog#329's head announced
• 2026-10-16 09:16 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-16 09:16 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-16 09:16 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-16 09:16 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-16 09:30 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@8efe499db965` — **delivered** since 2026-10-16T09:30:02Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Machines** - mesh-delivery on every machine running it: sent **Transitions** - 2026-10-16 09:13 (new) → proposed (announced): novox/mesh-catalog#329's head announced - 2026-10-16 09:16 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 09:16 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 09:16 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 09:16 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-16 09:30 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools added the mesh/ready label 2026-10-16 09:14:31 +00:00

mesh-tools commented 2026-10-16 09:14:32 +00:00

Author

Member

Copy Link

Copy Source

ready at 8efe499db9

Review (Opus): round 1 CHANGES (applied), round 2 APPROVE at cc9d5071 (tree 2ed372db = this head's). The operator chose this fix at 11:06.

ready at 8efe499db9658c8df08e96abd0b706e66867fc51 Review (Opus): round 1 CHANGES (applied), round 2 APPROVE at cc9d5071 (tree 2ed372db = this head's). The operator chose this fix at 11:06.

mesh-tools commented 2026-10-16 09:16:31 +00:00

Author

Member

Copy Link

Copy Source

Merge check at 8efe499d
Judged: head 8efe499db965 merged into trunk 173c5d5ef434; read beside it: mesh-controller 18c58b4903ad, mesh-controller-main 18c58b4903ad, mesh-host 49c9002c04d3, mesh-tools 6b3e15042fee

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
• mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery
• read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue902_test.go

Run by the build seat on shanks as build-1792141989485380197 (builds --log build-1792141989485380197).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, gitea.gitea_merge_pull_request, gitea.gitea_add_comment, gitea.gitea_api, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T09:04:57Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-16T09:04:57Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 48977 strings of 749 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.014s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/mailstore	0.010s
mail-store: claimed only by mesh-mail
ok  	git.novox.be/novox/mesh-catalog/checks/secrets	0.013s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 62, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.221s
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	3.339s
--- its merge-check-typescript.sh (typescript toolchain)

**Merge check** at `8efe499d` Judged: head `8efe499db965` merged into trunk `173c5d5ef434`; read beside it: mesh-controller `18c58b4903ad`, mesh-controller-main `18c58b4903ad`, mesh-host `49c9002c04d3`, mesh-tools `6b3e15042fee` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/issue902_test.go Run by the build seat on shanks as `build-1792141989485380197` (`builds --log build-1792141989485380197`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, gitea.gitea_merge_pull_request, gitea.gitea_add_comment, gitea.gitea_api, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T09:04:57Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-16T09:04:57Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 48977 strings of 749 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.014s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/mailstore 0.010s mail-store: claimed only by mesh-mail ok git.novox.be/novox/mesh-catalog/checks/secrets 0.013s secrets: no setting can replace a vault secret in a mergeable file (1 known, nested) ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 62, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.221s testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 3.339s --- its merge-check-typescript.sh (typescript toolchain) ```

mesh-tools merged commit ee1b15d7f0 into main 2026-10-16 09:16:37 +00:00

mesh-tools deleted branch fix/902-group-member-merges-while-delivering 2026-10-16 09:16:38 +00:00

mesh-tools referenced this pull request 2026-10-16 09:44:25 +00:00

Feature 57 (config and provisioning): release the catalogue #330

mesh-tools referenced this pull request 2026-10-16 10:57:04 +00:00

Feature 57 (config and provisioning): release the catalogue #330

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels mesh/ready

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jschoubben mesh-tools miel.truyen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#329